From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.58]) by mx.groups.io with SMTP id smtpd.web10.175.1600785800715687345 for ; Tue, 22 Sep 2020 07:43:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=RI3DPL5t; spf=pass (domain: arm.com, ip: 40.107.5.58, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a92Y7kPENP8QaRYBGPe7q2mB5PhmJ8fsj0qQ+JAmoCs=; b=RI3DPL5tHKJpEx6/4wAajMc5SvO+4oL9Tnx+GGCk1JtTF2GHc3gCtxltcZI+BVYkvVdAQFS/GxuteHttoa3VbdKDUYadahLmx8H8zOcZrsNPGPDsLNxZJ1bebkhK2aUdXQMFhEFOuMn5FGCKPiTuvcUFEa6ryWkOPRkN0u3yans= Received: from DB6PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:6:42::11) by VI1PR08MB4255.eurprd08.prod.outlook.com (2603:10a6:803:100::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Tue, 22 Sep 2020 14:43:17 +0000 Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::d) by DB6PR07CA0181.outlook.office365.com (2603:10a6:6:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:16 +0000 Received: ("Tessian outbound a0bffebca527:v64"); Tue, 22 Sep 2020 14:43:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 43eb02c42570c08e X-CR-MTA-TID: 64aa7808 Received: from 9bf59975822a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17F2CEC7-757C-4D17-BB49-AD53277E3591.1; Tue, 22 Sep 2020 14:42:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9bf59975822a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0AX5dAkKDtZHUYUPDHCXmweYcfUqhF4lEmHF6NN6f1B/Evs9Pi9rI5f3th4bQDrHwwwil/HNd7ZakOkKVNoH+YIuLe/jVvkMKu05S6lh7A8KHyGryYs9e7tNDyKa61wZzhZlpQyGF8FE2NKA+VhJYRZcgplwDVHUkH8QCfSOB4CIdFSx5QCMNFj1hESid73njYk/r0qKMr97b+UdQaYIRbOaKhykerm2bPYLGsB45opOLjnsLdEVixsM7zJCtdt3nlf6r1LZkA6q1uc+xjiK24fxnC4+EwYVulJvS2FmrZQ8OLmuLazoIbob6Nd3lVmIKMtoBXwRTCFJmZjDOiBwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a92Y7kPENP8QaRYBGPe7q2mB5PhmJ8fsj0qQ+JAmoCs=; b=I/We/9prnHpw831kZuwfXpLGmbrqPtvUb8SckTvX8VuC/LVBGlVkkWxMtLgDx9gnJAsKXCZsanzfnIWA1kyhqEXk7lc+EbgI+TPXAmq/DBRsRFCXPKYQVoJDcpiGAz3GvtOnC0gxQ2IZ7dCFD9S/346NDtqFmVU1nHqH1DVnbjxdi3SpM7BEF4yPuAhBPYI4Pqg9zx8TgTppduyN28lKFMJweRQqHZY5jRzfTJG/l3WDU/YMw3YtF0Nfnh7Kj8wUsBey5cBwJtq3+ZLFDcpIpH889zcbYS1jQT3/ifP/HqM2BlEB++yCkioFIZ+XG/beDHv2FfJJ9uVDCmX3SshUwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a92Y7kPENP8QaRYBGPe7q2mB5PhmJ8fsj0qQ+JAmoCs=; b=RI3DPL5tHKJpEx6/4wAajMc5SvO+4oL9Tnx+GGCk1JtTF2GHc3gCtxltcZI+BVYkvVdAQFS/GxuteHttoa3VbdKDUYadahLmx8H8zOcZrsNPGPDsLNxZJ1bebkhK2aUdXQMFhEFOuMn5FGCKPiTuvcUFEa6ryWkOPRkN0u3yans= Received: from AM5PR0101CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::47) by DB6PR08MB2629.eurprd08.prod.outlook.com (2603:10a6:6:22::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:42:40 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::94) by AM5PR0101CA0034.outlook.office365.com (2603:10a6:206:16::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13 via Frontend Transport; Tue, 22 Sep 2020 14:42:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:39 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:37 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 22 Sep 2020 14:42:37 +0000 Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:36 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v1 2/7] DynamicTablesPkg: SsdtSerialPortLibArm fix ECC error Date: Tue, 22 Sep 2020 15:42:30 +0100 Message-ID: <20200922144235.76292-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b0d0d37-b26c-4c7b-4901-08d85f05d78f X-MS-TrafficTypeDiagnostic: DB6PR08MB2629:|VI1PR08MB4255: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MMO1EJz1Hf/7vVcorEZn1o65IbTRXe5OUFu8bmE04MgghXXYQY1u8hj5VG9uTbYnerUqk0EKNJTKjSZD/P+Pdi55/1h9MBz9pfSDHiQ5qI7E2s0DO2KUvITrMQa69UlPDhkGpiW+eKujpCqrmlHZO1sAIYxaP4z75KfuUjtCk8CQJ/B4qFEENqwVMN68WjXXuoh3SGjHS8GBPUgzbq8VRfPgfqffj9U48wGNzP6ruYqluKiHUA3Xx0Cc/w1vVE1Z32d3FKStGMJ7d0kd7E/d6Pqzy8B4QG6ZV+7RvbzbmjYStoTVdkEMYQdP3omJ7ifuTEcPG3nH4Zk5HCrf/Dz/28zR6DBC6GlEGiMJzPl6c/3aQ1y82F/SRCxYEfgH+1Y3sFbcFktyLFSgTK6j1KKfLEJF0pjgxDlQ/6GZFFO/2/A= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(46966005)(83380400001)(86362001)(44832011)(8936002)(6666004)(54906003)(2616005)(82740400003)(478600001)(356005)(81166007)(47076004)(36756003)(26005)(82310400003)(70206006)(8676002)(316002)(5660300002)(70586007)(336012)(426003)(4326008)(6916009)(2906002)(1076003)(186003)(7696005)(213903007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2629 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 55a8ce23-4b3b-4336-9966-08d85f05c13c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AOL2jbwfkwUtga3MpP9qWIamkVvVmOlMVbANe9nyTXTW44whOOyagaOzxo73wWdnnvdtUZgUUjOXad996m7/RiTQyxsppYxHKtJJJA/oaxQiB+uZRFDX5z0M/XE9+O7cwtu984Tk4JMOGyTsgeUHgbinbYmXaHCNOtwSCa7wKXcDkLZu+2vcd69ylyMNfaxfpKkSxL23MBQ+5lgOoFbqgJiE+1UdzeU6N5EZRdzO8pIJnqqlVMp5o14Kowt2mHQ1DJoFZxN1AW4LHPOWVX5KqqHKWBCJmColBX73da8HewkmWgyYWAF3Vh+/Twdb1B+8F+wnKht65g+nq/EvTJwtlFT6wVgvkhQt3QmyFRHh1sY9oQLdS7bYkxKkiHDX0cnoE0AoZVYmrnwTQKplcfGqsZIbdHAAuoSlnCQql+ec8DE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(136003)(39840400004)(396003)(376002)(46966005)(82310400003)(7696005)(54906003)(44832011)(86362001)(47076004)(81166007)(316002)(4326008)(2616005)(6666004)(2906002)(26005)(5660300002)(336012)(8936002)(426003)(186003)(36756003)(478600001)(70586007)(83380400001)(6916009)(70206006)(1076003)(8676002)(213903007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:16.8832 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b0d0d37-b26c-4c7b-4901-08d85f05d78f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4255 Content-Type: text/plain Fix the following ECC reported error in SsdtSerialPortLibArm. - [5007] There should be no initialization of a variable as part of its declaration Variable Name. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c index a705d771be1a2d59c4b0f645269eb838ff605a1a..6a1e7487dfaf4ceb2e074e52cef2fc30bfce7152 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c @@ -171,7 +171,7 @@ BuildSsdtSerialPortTableEx ( CM_ARM_SERIAL_PORT_INFO * SerialPortInfo; UINT32 SerialPortCount; UINTN Index; - CHAR8 NewName[] = "COMx"; + CHAR8 NewName[5]; UINT64 Uid; EFI_ACPI_DESCRIPTION_HEADER ** TableList; @@ -243,6 +243,10 @@ BuildSsdtSerialPortTableEx ( // can be done in case of failure. *Table = TableList; + NewName[0] = 'C'; + NewName[1] = 'O'; + NewName[2] = 'M'; + NewName[4] = '\0'; for (Index = 0; Index < SerialPortCount; Index++) { Uid = SERIAL_PORT_START_UID + Index; NewName[3] = AsciiFromHex ((UINT8)(Uid)); -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'