From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.66]) by mx.groups.io with SMTP id smtpd.web12.163.1600785799275508948 for ; Tue, 22 Sep 2020 07:43:19 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ZaWy/8ji; spf=pass (domain: arm.com, ip: 40.107.22.66, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Wszz1QC2KXkU6zVqIRieLjKIwDFE2GncJoVU/HKyiA=; b=ZaWy/8ji1BihpBdevNJn050tzvHd97TUaqzZDKM9qERZowjy7XJn++jMBYXw7Na0TvPNAQwfgc8k9N3BpyanVl7GigUSVTlba0mJyc2UO5oP3DnwCimrys/nZNy9lyQpOS+CGhzjZmiEWoi2ErpX+0heKyKdhy3nqkyndSuUghY= Received: from MR2P264CA0003.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::15) by HE1PR0802MB2474.eurprd08.prod.outlook.com (2603:10a6:3:e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:43:15 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::66) by MR2P264CA0003.outlook.office365.com (2603:10a6:500:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Tue, 22 Sep 2020 14:43:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:43:14 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Tue, 22 Sep 2020 14:43:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4999a56da1a3e1e6 X-CR-MTA-TID: 64aa7808 Received: from a365adf861ef.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1512535B-9FE5-408F-9DE6-192C7B206C1F.1; Tue, 22 Sep 2020 14:42:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a365adf861ef.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Sep 2020 14:42:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2ZXd+nODbr7pNZEZxPYirG7AWhLcA/bgFBt+H0toaUcmOaiy3AZ/Bo0jgAMSH4LDoSfuVsBXc4EWSshAphzqy05SkE1o5atKEZNZXn4cSe2xZgffdLdCjjZzIyCjlxjt/ziI4MWyiM2t7QvmM7brZtb2B0DR25kigw3GdXNOQ9Tm3jjRVXvGVqg0SI88DSAdNgE1+QATVarTTdAxpQtTL1yIV6inBe0kCPMJGjPJRaMbK70JXUXQ5JVtxZL0LSTjHthbXhtW6gk+PzifG/LPMEjztRrms+vMU9SgIaIn5wydG4MYK5OBf+EKrYXni3VZH6dqpmNMfjMV3r/w+kZ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Wszz1QC2KXkU6zVqIRieLjKIwDFE2GncJoVU/HKyiA=; b=cssuAC/dr+ezTTOGiOeGQHTTKQImO0UsboSzbB9aXIxDiKj/xHPrV/axVKPi6FqwcufIgWFX6UB8NTDu2EUgcrwn5uvWeClfn8DoYpGvdmtH4RWAaPxW4Qqbhk+inSpCU4uuwfkcINQLCvIUIZ8q32W2+kL9Wzf9Uit4G0N7QB7H6cmFFl4mDJeicgGKqo2nt7LIpG7dJEtfNh5CZlsWTaI2FHws3p1eVJFRld7j3MSY/10WIkcuMpPx6gVEHQEUN44bd1BHfAM9zrjLXU/LGGWMYmdPqFDnfNxbBzPaJS1wtdagFSNLnrZc9vYjF5/31tUF6teIEVM0bPcaXFY8NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Wszz1QC2KXkU6zVqIRieLjKIwDFE2GncJoVU/HKyiA=; b=ZaWy/8ji1BihpBdevNJn050tzvHd97TUaqzZDKM9qERZowjy7XJn++jMBYXw7Na0TvPNAQwfgc8k9N3BpyanVl7GigUSVTlba0mJyc2UO5oP3DnwCimrys/nZNy9lyQpOS+CGhzjZmiEWoi2ErpX+0heKyKdhy3nqkyndSuUghY= Received: from DB6PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:4:29::14) by VI1PR08MB3567.eurprd08.prod.outlook.com (2603:10a6:803:79::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 14:42:46 +0000 Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:29:cafe::fd) by DB6PR0202CA0004.outlook.office365.com (2603:10a6:4:29::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Tue, 22 Sep 2020 14:42:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3391.15 via Frontend Transport; Tue, 22 Sep 2020 14:42:46 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Tue, 22 Sep 2020 14:42:38 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Tue, 22 Sep 2020 14:42:38 +0000 Received: from E107187.Arm.com (10.57.47.90) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Tue, 22 Sep 2020 14:42:37 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v1 4/7] DynamicTablesPkg: AmlLib fix ECC errors Date: Tue, 22 Sep 2020 15:42:32 +0100 Message-ID: <20200922144235.76292-5-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200922144235.76292-1-sami.mujawar@arm.com> References: <20200922144235.76292-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a318ebb0-8d77-4f00-a293-08d85f05d62e X-MS-TrafficTypeDiagnostic: VI1PR08MB3567:|HE1PR0802MB2474: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:5797;OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fOhIEO4iqrGJyxp/On+nmCPIwuuve/T3KUkGl02SFSThWhmo8TIR76D6JDXFGfvHr78hb8kF52cvftKVw1GC9Xu4OY0oGnd9VFmvr1ygsGxxTfG5RzB8OGvqIhQocAVRmkESHBA0IKO/59I81/Ab28kJ2/7XQ6Zpz1myh96x1XqF8lLJfMF1DfXIpO2uBGdSIWaWUlQSQh86WHzEZ+rD4a76nI3C6SCEuuLcRVe8QM1V/JTj5QTTETjQo7pDTZXXAA6Sfg37IjnyjtrwKs9WuRdL38iygf+rKkGD62tXVlB0FveRB7wsNPDNl6aWsgK3UEfATfaShCP0nsmOqZnG20dUQFqrDH8bI3N4b3jW8K4i0afKD6m+q592HQjZVz0FgEsRTv8mhd9mm6TUrQlJnQ== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(136003)(346002)(39860400002)(376002)(46966005)(7696005)(26005)(8936002)(82310400003)(356005)(81166007)(336012)(316002)(5660300002)(2616005)(426003)(2906002)(44832011)(86362001)(186003)(4326008)(6666004)(6916009)(1076003)(8676002)(54906003)(70206006)(70586007)(19627235002)(83380400001)(478600001)(47076004)(36756003)(82740400003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3567 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d63adad9-d4ad-48be-24ed-08d85f05c55b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Itgfv7sL8HSrGuuS6qtpGahkhEOcjRGGIreDhUIcco8tt3UBYP9EKR4X1NjgAMIpdJUezsVllS0jWTEf1Rxu8wUGBgci5ryfhesYN/EvTWzF2oiCwOE8T40sCRDDNZdnBZdaqeweC3Ci5qRRc5CMET4k02IMG+i1oJWM1YlSv1ORPpN+Q747qBgzxDnszGTaNI8tzmk9Vt9bTqOKfOZxyjeg5V6NwHyrjHc6XuYl/sqRT7wacft7RAgSh1qEZTioD07KF/ISk11hYa3/BcGDpHDcWLVRi4CX1kw82FRC2brQz87fAnsL+pGjlBXHtZ3WoEkymXr1ZNBIWD9FvrsSD3K0zmWQZQ1YThdwNX6pmAC+dIY6F65ax2b6SrZAvkFLbREAED5r+98YwslFTGdmuA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39840400004)(346002)(376002)(396003)(136003)(46966005)(336012)(6916009)(478600001)(6666004)(83380400001)(426003)(7696005)(81166007)(5660300002)(8936002)(19627235002)(186003)(1076003)(26005)(8676002)(86362001)(54906003)(47076004)(36756003)(82310400003)(44832011)(316002)(70206006)(2616005)(36906005)(4326008)(2906002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2020 14:43:14.4321 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a318ebb0-8d77-4f00-a293-08d85f05d62e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2474 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Fix the following ECC reported errors in AmlLib. - [1008] File has invalid Non-ACSII char. - [9002] The function headers should follow Doxygen special documentation blocks in section 2.3.5 Comment does NOT have tail **/ Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c | = 2 +- DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c | = 4 ++-- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c | = 6 +++--- DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c | = 2 +- 10 files changed, 19 insertions(+), 19 deletions(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index d6d9f5dfe839aa8ef79153459ec9d2c2ffe72316..5d310f201319d94ffe6405aeeec= 65a7038a76c57 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -33,7 +33,7 @@ EFIAPI LinkNode ( IN AML_OBJECT_NODE * Node, IN AML_NODE_HEADER * ParentNode, - IN AML_OBJECT_NODE ** NewObjectNode + OUT AML_OBJECT_NODE ** NewObjectNode ) { EFI_STATUS Status; @@ -71,7 +71,7 @@ LinkNode ( @param[in] OemId 6-character string OEM identifier. @param[in] OemTableId 8-character string OEM table identifier= . @param[in] OemRevision OEM revision number. - @param[out] DefinitionBlockTerm The ASL Term handle representing a + @param[out] NewRootNode Pointer to the root node representing a Definition Block. =20 @retval EFI_SUCCESS Success. diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceData= CodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC= odeGen.c index 9e7a508e60721558ab59b375dbd526c7066d7329..d40a27410dd6fee8264b9c53e67= f7ea67d97fcf0 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen= .c @@ -40,7 +40,7 @@ EFIAPI LinkRdNode ( IN AML_DATA_NODE * RdNode, IN AML_OBJECT_NODE * ParentNode, - IN AML_DATA_NODE ** NewRdNode + OUT AML_DATA_NODE ** NewRdNode ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.= c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c index dc373748903dd55fa4492874329f2b433c698c02..30d31572d379028a28d532c1709= 2bef585959a50 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c @@ -674,7 +674,7 @@ AmlAddPrefix ( =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListPars= er.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c index c25ee22dc7c4b22b1448e11cf9bbd4e5e77c4316..b9403efe3ca6f44712c91203c27= 410ec15eb3011 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlFieldListParser.c @@ -41,7 +41,7 @@ @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -177,7 +177,7 @@ AmlParseFieldElement ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.= c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c index bc98d950b579dec3243dab355a711a56dca978ea..4797fa11edebc35628ef9c07a1f= effff6b14a204 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlMethodParser.c @@ -1320,7 +1320,7 @@ AmlCreateMethodInvocationNode ( // DefExternal :=3D ExternalOp NameString ObjectType ArgumentCount // ExternalOp :=3D 0x15 // ObjectType :=3D ByteData - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) =20 // Read the ArgumentCount. ArgCountNode =3D (AML_DATA_NODE*)FixedArgs[EAmlParseIndexTerm2]; @@ -1334,7 +1334,7 @@ AmlCreateMethodInvocationNode ( // MethodInvocation :=3D MethodInvocationOp NameString ArgumentCount // MethodInvocationOp :=3D Pseudo Opcode for Method Invocation // NameString :=3D Method Name - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) Status =3D AmlCreateObjectNode ( AmlGetByteEncodingByOpCode (AML_METHOD_INVOC_OP, 0), 0, @@ -1411,7 +1411,7 @@ error_handler: @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ EFI_STATUS EFIAPI AmlGetMethodInvocationArgCount ( diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c index 380ac9bbcebef01d1d1f5dbd01971992aaf66d89..4f6623de02d519e5345955603d0= ce3f1056e4f17 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c @@ -1134,7 +1134,7 @@ AmlParseVariableArguments ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -1179,7 +1179,7 @@ AmlPopulateRootNode ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI @@ -1287,7 +1287,7 @@ AmlPopulateObjectNode ( @retval EFI_BUFFER_TOO_SMALL No space left in the buffer. @retval EFI_INVALID_PARAMETER Invalid parameter. @retval EFI_OUT_OF_RESOURCES Could not allocate memory. -*/ +**/ STATIC EFI_STATUS EFIAPI diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataP= arser.c b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataPars= er.c index 09fb3e72586c3f31ce6d90f049e77a041330ba18..0f41c68b283794a577c551b0320= afc5b6dcf55d7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlResourceDataParser.c @@ -213,7 +213,7 @@ AmlRdIsResourceDataBuffer ( return TRUE; } =20 - // TODO Might want to check the CRC when available. + // @todo Might want to check the CRC when available. // An end tag resource data element must be the last element of the li= st. // Thus the function should have already returned. if (AmlRdCompareDescId ( diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c b/Dy= namicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c index 419e796e50cbe29e62234916c6e39c2c625a2951..08ee959475dd26b72c90598daa5= 3db639b075928 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Stream/AmlStream.c @@ -52,7 +52,7 @@ AmlStreamInit ( in the ClonedStream. =20 @param [in] Stream Pointer to the stream to clone. - @param [in] ClonedStream Pointer to the stream to initialize. + @param [out] ClonedStream Pointer to the stream to initialize. =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. @@ -97,7 +97,7 @@ AmlStreamClone ( =20 @param [in] Stream Pointer to the stream from which a sub-stream = is created. - @param [in] SubStream Pointer to the stream to initialize. + @param [out] SubStream Pointer to the stream to initialize. =20 @retval EFI_SUCCESS The function completed successfully. @retval EFI_INVALID_PARAMETER Invalid parameter. diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c b/Dynami= cTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c index 2c80440a447ad261290a2cf84a8edd3434cf9e5e..3740c0ac7bb8d2697bc1597dc10= 30d8276e6f565 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlNode.c @@ -464,7 +464,7 @@ AmlNodeCompareOpCode ( =20 @retval TRUE The Node is an integer node. @retval FALSE Otherwise. -*/ +**/ BOOLEAN EFIAPI IsIntegerNode ( @@ -499,7 +499,7 @@ IsIntegerNode ( =20 @retval TRUE The Node is a ZeroOp or OneOp. @retval FALSE Otherwise. -*/ +**/ BOOLEAN EFIAPI IsSpecialIntegerNode ( @@ -556,7 +556,7 @@ AmlIsMethodDefinitionNode ( // DefExternal :=3D ExternalOp NameString ObjectType ArgumentCount // ExternalOp :=3D 0x15 // ObjectType :=3D ByteData - // ArgumentCount :=3D ByteData (0 =E2=80=93 7) + // ArgumentCount :=3D ByteData (0 - 7) ObjectType =3D (AML_DATA_NODE*)AmlGetFixedArgument ( (AML_OBJECT_NODE*)Node, EAmlParseIndexTerm1 diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c b/Dynami= cTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c index 65dad95da2760c512563a5152ba4acf42d555019..0931e751709e27ad4f0b4c583d8= b058ce06f5bf7 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/Tree/AmlTree.c @@ -41,7 +41,7 @@ AmlGetParent ( =20 @return The root node of the tree. NULL if error. -*/ +**/ AML_ROOT_NODE * EFIAPI AmlGetRootNode ( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'