From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.12512.1600864635742306349 for ; Wed, 23 Sep 2020 05:37:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: bob.c.feng@intel.com) IronPort-SDR: zZsZbJimyxM/4tX4LUlZ7w1MloaroGmgN+m9Rci+LcB00J1p44BrgjVtH9Ihtmuz+CFX+prTap kK5CJKlOeImg== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160950941" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="160950941" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 05:37:14 -0700 IronPort-SDR: 24Vd2hc3k4CfH5ysZf/fleL0e2JGYJ5vMw7IucluoIHQ0l2eus5K7JqISkc/F0OFXoM6GClVfH 4a+gkYCASp6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="511631207" Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.66]) by fmsmga005.fm.intel.com with ESMTP; 23 Sep 2020 05:37:13 -0700 From: "Bob Feng" To: devel@edk2.groups.io Cc: Liming Gao , Yuwei Chen Subject: [Patch] BaseTools: Remove CanSkip calling for incremental build Date: Wed, 23 Sep 2020 20:36:58 +0800 Message-Id: <20200923123658.40652-1-bob.c.feng@intel.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2978 If a module add a new PCD, the pcd token number will be reassigned. The new Pcd token number should be updated to all module's autogen files. CanSkip can only detect a single module's change but not others. CanSkip block the pcd token number update in incremental build, so this patch is going to remove this call. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py index dc8b1fe3d1..eebf6e87f5 100755 --- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py @@ -1820,13 +1820,10 @@ class ModuleAutoGen(AutoGen): if not self.IsLibrary and CreateLibraryCodeFile: for LibraryAutoGen in self.LibraryAutoGenList: LibraryAutoGen.CreateCodeFile() - # CanSkip uses timestamps to determine build skipping - if self.CanSkip(): - return self.LibraryAutoGenList AutoGenList = [] IgoredAutoGenList = [] for File in self.AutoGenFileList: -- 2.20.1.windows.1