From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.40]) by mx.groups.io with SMTP id smtpd.web10.14832.1600948171094595083 for ; Thu, 24 Sep 2020 04:49:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=29v4F+TZ; spf=pass (domain: arm.com, ip: 40.107.21.40, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sm1bYvV4ijKNbmxg3n7rJDBl7ZCon1KmrlFnBSOWtPA=; b=29v4F+TZL6dU87JwYNz84Y5pwfxAii31NMl8+XNK4sduwdyWjUn3QRHgw9L0c6zqHq0fqM90DWixgTerzndz2NAP/8wpbRldqe+P+2mrAp5BFtpMTnQlK7/oUsKKRNgAIjUqJgeOqvhpKVs6JI2LLVimen2xt/QKd+tzhnDmo80= Received: from AM6P194CA0080.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::21) by HE1PR0802MB2457.eurprd08.prod.outlook.com (2603:10a6:3:df::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Thu, 24 Sep 2020 11:49:27 +0000 Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::e0) by AM6P194CA0080.outlook.office365.com (2603:10a6:209:8f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Thu, 24 Sep 2020 11:49:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Thu, 24 Sep 2020 11:49:27 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Thu, 24 Sep 2020 11:49:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d7fca4c1aa85fb19 X-CR-MTA-TID: 64aa7808 Received: from 756ab1743ef6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4CBD435D-8409-46C7-BD6B-69EECBF28733.1; Thu, 24 Sep 2020 11:49:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 756ab1743ef6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 24 Sep 2020 11:49:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OK5RdqDwtCee0pcvwAWcEMLMdzu+39KUqiuh2tjX/cQpmaEPIoXfX9ZESt+y8VjzxvR8SkpWkWiyyk1gvVGj+u1HLUaIvZLxapnnb/Rrzas2JmsiC6p/ybjf+EboMXhruw2EQv8bWhBiZa0FDU2v/I9JruAg//ofVvJSeWi+rTNhfo2o8kUKv0UmAw07zmKD1nSlMN0erBwgLZhfcF3NG+2xDGoEClRSDFmPaCcaY/1kraEX2YZESkL6z5TNbrrKmubWGG5oSk+cBOYoSjCrG0gkqn9xfS1/Ld5P3gxT0xN0iKiXA7RZ7Oj/qeNo7CbHMSsqZQGR8yQzwPqxZoa6vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sm1bYvV4ijKNbmxg3n7rJDBl7ZCon1KmrlFnBSOWtPA=; b=kMdyZUa3wL8VhrA3qGOPqqH44T2OImSxxLq+UkvRPO+j2dTvAHG4AkkB0p50ZmrANOc0V9qE+oCXHQQh4hJImvrRgl90YZivWPUycUPaZ7If87qVm3pDQ5ceGdzoCpVOZT3aktlUVOwkGDpNYDpU7WTugRujujBMqBB8WpcTxC6cCCJXn5XTUeA5pG1fP5rryXGaWrZ1KBTOGe1+gAzxI+HUiG3ST/jo2csuBJMYeakrcYMAP09Hw8TPJ5xlG1vy/Gea6WcG81FsVjw3Ht9paB7sObFsbQNqKP8qrFAym4gvemkzn9t2Neuqo2MxZLXV/8Ym5Zfb9NxeahfLhpByhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sm1bYvV4ijKNbmxg3n7rJDBl7ZCon1KmrlFnBSOWtPA=; b=29v4F+TZL6dU87JwYNz84Y5pwfxAii31NMl8+XNK4sduwdyWjUn3QRHgw9L0c6zqHq0fqM90DWixgTerzndz2NAP/8wpbRldqe+P+2mrAp5BFtpMTnQlK7/oUsKKRNgAIjUqJgeOqvhpKVs6JI2LLVimen2xt/QKd+tzhnDmo80= Received: from MR2P264CA0044.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::32) by DB8PR08MB4570.eurprd08.prod.outlook.com (2603:10a6:10:ae::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22; Thu, 24 Sep 2020 11:49:17 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:0:cafe::4d) by MR2P264CA0044.outlook.office365.com (2603:10a6:500::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Thu, 24 Sep 2020 11:49:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3412.21 via Frontend Transport; Thu, 24 Sep 2020 11:49:17 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Thu, 24 Sep 2020 11:49:16 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Thu, 24 Sep 2020 11:49:16 +0000 Received: from E107187.Arm.com (10.57.53.17) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Thu, 24 Sep 2020 11:49:15 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v2 2/2] ShellPkg/AcpiView: Fix field validator invocation Date: Thu, 24 Sep 2020 12:49:13 +0100 Message-ID: <20200924114913.109188-3-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20200924114913.109188-1-sami.mujawar@arm.com> References: <20200924114913.109188-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38f2e3b3-6eac-4e4a-5466-08d8607fe3cf X-MS-TrafficTypeDiagnostic: DB8PR08MB4570:|HE1PR0802MB2457: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kEDRi1pnG9D3gkv/WoEar82acGT0jem54Qm5YSx/zLBgxXLQDVSdq1YQtqbrsImAuFct61xwotx8VwnN7c54hvoIRyPoQJnX+QYtBny9i638sAMXax7R4EtdAC7eKlHu0071E6JoLARvmi4aknQ7qrlXeJ7jjvs3JT2gU9o4hCANakhncZt70ujE1Eeq0jmSRYHUULJJDSLTol1LO81e/2DNcQ4R8xLyQCU1axUTNHipwgLptvp3SLGd2/N+XZsxJDBDhAZmGmyUK0vUAD2HxHm3XLOh7IoEzi3+0+U+sZtOmtO+fPPqOrFKas45nqRMQL3uAAvCTutfmP2WHASQOls1uy/A9qm4kkXJeiX0W1bHudwVXy0CfdeXEAWJMAxn2dsx0tCQ2dd8E6iXMX/z2IHVVpL9Ke9JyvHikScWX7aUd7vQ3yZHg0f7gYe4Jk1n X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966005)(478600001)(54906003)(6916009)(4326008)(316002)(44832011)(86362001)(2906002)(8676002)(8936002)(5660300002)(36756003)(1076003)(82310400003)(83380400001)(70206006)(70586007)(7696005)(2616005)(47076004)(81166007)(82740400003)(336012)(26005)(186003)(426003)(356005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4570 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cf3ab5f1-0741-4084-fd5d-08d8607fdded X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Plrlk9jJjBfu3CRW0HQ/HwYZQ0YuF/3xHDVAaTytXTC0Tm13LljM5SLdz1G/BZNimL3SEQQSxjcP8s/oPGh3DH6UbEj1BkWY6RIsFbVgx7JO93d+7cklXMClzftUHpMFhdi4rlolZYodWO92HoChU5E9FwsYCTPQZbdpU/KTcSnWtU6rrGkxm2oultry+8j45/Vb/i53RqpWEpG7iw6SKlkDvUb5UXWhKJme/Ngcuqg3ltH8LeD+KT8D61kXCrthph8R2pu0dnJH5fOyKRAM/T7+UzyTFEo2OnDX0ltjMSlLa/QYuJnChmqIfAWueV2ecaWfZih9bGGyNH87qMfr8MrS5DfLuqOXC/g7HdJauXaq5QSd1t2VBHyRThC8YUQK3mq1E3fYOoHQGsY1zVwCRQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966005)(54906003)(70586007)(2906002)(82740400003)(4326008)(36756003)(70206006)(47076004)(8676002)(6916009)(478600001)(8936002)(2616005)(36906005)(81166007)(86362001)(26005)(44832011)(83380400001)(82310400003)(336012)(7696005)(426003)(186003)(316002)(1076003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2020 11:49:27.0944 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 38f2e3b3-6eac-4e4a-5466-08d8607fe3cf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2457 Content-Type: text/plain The field validator function provides means to validate fields in the ACPI table structures. To print complex field types a print formatter function is provided. The field validator was being invoked for simple data fields for which the default print format is used. However, the field validator function was not invoked if a print formatter function was provided. This problem is noticed when a Generic Address Structure (GAS) is printed using DumpGas() and a field validator is present to validate the GAS structure. To fix this move the invocation of the field validator after the field is printed such that the validation function is called even when a print formatter function is present. Signed-off-by: Sami Mujawar --- Notes: v2: - This is a new patch introduced in v2 series. [SAMI] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 02f6d771c7e1a9b8faa577b38e51c9de350d24fd..01ac9a9bafeb2ca12c1ba19f406d626b108f5fe2 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -596,13 +596,12 @@ ParseAcpi ( Parser[Index].Length ); } // switch - - // Validating only makes sense if we are tracing - // the parsed table entries, to report by table name. - if (GetConsistencyChecking () && - (Parser[Index].FieldValidator != NULL)) { - Parser[Index].FieldValidator (Ptr, Parser[Index].Context); - } + } + // Validating only makes sense if we are tracing + // the parsed table entries, to report by table name. + if (GetConsistencyChecking () && + (Parser[Index].FieldValidator != NULL)) { + Parser[Index].FieldValidator (Ptr, Parser[Index].Context); } Print (L"\n"); } // if (Trace) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'