* [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain
@ 2020-09-24 21:21 Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Rebecca Cran
0 siblings, 2 replies; 6+ messages in thread
From: Rebecca Cran @ 2020-09-24 21:21 UTC (permalink / raw)
To: devel; +Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Rebecca Cran
build.sh usage indicates that "GCC5" can be specified, but it's currently
rejected due to a case statement only matching "GCC" or "gcc".
Fix this by adding a wildcard match.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
uefi-sct/SctPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
index cad17ccd..be610deb 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -151,7 +151,7 @@ case `uname` in
TARGET_TOOLS=ARMGCC
;;
- GCC | gcc)
+ GCC* | gcc*)
set_cross_compile
CROSS_COMPILE="$TEMP_CROSS_COMPILE"
export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md
2020-09-24 21:21 [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain Rebecca Cran
@ 2020-09-24 21:21 ` Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Rebecca Cran
1 sibling, 0 replies; 6+ messages in thread
From: Rebecca Cran @ 2020-09-24 21:21 UTC (permalink / raw)
To: devel; +Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Rebecca Cran
The mailing list has changed from lists.01.org to groups.io.
Update Maintainers.txt and Readme.md to match.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
uefi-sct/Maintainers.txt | 2 +-
uefi-sct/Readme.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index c5f11c7d..cfad3b78 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -46,4 +46,4 @@ R: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
General questions on UEFI-SCT with the subject [edk2-test] can be sent to
-L: edk2-list <edk2-devel@lists.01.org>
+L: edk2-devel <devel@edk2.groups.io>
diff --git a/uefi-sct/Readme.md b/uefi-sct/Readme.md
index 8445f4d5..1a049b60 100644
--- a/uefi-sct/Readme.md
+++ b/uefi-sct/Readme.md
@@ -24,5 +24,5 @@ are listed in [Maintainers.txt](Maintainers.txt).
# Resources
* [TianoCore](http://www.tianocore.org)
* [Getting Started with UEFI-SCT](https://github.com/tianocore/tianocore.github.io/wiki/UEFI-SCT)
-* [Mailing List](mailto:edk2-devel@lists.01.org?subject=[edk2-test])
+* [Mailing List](mailto:devel@edk2.groups.io?subject=[edk2-test])
* [UEFI-SCT BugTracker](https://bugzilla.tianocore.org/)
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh
2020-09-24 21:21 [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
@ 2020-09-24 21:21 ` Rebecca Cran
2020-11-11 21:17 ` [edk2-devel] " Samer El-Haj-Mahmoud
1 sibling, 1 reply; 6+ messages in thread
From: Rebecca Cran @ 2020-09-24 21:21 UTC (permalink / raw)
To: devel; +Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Rebecca Cran
build.sh contains a mixture of tabs and spaces, with differing
numbers of spaces used for indents. Update it so any single block only
uses one style of indentation.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
uefi-sct/SctPkg/build.sh | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh
index be610deb..37667711 100755
--- a/uefi-sct/SctPkg/build.sh
+++ b/uefi-sct/SctPkg/build.sh
@@ -56,9 +56,9 @@ function get_gcc_version
{
gcc_version=$($1 -dumpversion)
- if [ ${gcc_version%%.*} -gt 5 ]; then
- gcc_version=5
- fi
+ if [ ${gcc_version%%.*} -gt 5 ]; then
+ gcc_version=5
+ fi
case $gcc_version in
4.6*|4.7*|4.8*|4.9*|5*)
@@ -152,10 +152,9 @@ case `uname` in
;;
GCC* | gcc*)
- set_cross_compile
- CROSS_COMPILE="$TEMP_CROSS_COMPILE"
- export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
-
+ set_cross_compile
+ CROSS_COMPILE="$TEMP_CROSS_COMPILE"
+ export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
;;
*)
@@ -224,7 +223,7 @@ then
status=$?
if test $status -ne 0
then
- echo Error while building EDK tools
+ echo Error while building EDK tools
exit -1
fi
else
@@ -239,7 +238,7 @@ make -C SctPkg/Tools/Source/GenBin
status=$?
if test $status -ne 0
then
-echo Error while building GenBin
+ echo Error while building GenBin
exit -1
fi
@@ -258,8 +257,8 @@ build -p SctPkg/UEFI/UEFI_SCT.dsc -a $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_B
status=$?
if test $status -ne 0
then
-echo Could not build the UEFI SCT package
- exit -1
+ echo Could not build the UEFI SCT package
+ exit -1
fi
build -p SctPkg/UEFI/IHV_SCT.dsc -a $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_BUILD $3 $4 $5 $6 $7 $8 $9
@@ -268,8 +267,8 @@ build -p SctPkg/UEFI/IHV_SCT.dsc -a $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_BU
status=$?
if test $status -ne 0
then
-echo Could not build the IHV SCT package
- exit -1
+ echo Could not build the IHV SCT package
+ exit -1
fi
@@ -299,8 +298,8 @@ pwd
status=$?
if test $status -ne 0
then
-echo Could not generate UEFI SCT binary
- exit -1
+ echo Could not generate UEFI SCT binary
+ exit -1
else
echo The SCT binary "SctPackage${SCT_TARGET_ARCH}" is located at "$EFI_SOURCE/Build/UefiSct/${SCT_BUILD}_${TARGET_TOOLS}"
fi
@@ -315,8 +314,8 @@ pwd
status=$?
if test $status -ne 0
then
-echo Could not generate IHV SCT binary
- exit -1
+ echo Could not generate IHV SCT binary
+ exit -1
else
echo The IHV binary "SctPackage${SCT_TARGET_ARCH}" is located at "$EFI_SOURCE/Build/IhvSct/${SCT_BUILD}_${TARGET_TOOLS}"
fi
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh
2020-09-24 21:21 ` [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Rebecca Cran
@ 2020-11-11 21:17 ` Samer El-Haj-Mahmoud
0 siblings, 0 replies; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-11-11 21:17 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@nuviainc.com
Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Thursday, September 24, 2020 5:22 PM
> To: devel@edk2.groups.io
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Rebecca Cran <rebecca@nuviainc.com>
> Subject: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some
> indentation issues in build.sh
>
> build.sh contains a mixture of tabs and spaces, with differing numbers of
> spaces used for indents. Update it so any single block only uses one style of
> indentation.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> uefi-sct/SctPkg/build.sh | 33 ++++++++++++++++-----------------
> 1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> be610deb..37667711 100755
> --- a/uefi-sct/SctPkg/build.sh
> +++ b/uefi-sct/SctPkg/build.sh
> @@ -56,9 +56,9 @@ function get_gcc_version {
> gcc_version=$($1 -dumpversion)
>
> - if [ ${gcc_version%%.*} -gt 5 ]; then
> - gcc_version=5
> - fi
> +if [ ${gcc_version%%.*} -gt 5 ]; then
> +gcc_version=5
> +fi
>
> case $gcc_version in
> 4.6*|4.7*|4.8*|4.9*|5*)
> @@ -152,10 +152,9 @@ case `uname` in
> ;;
>
> GCC* | gcc*)
> - set_cross_compile
> - CROSS_COMPILE="$TEMP_CROSS_COMPILE"
> - export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
> -
> +set_cross_compile
> +CROSS_COMPILE="$TEMP_CROSS_COMPILE"
> +export TARGET_TOOLS=`get_gcc_version
> "$CROSS_COMPILE"gcc`
> ;;
>
> *)
> @@ -224,7 +223,7 @@ then
> status=$?
> if test $status -ne 0
> then
> - echo Error while building EDK tools
> + echo Error while building EDK tools
> exit -1
> fi
> else
> @@ -239,7 +238,7 @@ make -C SctPkg/Tools/Source/GenBin status=$?
> if test $status -ne 0
> then
> -echo Error while building GenBin
> + echo Error while building GenBin
> exit -1
> fi
>
> @@ -258,8 +257,8 @@ build -p SctPkg/UEFI/UEFI_SCT.dsc -a
> $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_B status=$?
> if test $status -ne 0
> then
> -echo Could not build the UEFI SCT package
> - exit -1
> + echo Could not build the UEFI SCT package exit -1
> fi
>
> build -p SctPkg/UEFI/IHV_SCT.dsc -a $SCT_TARGET_ARCH -t
> $TARGET_TOOLS -b $SCT_BUILD $3 $4 $5 $6 $7 $8 $9
> @@ -268,8 +267,8 @@ build -p SctPkg/UEFI/IHV_SCT.dsc -a
> $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_BU
> status=$?
> if test $status -ne 0
> then
> -echo Could not build the IHV SCT package
> - exit -1
> + echo Could not build the IHV SCT package
> + exit -1
> fi
>
>
> @@ -299,8 +298,8 @@ pwd
> status=$?
> if test $status -ne 0
> then
> -echo Could not generate UEFI SCT binary
> - exit -1
> + echo Could not generate UEFI SCT binary
> + exit -1
> else
> echo The SCT binary "SctPackage${SCT_TARGET_ARCH}" is located at
> "$EFI_SOURCE/Build/UefiSct/${SCT_BUILD}_${TARGET_TOOLS}"
> fi
> @@ -315,8 +314,8 @@ pwd
> status=$?
> if test $status -ne 0
> then
> -echo Could not generate IHV SCT binary
> - exit -1
> + echo Could not generate IHV SCT binary
> + exit -1
> else
> echo The IHV binary "SctPackage${SCT_TARGET_ARCH}" is located at
> "$EFI_SOURCE/Build/IhvSct/${SCT_BUILD}_${TARGET_TOOLS}"
> fi
> --
> 2.26.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#65579): https://edk2.groups.io/g/devel/message/65579
> Mute This Topic: https://groups.io/mt/77067562/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud@arm.com]
> -=-=-=-=-=-=
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [edk2-test] [PATCH 0/3] Fixes to SctPkg/build.sh
@ 2020-09-24 21:37 Rebecca Cran
2020-09-24 21:37 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
0 siblings, 1 reply; 6+ messages in thread
From: Rebecca Cran @ 2020-09-24 21:37 UTC (permalink / raw)
To: devel; +Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Rebecca Cran
I noticed the GCC5 SctPkg build was broken. This patch series
fixes it and also resolves a couple of other issues I found.
Rebecca Cran (3):
uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain
uefi-sct: Fix the mailing list address in Maintainers.txt and
Readme.md
uefi-sct/SctPkg: Fix some indentation issues in build.sh
uefi-sct/Maintainers.txt | 2 +-
uefi-sct/Readme.md | 2 +-
uefi-sct/SctPkg/build.sh | 35 +++++++++++++++++------------------
3 files changed, 19 insertions(+), 20 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md
2020-09-24 21:37 [edk2-test] [PATCH 0/3] Fixes to SctPkg/build.sh Rebecca Cran
@ 2020-09-24 21:37 ` Rebecca Cran
2020-11-11 21:02 ` Samer El-Haj-Mahmoud
0 siblings, 1 reply; 6+ messages in thread
From: Rebecca Cran @ 2020-09-24 21:37 UTC (permalink / raw)
To: devel; +Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Rebecca Cran
The mailing list has changed from lists.01.org to groups.io.
Update Maintainers.txt and Readme.md to match.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
uefi-sct/Maintainers.txt | 2 +-
uefi-sct/Readme.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt
index c5f11c7deacf..cfad3b7881d8 100644
--- a/uefi-sct/Maintainers.txt
+++ b/uefi-sct/Maintainers.txt
@@ -46,4 +46,4 @@ R: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
General questions on UEFI-SCT with the subject [edk2-test] can be sent to
-L: edk2-list <edk2-devel@lists.01.org>
+L: edk2-devel <devel@edk2.groups.io>
diff --git a/uefi-sct/Readme.md b/uefi-sct/Readme.md
index 8445f4d54619..1a049b60aa7b 100644
--- a/uefi-sct/Readme.md
+++ b/uefi-sct/Readme.md
@@ -24,5 +24,5 @@ are listed in [Maintainers.txt](Maintainers.txt).
# Resources
* [TianoCore](http://www.tianocore.org)
* [Getting Started with UEFI-SCT](https://github.com/tianocore/tianocore.github.io/wiki/UEFI-SCT)
-* [Mailing List](mailto:edk2-devel@lists.01.org?subject=[edk2-test])
+* [Mailing List](mailto:devel@edk2.groups.io?subject=[edk2-test])
* [UEFI-SCT BugTracker](https://bugzilla.tianocore.org/)
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md
2020-09-24 21:37 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
@ 2020-11-11 21:02 ` Samer El-Haj-Mahmoud
0 siblings, 0 replies; 6+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-11-11 21:02 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io
Cc: Eric Jin, G Edhaya Chandran, Samer El-Haj-Mahmoud, Barton Gao
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Thursday, September 24, 2020 5:38 PM
> To: devel@edk2.groups.io
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Rebecca Cran <rebecca@nuviainc.com>
> Subject: [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in
> Maintainers.txt and Readme.md
>
> The mailing list has changed from lists.01.org to groups.io.
> Update Maintainers.txt and Readme.md to match.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> uefi-sct/Maintainers.txt | 2 +-
> uefi-sct/Readme.md | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/uefi-sct/Maintainers.txt b/uefi-sct/Maintainers.txt index
> c5f11c7deacf..cfad3b7881d8 100644
> --- a/uefi-sct/Maintainers.txt
> +++ b/uefi-sct/Maintainers.txt
> @@ -46,4 +46,4 @@ R: Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
>
>
> General questions on UEFI-SCT with the subject [edk2-test] can be sent to
> -L: edk2-list <edk2-devel@lists.01.org>
> +L: edk2-devel <devel@edk2.groups.io>
> diff --git a/uefi-sct/Readme.md b/uefi-sct/Readme.md index
> 8445f4d54619..1a049b60aa7b 100644
> --- a/uefi-sct/Readme.md
> +++ b/uefi-sct/Readme.md
> @@ -24,5 +24,5 @@ are listed in [Maintainers.txt](Maintainers.txt).
> # Resources
> * [TianoCore](http://www.tianocore.org)
> * [Getting Started with UEFI-
> SCT](https://github.com/tianocore/tianocore.github.io/wiki/UEFI-SCT)
> -* [Mailing List](mailto:edk2-devel@lists.01.org?subject=[edk2-test])
> +* [Mailing List](mailto:devel@edk2.groups.io?subject=[edk2-test])
> * [UEFI-SCT BugTracker](https://bugzilla.tianocore.org/)
> --
> 2.26.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-11 21:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-24 21:21 [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
2020-09-24 21:21 ` [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Rebecca Cran
2020-11-11 21:17 ` [edk2-devel] " Samer El-Haj-Mahmoud
-- strict thread matches above, loose matches on Subject: below --
2020-09-24 21:37 [edk2-test] [PATCH 0/3] Fixes to SctPkg/build.sh Rebecca Cran
2020-09-24 21:37 ` [edk2-test] [PATCH 2/3] uefi-sct: Fix the mailing list address in Maintainers.txt and Readme.md Rebecca Cran
2020-11-11 21:02 ` Samer El-Haj-Mahmoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox