From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.6161.1601034478274703420 for ; Fri, 25 Sep 2020 04:47:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=iAlIiBv0; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id z4so3289964wrr.4 for ; Fri, 25 Sep 2020 04:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pj5WjR4Pyo5gJqPUCeKxLUMCHXYCoDUNRewj9oQi8ck=; b=iAlIiBv0lcfAGJBFaUVHOe31T0SvhmGM+J88rvqkweq9R8x2WkOC++6pX23adZ4Ekj Ip776noXiw3KXm7utYMxK5YlXT8JVrwbzKp9U8LwiYLzdUbhmRrWx1J5m0iABHKCPXbY +5ECjC3mKY9n3mRiLHe7eBzeN0p08pBN147sVFGvr82b9W5I3HmKvee1AhiXfj0Vc3Vv 3yqThoNdbaJh8JcL2WGS9GV0CkKlTkdFY6LSmfF7wCOLO+EYewkM6nwUHE3i0GcrF82J wb18qW2k286Bb/JjrwSoDsowtUeXgHPZzZWJajiCC/1bYK51LA8mT/2+2KRhv8Z2ivZh /m8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pj5WjR4Pyo5gJqPUCeKxLUMCHXYCoDUNRewj9oQi8ck=; b=Zugs3MPvVYEYZcZgovLPpMeq0J7fpfIYZcklsHztkR/TqRZQSNHNg1RDOxgvQtNHiH EZj8mzxA/tPwTKrq8TlBEYe+cJNedlF0dD0eq8bZf/f7u3wjfoG40O3CgVMJ+QH9iqzA VbCvmkoo++fSrNCJCebNQhSPH8kb8YgpdfjiIi+mUR/L7wMsIpxWp/sdX/myEpUX3zYb a21pqlSWEdCWLWAx5SdvwLXk/nmAio2umtvj6mhlUMGDLNVUvkLqoa1Sy7tFOqrM/22m XSKCsEhub83wuz98zn/k7yknaGiPY6XN4BM68AJ51ObtdohtclvUXPYD6Ucb/DzeuRg3 AFNQ== X-Gm-Message-State: AOAM533uUVRLc+YJAZHFvwekV4VHXga75wrCWn8JOjmBfY6qeSlCVzK5 OL9TvLclrwVeSNLHr4YcRN/B6Q== X-Google-Smtp-Source: ABdhPJwQC3zG10J4E1c5hEpJOY2FdDljNn10AyfzF+AT1BKA/5cassR6oiMTE79X0lw8ZN0t9zGmtw== X-Received: by 2002:a5d:4709:: with SMTP id y9mr4093638wrq.59.1601034476711; Fri, 25 Sep 2020 04:47:56 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id d18sm2529698wrm.10.2020.09.25.04.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 04:47:56 -0700 (PDT) Date: Fri, 25 Sep 2020 12:47:49 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com, Meenakshi Aggarwal Subject: Re: [edk2-platforms 4/4] LS1046aFrwy: Enable USB support for LS1046AFRWY board. Message-ID: <20200925114749.GX5623@vanye> References: <1600187343-18732-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1600187343-18732-5-git-send-email-meenakshi.aggarwal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <1600187343-18732-5-git-send-email-meenakshi.aggarwal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 15, 2020 at 21:59:03 +0530, Meenakshi Aggarwal wrote: > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm > --- > Silicon/NXP/LS1046A/LS1046A.dsc.inc | 3 +++ > Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc | 2 ++ > Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 13 +++++++++++++ > 3 files changed, 18 insertions(+) > mode change 100644 => 100755 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > mode change 100644 => 100755 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > > diff --git a/Silicon/NXP/LS1046A/LS1046A.dsc.inc b/Silicon/NXP/LS1046A/LS1046A.dsc.inc > index 4e1d6a7ae7a2..7004533ed5f1 100644 > --- a/Silicon/NXP/LS1046A/LS1046A.dsc.inc > +++ b/Silicon/NXP/LS1046A/LS1046A.dsc.inc > @@ -31,6 +31,9 @@ [PcdsFixedAtBuild.common] > gNxpQoriqLsTokenSpaceGuid.PcdGpioModuleBaseAddress|0x02300000 > gNxpQoriqLsTokenSpaceGuid.PcdGpioControllerOffset|0x10000 > > + gNxpQoriqLsTokenSpaceGuid.PcdUsbBaseAddr|0x2F00000 > + gNxpQoriqLsTokenSpaceGuid.PcdUsbSize|0x100000 > + gNxpQoriqLsTokenSpaceGuid.PcdNumUsbController|3 > > [PcdsFeatureFlag] > gNxpQoriqLsTokenSpaceGuid.PcdDcfgBigEndian|TRUE > diff --git a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > old mode 100644 > new mode 100755 > index 3f29dadd5d1d..266fdbd2b4d3 > --- a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > +++ b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > @@ -43,4 +43,6 @@ [Components.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE > } > > + Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > + > ## > diff --git a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > old mode 100644 > new mode 100755 > index 24af547729c7..34c4e5a02516 > --- a/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > +++ b/Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > @@ -120,6 +120,19 @@ [FV.FvMain] > INF FatPkg/EnhancedFatDxe/Fat.inf > INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf > > + INF MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf > + > + # > + # USB Support > + # > + INF MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf > + INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > + INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > + INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + > + INF Silicon/NXP/Drivers/UsbHcdInitDxe/UsbHcd.inf > + > # > # UEFI application (Shell Embedded Boot Loader) > # > -- > 1.9.1 >