From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.30760.1601274579128312164 for ; Sun, 27 Sep 2020 23:29:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=O/EwF4rp; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=05406491d2=abner.chang@hpe.com) Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08S6Pfsi024051; Mon, 28 Sep 2020 06:29:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : mime-version; s=pps0720; bh=tHEtZMHzJkKr58HBoABmmsBA/Z8cpu0/TXO2UDhv6VU=; b=O/EwF4rpUvOjmjsCAlXi4/2b04l8TeGRGseuBlpgmdOQnhqeVHr33ZCfPr+dkYh5phKZ tpcZ9yUgb06fAhpLJKKWaNYiPnzo4Yv7+plLd6pkcmYv8zP5RmciRlEKvgMoOe+X9o9n zlsdBRnNqzHqrlf+iFk2yP2HA8y0Thz+hcx4dtJf5LVh34ZcRglH/C7n4Mk+og0Yt3Ur jFRHpuwDI+UQB8KT9LL+QzP9dY3tShqWQlS+KQJKJH+YfZZRRRzjYwQ1J0/lref5k2tK TrHjj47mY5cBdxPeOzbUGwM0Io+/DObFVpSkvMyaGKn8kGUlBGnhVhkp555ot5lH2vlv sA== Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 33suuct9sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Sep 2020 06:29:38 +0000 Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id E98239B; Mon, 28 Sep 2020 06:29:37 +0000 (UTC) Received: from SAC2XFT1JT.asiapacific.hpqcorp.net (sac2xft1jt.asiapacific.hpqcorp.net [10.43.42.132]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 6B87436; Mon, 28 Sep 2020 06:29:36 +0000 (UTC) From: "Abner Chang" To: devel@edk2.groups.io Cc: abner.chang@hpe.com, Maciej Rabeda , Wu Jiaxin , Fu Siyuan , Nickle Wang Subject: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Date: Mon, 28 Sep 2020 14:29:34 +0800 Message-Id: <20200928062934.505108-1-abner.chang@hpe.com> X-Mailer: git-send-email 2.21.0.windows.1 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-28_05:2020-09-24,2020-09-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=881 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009280053 Content-Transfer-Encoding: 8bit BZ #2909, https://bugzilla.tianocore.org/show_bug.cgi?id=2909 When Http->Configure() is invoked with HttpConfigData set to NULL to reset the EFI HTTP instance, TLS child instance is destroyed but HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring HTTP through Http->Configure() and sending the HTTP request to HTTPS URL, TLS child instance is not recreated because HttpInstance->TlsChildHandle is not NULL. Signed-off-by: Abner Chang Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Fu Siyuan Cc: Nickle Wang --- NetworkPkg/HttpDxe/HttpProto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 100644 --- a/NetworkPkg/HttpDxe/HttpProto.c +++ b/NetworkPkg/HttpDxe/HttpProto.c @@ -873,6 +873,7 @@ HttpCleanProtocol ( // Destroy the TLS instance. // HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle); + HttpInstance->TlsChildHandle = NULL; } if (HttpInstance->Tcp4ChildHandle != NULL) { -- 2.21.0.windows.1