[RedfishPkg PATCH 0/4] Inital RedfishPkg

[RedfishPkg PATCH 0/4] Inital RedfishPkg

[Abner Chang]

Initial version of RedfishPkg and the CI test
on RedfishPkg.

CI Test result:
https://github.com/tianocore/edk2/pull/975

There is no components in RedfishPkg in this commit,
the further edk2 Redfish components will be committed
base on this version.

changab (4):
  RedfishPkg: Initial commit of RedfishPkg.
  .pytool: Add CI on RedfishPkg
  .azurepipelines/templates: Add RedfishPkg to target build
  edk2: Add maintainers to RedfishPkg

 .../templates/pr-gate-build-job.yml           |  3 +
 .pytool/CISettings.py                         |  3 +-
 Maintainers.txt                               |  6 ++
 RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
 RedfishPkg/RedfishPkg.dec                     | 18 +++++
 RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
 6 files changed, 136 insertions(+), 1 deletion(-)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

-- 
2.17.1

[RedfishPkg PATCH 1/4] RedfishPkg: Initial commit of RedfishPkg.

[Abner Chang]

Initial version of RedfishPkg.

Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Signed-off-by: Wang Fan <fan.wang@intel.com>
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
 RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
 RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
 3 files changed, 125 insertions(+)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
new file mode 100644
index 0000000000..75c3b6a8ad
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -0,0 +1,67 @@
+## @file
+# CI configuration for NetworkPkg
+#
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+    "LicenseCheck": {
+        "IgnoreFiles": []
+    },
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        ## Both file path and directory path are accepted.
+        "IgnoreFiles": [
+        ]
+    },
+    "CompilerPlugin": {
+        "DscPath": "RedfishPkg.dsc"
+    },
+    "CharEncodingCheck": {
+        "IgnoreFiles": []
+    },
+    "DependencyCheck": {
+        "AcceptableDependencies": [
+            "MdePkg/MdePkg.dec",
+            "MdeModulePkg/MdeModulePkg.dec",
+            "NetworkPkg/NetworkPkg.dec"
+        ],
+        # For host based unit tests
+        "AcceptableDependencies-HOST_APPLICATION":[],
+        # For UEFI shell based apps
+        "AcceptableDependencies-UEFI_APPLICATION":[
+            "ShellPkg/ShellPkg.dec"
+        ],
+        "IgnoreInf": []
+    },
+    "DscCompleteCheck": {
+        "DscPath": "RedfishPkg.dsc",
+        "IgnoreInf": []
+    },
+    "GuidCheck": {
+        "IgnoreGuidName": [],
+        "IgnoreGuidValue": [],
+        "IgnoreFoldersAndFiles": []
+    },
+    "LibraryClassCheck": {
+        "IgnoreHeaderFile": []
+    },
+
+    ## options defined ci/Plugin/SpellCheck
+    "SpellCheck": {
+        "AuditOnly": True,           # Fails test but run in AuditOnly mode to collect log
+        "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
+        "ExtendWords": [],           # words to extend to the dictionary for this package
+        "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
+        "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+    },
+
+    "Defines": {
+        "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+    }
+}
diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
new file mode 100644
index 0000000000..e95ec5fe10
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+  DEC_SPECIFICATION = 0x0001001b
+  PACKAGE_NAME      = RedfishPkg
+  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
+  PACKAGE_VERSION   = 1.0
+
+[Guids]
+  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
+
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
new file mode 100644
index 0000000000..8acadddefc
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -0,0 +1,40 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
+#
+#    SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  PLATFORM_NAME                  = RedfishPkg
+  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
+  PLATFORM_VERSION               = 1.0
+  DSC_SPECIFICATION              = 0x0001001c
+  OUTPUT_DIRECTORY               = Build/RedfishPkg
+  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
+  SKUID_IDENTIFIER               = DEFAULT
+
+[LibraryClasses]
+  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+  PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
-- 
2.17.1

[RedfishPkg PATCH 2/4] .pytool: Add CI on RedfishPkg

[Abner Chang]

Add RedfishPkg to CI test.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
 .pytool/CISettings.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 0c2dd0181a..b337d046ae 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -55,7 +55,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
                 "FatPkg",
                 "CryptoPkg",
                 "UnitTestFrameworkPkg",
-                "OvmfPkg"
+                "OvmfPkg",
+                "RedfishPkg"
                 )
 
     def GetArchitecturesSupported(self):
-- 
2.17.1

[RedfishPkg PATCH 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..d7726356d8 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
-- 
2.17.1

Re: [edk2-devel] [RedfishPkg PATCH 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Sean]

Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

Thanks


On 9/29/2020 2:47 AM, Abner Chang wrote:
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..d7726356d8 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -45,6 +45,9 @@ jobs:
>         TARGET_SECURITY:
>           Build.Pkgs: 'SecurityPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_REDFISH:
> +        Build.Pkgs: 'RedfishPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_PLATFORMS:
>           # For Platforms only check code. Leave it to Platform CI
>           # to build them.
> 

Re: [edk2-devel] [RedfishPkg PATCH 3/4] .azurepipelines/templates: Add RedfishPkg to target build

[Abner Chang]

Thanks Sean.

CI test for RedfishPkg is merged @19c87b7d446c3273e84b238cb02cd1c0ae69c43e

> -----Original Message-----
> From: Sean Brogan [mailto:spbrogan@outlook.com]
> Sent: Thursday, October 15, 2020 9:58 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH 3/4] .azurepipelines/templates:
> Add RedfishPkg to target build
> 
> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
> 
> Thanks
> 
> 
> On 9/29/2020 2:47 AM, Abner Chang wrote:
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..d7726356d8 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >         TARGET_SECURITY:
> >           Build.Pkgs: 'SecurityPkg'
> >           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> >         TARGET_PLATFORMS:
> >           # For Platforms only check code. Leave it to Platform CI
> >           # to build them.
> >

[RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

[Abner Chang]

Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 6a22a14796..cc9d173285 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
+RedfishPkg: Redfish related modules
+F: RedfishPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
 SecurityPkg
 F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
-- 
2.17.1

Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

[Laszlo Ersek]

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Abner Chang <abner.chang@hpe.com>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> 

Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

Without R, I still can give reviewed-by to others contribute to RedfishPkg right?

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Abner Chang <abner.chang@hpe.com>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>



[-- Attachment #2: Type: text/html, Size: 3045 bytes --]

回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2504 bytes --]

Yes. Maintainer has the both role of reviewer and patch merge. 

 

Thanks

Liming

 

发件人: bounce+27952+65723+4905953+8761045@groups.io
<bounce+27952+65723+4905953+8761045@groups.io> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.
com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
<michael.d.kinney@intel.com>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to
RedfishPkg

 

Without R, I still can give reviewed-by to others contribute to RedfishPkg
right?

 

Get Outlook for Android <https://aka.ms/ghei36> 

 

  _____

From: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg





On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >
> Cc: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> Cc: Andrew Fish <afish@apple.com <mailto:afish@apple.com> >
> Cc: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
> Cc: Leif Lindholm <leif@nuviainc.com <mailto:leif@nuviainc.com> >
> Cc: Michael D Kinney <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> >
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >
> +R: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> 

 




[-- Attachment #2: Type: text/html, Size: 7469 bytes --]

Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 3239 bytes --]

Got it! v2 patches sent to mail list.

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Wednesday, September 30, 2020 8:59 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; 'Laszlo Ersek' <lersek@redhat.com>
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Yes. Maintainer has the both role of reviewer and patch merge.

Thanks
Liming

发件人: bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io> <bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io>> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>; Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Without R, I still can give reviewed-by to others contribute to RedfishPkg right?

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> Cc: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> Cc: Andrew Fish <afish@apple.com<mailto:afish@apple.com>>
> Cc: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
> Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>
> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> +R: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>



[-- Attachment #2: Type: text/html, Size: 9543 bytes --]