* [RedfishPkg PATCH v2 0/4] Inital RedfishPkg
@ 2020-09-30 1:56 Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Abner Chang @ 2020-09-30 1:56 UTC (permalink / raw)
To: devel
Initial version of RedfishPkg and the CI test
on RedfishPkg.
CI Test result:
https://github.com/tianocore/edk2/pull/975
There is no components in RedfishPkg in this commit,
the further edk2 Redfish components will be committed
base on this version.
changab (4):
RedfishPkg: Initial commit of RedfishPkg.
.pytool: Add CI on RedfishPkg
.azurepipelines/templates: Add RedfishPkg to target build
edk2: Add maintainers to RedfishPkg
.../templates/pr-gate-build-job.yml | 3 +
.pytool/CISettings.py | 3 +-
Maintainers.txt | 5 ++
RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++
RedfishPkg/RedfishPkg.dec | 18 +++++
RedfishPkg/RedfishPkg.dsc | 40 +++++++++++
6 files changed, 135 insertions(+), 1 deletion(-)
create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
create mode 100644 RedfishPkg/RedfishPkg.dec
create mode 100644 RedfishPkg/RedfishPkg.dsc
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-09-30 1:56 [RedfishPkg PATCH v2 0/4] Inital RedfishPkg Abner Chang
@ 2020-09-30 1:56 ` Abner Chang
2020-10-01 9:22 ` Laszlo Ersek
2020-09-30 1:56 ` [RedfishPkg PATCH v2 2/4] .pytool: Add CI on RedfishPkg Abner Chang
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Abner Chang @ 2020-09-30 1:56 UTC (permalink / raw)
To: devel
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Michael D Kinney
Initial version of RedfishPkg.
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Signed-off-by: Wang Fan <fan.wang@intel.com>
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
RedfishPkg/RedfishPkg.dec | 18 ++++++++++
RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
3 files changed, 125 insertions(+)
create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
create mode 100644 RedfishPkg/RedfishPkg.dec
create mode 100644 RedfishPkg/RedfishPkg.dsc
diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
new file mode 100644
index 0000000000..75c3b6a8ad
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -0,0 +1,67 @@
+## @file
+# CI configuration for NetworkPkg
+#
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
+ "CompilerPlugin": {
+ "DscPath": "RedfishPkg.dsc"
+ },
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "MdePkg/MdePkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "NetworkPkg/NetworkPkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[
+ "ShellPkg/ShellPkg.dec"
+ ],
+ "IgnoreInf": []
+ },
+ "DscCompleteCheck": {
+ "DscPath": "RedfishPkg.dsc",
+ "IgnoreInf": []
+ },
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": []
+ },
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined ci/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": True, # Fails test but run in AuditOnly mode to collect log
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
+ "ExtendWords": [], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
+ "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+ },
+
+ "Defines": {
+ "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+ }
+}
diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
new file mode 100644
index 0000000000..e95ec5fe10
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+ DEC_SPECIFICATION = 0x0001001b
+ PACKAGE_NAME = RedfishPkg
+ PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
+ PACKAGE_VERSION = 1.0
+
+[Guids]
+ gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
+
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
new file mode 100644
index 0000000000..8acadddefc
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -0,0 +1,40 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ PLATFORM_NAME = RedfishPkg
+ PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
+ PLATFORM_VERSION = 1.0
+ DSC_SPECIFICATION = 0x0001001c
+ OUTPUT_DIRECTORY = Build/RedfishPkg
+ SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
+ SKUID_IDENTIFIER = DEFAULT
+
+[LibraryClasses]
+ UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+ UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+ UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+ MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+ BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+ BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+ SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+ PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+ DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+ DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+ PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+ PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+ PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+ DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+ DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RedfishPkg PATCH v2 2/4] .pytool: Add CI on RedfishPkg
2020-09-30 1:56 [RedfishPkg PATCH v2 0/4] Inital RedfishPkg Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
@ 2020-09-30 1:56 ` Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
3 siblings, 0 replies; 7+ messages in thread
From: Abner Chang @ 2020-09-30 1:56 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Nickle Wang
Add RedfishPkg to CI test.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
.pytool/CISettings.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 0c2dd0181a..b337d046ae 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -55,7 +55,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"FatPkg",
"CryptoPkg",
"UnitTestFrameworkPkg",
- "OvmfPkg"
+ "OvmfPkg",
+ "RedfishPkg"
)
def GetArchitecturesSupported(self):
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RedfishPkg PATCH v2 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-09-30 1:56 [RedfishPkg PATCH v2 0/4] Inital RedfishPkg Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 2/4] .pytool: Add CI on RedfishPkg Abner Chang
@ 2020-09-30 1:56 ` Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
3 siblings, 0 replies; 7+ messages in thread
From: Abner Chang @ 2020-09-30 1:56 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Nickle Wang
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..d7726356d8 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
TARGET_SECURITY:
Build.Pkgs: 'SecurityPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+ TARGET_REDFISH:
+ Build.Pkgs: 'RedfishPkg'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_PLATFORMS:
# For Platforms only check code. Leave it to Platform CI
# to build them.
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RedfishPkg PATCH v2 4/4] edk2: Add maintainers to RedfishPkg
2020-09-30 1:56 [RedfishPkg PATCH v2 0/4] Inital RedfishPkg Abner Chang
` (2 preceding siblings ...)
2020-09-30 1:56 ` [RedfishPkg PATCH v2 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
@ 2020-09-30 1:56 ` Abner Chang
3 siblings, 0 replies; 7+ messages in thread
From: Abner Chang @ 2020-09-30 1:56 UTC (permalink / raw)
To: devel
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Michael D Kinney
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
Maintainers.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 6a22a14796..cabadac177 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -503,6 +503,11 @@ F: PcAtChipsetPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
M: Ray Ni <ray.ni@intel.com>
+RedfishPkg: Redfish related modules
+F: RedfishPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
SecurityPkg
F: SecurityPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-09-30 1:56 ` [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
@ 2020-10-01 9:22 ` Laszlo Ersek
2020-10-02 14:35 ` [edk2-devel] " Abner Chang
0 siblings, 1 reply; 7+ messages in thread
From: Laszlo Ersek @ 2020-10-01 9:22 UTC (permalink / raw)
To: changab, devel; +Cc: Nickle Wang, Andrew Fish, Leif Lindholm, Michael D Kinney
On 09/30/20 03:56, changab wrote:
> Initial version of RedfishPkg.
>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
> RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> 3 files changed, 125 insertions(+)
> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
> create mode 100644 RedfishPkg/RedfishPkg.dec
> create mode 100644 RedfishPkg/RedfishPkg.dsc
based on the diffstat:
Acked-by: Laszlo Ersek <lersek@redhat.com>
However, I suggest resending this series (more precisely, sending a v3).
Here's why:
The patch seems to have been posted "From: changab
<abner.chang@hpe.com>". This will be recorded in the git history, by
git-am. (The mergify bot overwrites the Committer meta-field, but the
Author meta-field remains in place, from git-am -- and that works from
"From:".)
I think "Abner Chang <abner.chang@hpe.com>" looks a whole lot better
than "changab <abner.chang@hpe.com>", in the Author field. So please
rebase this series locally, picking the "edit" action for each patch,
and then re-commit each patch with:
git commit --amend --author="Abner Chang <abner.chang@hpe.com>"
git rebase --continue
Additionally, please update the "user.name" knob in your git config.
Sorry for obsessing about this -- I'd really like the git history to
look *nice*.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-10-01 9:22 ` Laszlo Ersek
@ 2020-10-02 14:35 ` Abner Chang
0 siblings, 0 replies; 7+ messages in thread
From: Abner Chang @ 2020-10-02 14:35 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Wang, Nickle (HPS SW), Andrew Fish, Leif Lindholm,
Michael D Kinney
V3 sent.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, October 1, 2020 5:22 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
>
> On 09/30/20 03:56, changab wrote:
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> > RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> > 3 files changed, 125 insertions(+)
> > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644
> > RedfishPkg/RedfishPkg.dec create mode 100644
> > RedfishPkg/RedfishPkg.dsc
>
> based on the diffstat:
>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
> However, I suggest resending this series (more precisely, sending a v3).
> Here's why:
>
> The patch seems to have been posted "From: changab
> <abner.chang@hpe.com>". This will be recorded in the git history, by git-am.
> (The mergify bot overwrites the Committer meta-field, but the Author meta-
> field remains in place, from git-am -- and that works from
> "From:".)
>
> I think "Abner Chang <abner.chang@hpe.com>" looks a whole lot better
> than "changab <abner.chang@hpe.com>", in the Author field. So please
> rebase this series locally, picking the "edit" action for each patch, and then
> re-commit each patch with:
>
> git commit --amend --author="Abner Chang <abner.chang@hpe.com>"
> git rebase --continue
>
> Additionally, please update the "user.name" knob in your git config.
>
> Sorry for obsessing about this -- I'd really like the git history to look *nice*.
>
> Thanks
> Laszlo
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-02 14:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-30 1:56 [RedfishPkg PATCH v2 0/4] Inital RedfishPkg Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-01 9:22 ` Laszlo Ersek
2020-10-02 14:35 ` [edk2-devel] " Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-09-30 1:56 ` [RedfishPkg PATCH v2 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox