Re: [edk2-devel] Cannot build due to recent change

["Leif Lindholm" <leif@nuviainc.com>]

Hi Andrew,

Welcome to the list.

First of all, it helps to cc maintainers of the bits you're having
issues with.

The GetMaintainer.py script can look these up for you automatically
for a given path:
python ../edk2/BaseTools/Scripts/GetMaintainer.py -l Platform/ARM/JunoPkg/ArmJuno.dsc
Platform/ARM/JunoPkg/ArmJuno.dsc
  Leif Lindholm <leif@nuviainc.com>
  Ard Biesheuvel <ard.biesheuvel@arm.com>
  Thomas Abraham <thomas.abraham@arm.com>

Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib
to generate entropy in rand_pool"), merged through
https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most
platforms outside the main edk2 tree.

This should have been handled better.

But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL
from some onboard hw, you can use the approach from edk2-platforms
commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error").
Otherwise, you can use the approach used in edk2 commit 416813753726
("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg").

If you're just trying to build something, you can rewind your edk2
HEAD to the edk2-stable202008 tag.

Best Regards,

Leif

On Wed, Sep 30, 2020 at 13:16:22 +0100, Andrew Goodbody wrote:
> Looks like a recent change is not working for AARCH64
> 
> https://github.com/tianocore/edk2/commit/b5701a4c7a0fb185e0c5b9db9525939c78664bfd
> 
> edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc(...): error 4000: Instance
> of library class [RngLib] is not found
> 	in [/home/andrew/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf]
> [AARCH64]
> 	consumed by module [/home/andrew/src/edk2/NetworkPkg/IScsiDxe/IScsiDxe.inf]
> 
> 
> - Failed -
> Build end time: 12:56:54, Sep.30 2020
> Build total time: 00:00:01
> 
> Sorry but I have not found my way around here yet. Is there anyone that can
> see what the best fix is for this please?
> 
> Thanks,
> Andrew
> 
> 
> 
> 
>