From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.groups.io with SMTP id smtpd.web10.9582.1601549021266758318 for ; Thu, 01 Oct 2020 03:43:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=p3EnjYis; spf=pass (domain: nuviainc.com, ip: 209.85.128.44, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f44.google.com with SMTP id t17so2484827wmi.4 for ; Thu, 01 Oct 2020 03:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QNMCOD5wpWB4beWXQeqqjiL7M2zXrtdJ304N5RpU+X4=; b=p3EnjYisSO5bgLCu3jhoj0pSCpX/wfEh6UB7rKz0ltQpwaUUrDVLojZL8L0eCb8dAm SaZsOycy6TpsoEi16TrrHXW0H4OFjHhOgKs4JPq3ZQQiN3MOZlF+xzo7e8gpXfHKWA5u Jb0CCZ/HxdOn/selhpwBDYz/L9L8rQx98DZa15LYW6kaIfL0ekDXYBD5kxG5eyRNCkte 721WfsxlFTeJ5IbyEeuvgFIReFavP8cvUaXoTu+W4C/+Iye+eO7Hyg3TeBx+fs/xSyMg PmL358Vyz5v2+uobHtQ3tQv6SOA4Vhu9Ieuw0bTrGY4w6JnfNh2yyBE5M36HsepKhF/j 40ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QNMCOD5wpWB4beWXQeqqjiL7M2zXrtdJ304N5RpU+X4=; b=QwLO2AZ2PYRsUzFpgYIu4phXNIYHXpaltFA597yZVc/lzpmrq5uW9KfQfEnkFkS97O ldZ7hmENPtvIo6Vk6ezmpHrs186MNh0ZhnydsTySRLh6i61CYUUfeEEKGn0Blo/Jcyve CUfvsLlHpM05Otc0vHBScd97RCPJBddIIK3wdjUqecbtIlFUss5uaO+a9yPyPFjHD0HY Fi07DdJVAYCXW2HvtrUzowTVdkJBwJKQeEY2bubhkgAE+hvImyoQ/JDsf7PEMmlsuJ2J fKfnumE0E56ylVMDnu6Ugg8grRqsYNCp6hpw8CDiH/ofrp1PGfZnd9BkeYjAaxIacj/J kBXQ== X-Gm-Message-State: AOAM530p+at/1ntpzdp2JWcZCG7Xmk9wP6VJGslt35E/xMc+LhU/hBct JrSn0eEuZ/mamn0u1kinY9D6a9l6fjqQMp2EdXyyRKWGgeo1u4urz9/TprTXqalm7vLyBWC4zmg bpCnP20dU0MPA1oZCPW4ibQER54mNlYxWb9GEHBXWLvE+/iSjKfBFgYJD6jPIBigtWgeC X-Google-Smtp-Source: ABdhPJyfA6alv0Fu8hipeJybxI5l0bTTps2PXzmpQJKIfY3oDIisulDKFyuqOFbFu4W2somF+G8a5w== X-Received: by 2002:a1c:2d85:: with SMTP id t127mr7709147wmt.22.1601549019479; Thu, 01 Oct 2020 03:43:39 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id 10sm8079313wmi.37.2020.10.01.03.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 03:43:39 -0700 (PDT) Date: Thu, 1 Oct 2020 11:43:32 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, andrew.goodbody@linaro.org Cc: Ard Biesheuvel , Thomas Abraham , Liming Gao Subject: Re: [edk2-devel] Cannot build due to recent change Message-ID: <20201001104332.GG5623@vanye> References: <9ed015a5-f111-d661-acad-4f97dc5f5eb1@linaro.org> MIME-Version: 1.0 In-Reply-To: <9ed015a5-f111-d661-acad-4f97dc5f5eb1@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andrew, Welcome to the list. First of all, it helps to cc maintainers of the bits you're having issues with. The GetMaintainer.py script can look these up for you automatically for a given path: python ../edk2/BaseTools/Scripts/GetMaintainer.py -l Platform/ARM/JunoPkg/ArmJuno.dsc Platform/ARM/JunoPkg/ArmJuno.dsc Leif Lindholm Ard Biesheuvel Thomas Abraham Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool"), merged through https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most platforms outside the main edk2 tree. This should have been handled better. But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL from some onboard hw, you can use the approach from edk2-platforms commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error"). Otherwise, you can use the approach used in edk2 commit 416813753726 ("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg"). If you're just trying to build something, you can rewind your edk2 HEAD to the edk2-stable202008 tag. Best Regards, Leif On Wed, Sep 30, 2020 at 13:16:22 +0100, Andrew Goodbody wrote: > Looks like a recent change is not working for AARCH64 > > https://github.com/tianocore/edk2/commit/b5701a4c7a0fb185e0c5b9db9525939c78664bfd > > edk2-platforms/Platform/ARM/JunoPkg/ArmJuno.dsc(...): error 4000: Instance > of library class [RngLib] is not found > in [/home/andrew/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf] > [AARCH64] > consumed by module [/home/andrew/src/edk2/NetworkPkg/IScsiDxe/IScsiDxe.inf] > > > - Failed - > Build end time: 12:56:54, Sep.30 2020 > Build total time: 00:00:01 > > Sorry but I have not found my way around here yet. Is there anyone that can > see what the best fix is for this please? > > Thanks, > Andrew > > > > >