From: "Leif Lindholm" <leif@nuviainc.com>
To: Andrew Goodbody <andrew.goodbody@linaro.org>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@arm.com>,
Thomas Abraham <thomas.abraham@arm.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] Cannot build due to recent change
Date: Thu, 1 Oct 2020 12:12:35 +0100 [thread overview]
Message-ID: <20201001111235.GH5623@vanye> (raw)
In-Reply-To: <8eb5e70a-a46e-6ebf-f4af-b27b0a345f49@linaro.org>
On Thu, Oct 01, 2020 at 12:06:07 +0100, Andrew Goodbody wrote:
> > Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib
> > to generate entropy in rand_pool"), merged through
> > https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most
> > platforms outside the main edk2 tree.
> >
> > This should have been handled better.
> >
> > But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL
> > from some onboard hw, you can use the approach from edk2-platforms
> > commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error").
> > Otherwise, you can use the approach used in edk2 commit 416813753726
> > ("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg").
>
> Just to be sure I understand this - most platforms outside of the main edk2
> tree are going to need updating to take account of this change.
Well, most non-x86 platforms. There is an RdRand implementation in
tree, which I expect most platforms that could use already did.
/
Leif
next prev parent reply other threads:[~2020-10-01 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 12:16 Cannot build due to recent change andrew.goodbody
2020-10-01 10:43 ` [edk2-devel] " Leif Lindholm
2020-10-01 11:06 ` Andrew Goodbody
2020-10-01 11:12 ` Leif Lindholm [this message]
2020-10-01 11:07 ` Sami Mujawar
2020-10-02 9:18 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001111235.GH5623@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox