From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web11.10126.1601550764897144191 for ; Thu, 01 Oct 2020 04:12:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=nUtLfzWZ; spf=pass (domain: nuviainc.com, ip: 209.85.221.51, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f51.google.com with SMTP id o5so5184269wrn.13 for ; Thu, 01 Oct 2020 04:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UPGZPcNi3vAZFg2WDZZ2h7HQlELC3XKMw/bL4aO+R5I=; b=nUtLfzWZhyOXltvLNvk3zYI/WIKYppcwG0PvPPllyaz0yDBriu7Y5H7pqH/ILWPOeX MgIRAQFdAuVf9ruvZ1mwMu8uxv5sqz7KzOLWPdU3xRNsYHF4LGIG7JCt9GionBqCNcK7 daQUChvylWxTeyXhdb+58wAaTyJxIVAjifBgBhoEI9nJj49NdZ4DnwBwPvq0d0r4QYAk M9Khub1UbxeeHFs3X1S4xc08C/7KX4tQypYIgDEyDPWh+XCkUeXxw0tvdgSJaRxqqNX/ ibJb/bMswpMTWrDUtf6XBb2IRrFa7oTDPmu6SBLEAVU+wVZtOpINeyZcWYpB2uGnsDGN XCmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UPGZPcNi3vAZFg2WDZZ2h7HQlELC3XKMw/bL4aO+R5I=; b=tUvaMEN7Vd3lA1FRQW3nZwwD2LK5AmoSP9uAUrO4KAd+d6sHjLHxpTrQ7BR0HSoFPY qK84nRMFRDb552dMs+VrzWe/mWhvBE+gV/UuYkfLdSL8uePW1cOchiNXGN4ikSc23YKJ pKrpBlUhRadhsBJwETRTD6T4He3tyVH16xMGSa2x+8mW/tsSJ+y69rP8a44UstX8YYEP Kk/w+cyWkJh1iOpWqb/yOEKWagj3OdR+nvOthiGUvLjIX4JHS5fHpJTESmpKHeCnWtW1 odYQ+GYfq9fryZLifESiqojY+z/6pJg/+41Np+XFJyZeDswBf+7ex20LJq/JABPlQgUy 4Cag== X-Gm-Message-State: AOAM531/qkBUCHx9/f41gvMrbRf5KbtYIitOQf9alzxhaUzbiRaPw8Em C0HDsLdARCw63Hi2Pv5WLrG5gA== X-Google-Smtp-Source: ABdhPJyduVB8BDN5/QdzLm2Lq9hGgSf04HeRCqBfS7ws4J106kimthKqYwAtOnlo4JoCCHneMBT8ng== X-Received: by 2002:adf:81c6:: with SMTP id 64mr8084311wra.176.1601550763418; Thu, 01 Oct 2020 04:12:43 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id b11sm8512380wrt.38.2020.10.01.04.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 04:12:41 -0700 (PDT) Date: Thu, 1 Oct 2020 12:12:35 +0100 From: "Leif Lindholm" To: Andrew Goodbody Cc: devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , Liming Gao Subject: Re: [edk2-devel] Cannot build due to recent change Message-ID: <20201001111235.GH5623@vanye> References: <9ed015a5-f111-d661-acad-4f97dc5f5eb1@linaro.org> <20201001104332.GG5623@vanye> <8eb5e70a-a46e-6ebf-f4af-b27b0a345f49@linaro.org> MIME-Version: 1.0 In-Reply-To: <8eb5e70a-a46e-6ebf-f4af-b27b0a345f49@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 01, 2020 at 12:06:07 +0100, Andrew Goodbody wrote: > > Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib > > to generate entropy in rand_pool"), merged through > > https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most > > platforms outside the main edk2 tree. > > > > This should have been handled better. > > > > But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL > > from some onboard hw, you can use the approach from edk2-platforms > > commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error"). > > Otherwise, you can use the approach used in edk2 commit 416813753726 > > ("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg"). > > Just to be sure I understand this - most platforms outside of the main edk2 > tree are going to need updating to take account of this change. Well, most non-x86 platforms. There is an RdRand implementation in tree, which I expect most platforms that could use already did. / Leif