public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rfc@edk2.groups.io" <rfc@edk2.groups.io>,
	Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	"Kirkendall, Garrett" <garrett.kirkendall@amd.com>,
	"Lendacky, Thomas" <thomas.lendacky@amd.com>,
	"thomas.abraham@arm.com" <thomas.abraham@arm.com>,
	"Frank.Orr@dell.com" <Frank.Orr@dell.com>,
	Jim Dailey <jim.dailey@dell.com>,
	Abner Chang <abner.chang@hpe.com>,
	"Wang, Sunny (HPS SW)" <sunnywang@hpe.com>,
	Daniel Schaefer <daniel.schaefer@hpe.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Tim Lewis <tim.lewis@insyde.com>,
	"Kevin@Insyde" <kevin.davis@insyde.com>,
	Felix Polyudov <felixp@ami.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [RFC] Request to move MinPlatformPkg out of the Intel folder
Date: Thu, 1 Oct 2020 12:52:35 +0100	[thread overview]
Message-ID: <20201001115235.GI5623@vanye> (raw)
In-Reply-To: <MWHPR1101MB21606390CFD0ECCE741932CACD330@MWHPR1101MB2160.namprd11.prod.outlook.com>

Hi Nate,

On Wed, Sep 30, 2020 at 23:17:15 +0000, Desimone, Nathaniel L wrote:
> This has come up informally a couple of times already, but I do
> think that it would be beneficial to move MinPlatformPkg out of the
> Platform/Intel folder and into a vendor neutral folder. MinPlatform
> really isn't Intel specific, it's just "middleware" that is intended
> to make it easier and faster to build EDK II based firmware. We have
> always intended MinPlatform to be vendor neutral, and it would be
> great to see MinPlatform based implementations for non-Intel
> silicon. Anyone working with EDK II should feel welcome to work with
> us on MinPlatform, regardless of the SoC in use.

Very positive to this on the whole.

I have only been following MinPlatformPkg peripherally - at the time
it was merged, I did not have the bandwidth to look into it and help
make it cross-architecture from the start, so I mostly refrained from
comment.

One thing I think is needed for this to move out of Platform/Intel
would be a ReadMe.rst describing the intended real-world use.
Some of this lives in Platform/Intel/Readme.md today.
Could we start with a set moving this text into a separate file under
MinPlatformPkg and rework that into something that stands on its own?

> To that end, I propose that we move MinPlatformPkg out of
> edk2-platforms/Platform/Intel to
> edk2-platforms/Platform/MinPlatformPkg.

If I was to bikeshed, I'd probably suggest
Platform/TianoCore/MinPlatformPkg. Oops, guess I did.

> It might also make sense to
> move edk2-platforms/Platform/Intel/Tools and
> edk2-platforms/Platform/Intel/build_bios.py to
> edk2-platforms/Platform as well since those are all useful for
> building MinPlatform based firmware, but I could also see that being
> something for another time. Let me know what you think!

I think we should see this as a separate step, regardless.

I do think we should be able to do better on sharing some of this
platform image tooling cross-architecture (even moreso now Risc-V is
involved), but I would prefer for us to spend the effort of
identifying the intersections upfront before we start uploading tools
to places where they look generic and may confuse people.

Maybe we should raise this part as a BZ?

Best Regards,

Leif

  parent reply	other threads:[~2020-10-01 11:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 23:17 [RFC] Request to move MinPlatformPkg out of the Intel folder Nate DeSimone
2020-10-01  4:04 ` Abner Chang
2020-10-01  6:54 ` Laszlo Ersek
2020-10-01 23:27   ` [edk2-devel] " Nate DeSimone
2020-10-01  7:43 ` Wim Vervoorn
2020-10-01  8:00   ` [edk2-devel] " christian.walter
2020-10-01 11:24 ` Kirkendall, Garrett
2020-10-01 11:52 ` Leif Lindholm [this message]
2020-10-01 23:20   ` [edk2-rfc] " Nate DeSimone
2020-10-01 23:26     ` Leif Lindholm
2020-10-02  4:19       ` [edk2-devel] " Hot Tian
2020-10-04 20:46         ` Nate DeSimone
2020-10-04 22:00           ` Leif Lindholm
2020-10-05 20:11             ` Nate DeSimone
2020-10-03  3:36 ` [edk2-devel] " Sean
2020-10-04 21:02   ` Nate DeSimone
2020-10-05 19:35     ` Bret Barkelew
2020-10-05 20:18       ` [edk2-rfc] " Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001115235.GI5623@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox