From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Jan Bobek <jbobek@nvidia.com>
Subject: [PATCH 0/5] MdePkg: various fixes to ARM/AArch64 SetJump/LongJump
Date: Thu, 1 Oct 2020 19:37:07 +0100 [thread overview]
Message-ID: <20201001183712.1738-1-leif@nuviainc.com> (raw)
Jan's submission earlier today unfortunately made me go have a look at
the ARM/AARCH64 implementations, and there were plenty of other things to
improve:
- Fix comments (drop Itanium mention, correct spelling)
- Make code match existing comments
- Don't try to optimise ARM for executing on the 8088
- Use the correct register sizes on AArch64
- Actually follow the API on ARM
The changes to .asm files have been neither build nor runtime tested.
Cc: Jan Bobek <jbobek@nvidia.com>
Leif Lindholm (5):
MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations
MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations
MdePkg/BaseLib: use normal register init in ARM SetJump
implementations
MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump
MdePkg/BaseLib: ensure ARM LongJump never returns 0
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 14 ++++++++------
MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 14 ++++++++------
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 10 +++++++---
MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 10 +++++++---
4 files changed, 30 insertions(+), 18 deletions(-)
--
2.20.1
next reply other threads:[~2020-10-01 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 18:37 Leif Lindholm [this message]
2020-10-01 18:37 ` [PATCH 1/5] MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations Leif Lindholm
2020-10-01 18:37 ` [PATCH 2/5] MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations Leif Lindholm
2020-10-01 20:49 ` Ard Biesheuvel
2020-10-01 20:55 ` Leif Lindholm
2020-10-01 20:58 ` Ard Biesheuvel
2020-10-01 18:37 ` [PATCH 3/5] MdePkg/BaseLib: use normal register init in ARM " Leif Lindholm
2020-10-05 8:17 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-10-13 12:16 ` Ard Biesheuvel
2020-10-01 18:37 ` [PATCH 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump Leif Lindholm
2020-10-05 8:19 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-10-01 18:37 ` [PATCH 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0 Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001183712.1738-1-leif@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox