From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web11.1019.1601577440901226991 for ; Thu, 01 Oct 2020 11:37:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Gg1260cV; spf=pass (domain: nuviainc.com, ip: 209.85.221.46, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f46.google.com with SMTP id g4so6979210wrs.5 for ; Thu, 01 Oct 2020 11:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQl2XLz0AFxbqtZ48UwaHljyiYp+I0YCROquGNCqJlM=; b=Gg1260cVoNOJsOBo2zHcDGWNhieypPSjmEhRAWrXu5jSXZ+5iLF1IaXF/tqL/mFpDS HgaMuQxubmVgZJ3mhlU9gPLqrNkAXGf068lHT8UbAWLx16koKGWEapl+A5oBWmAGZ4Qz tHYdFRTF6w30jroUPiRHK73diFxmlt0ge0B9VQR9dFE63l/EbkL3Lf9/s1SydFimo5A0 E+oPbZkR37rFjjIoHkopDRFd741b1O1vOujTqyUXxabcQ6je5NeNp7qRltL0XKusn4Td r6jLDgKbwoIg/ThIrY+OqsVM3t2EdSwvIqOQcfvYx+5Hj3J8MkH3dRFpBSDqDkWUpYqL EWHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CQl2XLz0AFxbqtZ48UwaHljyiYp+I0YCROquGNCqJlM=; b=i1lTlN5zyHhR/PehnBaQ1/LV5HY0fP2NdWdzYtvgDaCMQRC6skgC2e1UaCDMJQHNqi tJuHUuvITP9gPNOKGRYaWzWp1sDTefc6w4SkHHftbNLFqOPsZwZRe6blTtbFUHeVZGtA 7+6c/Xtys9Gjk2JzNnVkX8j1B4oMmTlIVXDv1195Pkrgcdolu30UAN8uUgxu0hTWhaqx R+AAQcxPEWRAP6RmZ1yVA/sgUzpKOdtm6Qt8tZGqgY3Z+J3Y/cDAwk+yyUrJG0oeSZym stD7frozLfKmQ3knGcekfKHCHZ0QqRN0dit53RSSB4YVgQlgi6YwYYAOHyYGQR8iKD00 YZmA== X-Gm-Message-State: AOAM532ipREcdfOYR6/txQLMs8CBaZZi25ymDORe/YhukdFZSCHH0OW7 zJ93Ax6pktyWcQ73+WeuMe0rkWWRD6FPqmcyXwLka42ePmL0NHp+iuwALPtU9os5D19h9lnjLrc JUyW8/GqgiEk2S4/I9aqRPuppf1/XrVfAvpXXJ6TZ8Ut2ji34aK2aV0fFfLTwWAmCbqu/ X-Google-Smtp-Source: ABdhPJwB8bwk+Ew+an0J3cbH/nt+MCQnVXQSCWA26n81AwCkOtsimo8ChMoApA7+08pIUD5SkoB5qw== X-Received: by 2002:adf:e54f:: with SMTP id z15mr10133580wrm.136.1601577438961; Thu, 01 Oct 2020 11:37:18 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id a3sm964671wmb.46.2020.10.01.11.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 11:37:18 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu , Jan Bobek Subject: [PATCH 0/5] MdePkg: various fixes to ARM/AArch64 SetJump/LongJump Date: Thu, 1 Oct 2020 19:37:07 +0100 Message-Id: <20201001183712.1738-1-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Jan's submission earlier today unfortunately made me go have a look at the ARM/AARCH64 implementations, and there were plenty of other things to improve: - Fix comments (drop Itanium mention, correct spelling) - Make code match existing comments - Don't try to optimise ARM for executing on the 8088 - Use the correct register sizes on AArch64 - Actually follow the API on ARM The changes to .asm files have been neither build nor runtime tested. Cc: Jan Bobek Leif Lindholm (5): MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations MdePkg/BaseLib: use normal register init in ARM SetJump implementations MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump MdePkg/BaseLib: ensure ARM LongJump never returns 0 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 14 ++++++++------ MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 14 ++++++++------ MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 10 +++++++--- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 10 +++++++--- 4 files changed, 30 insertions(+), 18 deletions(-) -- 2.20.1