From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.1022.1601577444719175368 for ; Thu, 01 Oct 2020 11:37:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=tgmYviMK; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id s13so3923967wmh.4 for ; Thu, 01 Oct 2020 11:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kUYuLFBC5fKgD9PrIOsv/tDIzTAeAUCcR3+CPBCrzYs=; b=tgmYviMKM55vRYwJyIIOgB10ZPy0b8IJA3ZVN7gs2dw/lJ/9uXOAB0uV0ImmWXJXk0 v19SPxEbO772Kr+Qjb3t+YjiHJqZKvdRA4hwg3g17hlcchxwdVQklHbDft6UlRjtyZmL aQB7Hk9TaUKIZkxwq9wphFKY6QHmdR7ireIDZEHYYa1N4pphRHPKQpNkQER916blsT77 kVUwQTKkW9fejZWL89kMdMFUsRm+7uzAl1aHup8MBq64mTcwRgv40Bf1k0Sy/zs48Qfv veWHcbWz6nhdqt1sDUxtxdp8XxW9zTmu50owIJLV9SFzpWj5ZL/9sVVTQDTPWC1mpMG1 x4KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kUYuLFBC5fKgD9PrIOsv/tDIzTAeAUCcR3+CPBCrzYs=; b=axxX10TqdpL5xy9lGIkUgr0OabIVl2euHF+iEcdPPgyv/XPlKw8gIAPSFiuH9NLPJO g9i/5QadC/7tYIxdJ+JIh773EZSttfGudlnrerV5S8ol5rW9vBCHrKWRvkfduaJgXYJ/ hc6Mluf84TbzVFQVDrg6P/iXC575x8P/QxRcmMW1Xx3/Eg50NwIqFQMTINda8hkGjZMf RVG3w1eW2eayuYra0Isx2thFEayBqDGj1daKweoJFJ09zzQOJROilFhGcoxIzxiH2AKB pFf/3F87EdeG57DFQ0B99LCXmwNd0hGQrb3ALxZttV/aBBqBCHFNOpWfxPJsGU4EMCAl KSTg== X-Gm-Message-State: AOAM532pdUttKWbJLtEX7+nkRyiWWEFOcBOEyRZUwF4xjy2Ocz1s0brw +vhES1k6U/jwkYcsSYwdoWRjK0TOBrOIAhHLJlS1fut3rpfHOUNdfu6ioAbUctpL5U9jhpyKyNF 2onb5F6F9/5Rl/o2ahBgsqSDPbl1qXNHM9QX5d8I40gYMAZHftoFRkYBXKlX8wuYX0l+X X-Google-Smtp-Source: ABdhPJy7rTMqtvHH1flegm7nzmwM4Kl/x7Hhyld1v4SbT+tHkZwxlfk/9DBaEXPHZbUAQ8QyZa3J0Q== X-Received: by 2002:a1c:2d86:: with SMTP id t128mr1399886wmt.189.1601577439786; Thu, 01 Oct 2020 11:37:19 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id a3sm964671wmb.46.2020.10.01.11.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 11:37:19 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH 1/5] MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations Date: Thu, 1 Oct 2020 19:37:08 +0100 Message-Id: <20201001183712.1738-2-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201001183712.1738-1-leif@nuviainc.com> References: <20201001183712.1738-1-leif@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop redundant comment about IPF (clearly copied across from now deleted code). Also change "Instead is resumes execution" -> "Instead it resumes execution" Signed-off-by: Leif Lindholm --- MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 3 +-- MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 3 +-- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 3 +-- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S index 72cea259e913..989736cee74c 100644 --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S @@ -33,7 +33,6 @@ GCC_ASM_EXPORT(InternalLongJump) # value to be returned by SetJump(). # # If JumpBuffer is NULL, then ASSERT(). -# For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, then ASSERT(). # # @param JumpBuffer A pointer to CPU context buffer. # @@ -61,7 +60,7 @@ ASM_PFX(SetJump): # # Restores the CPU context from the buffer specified by JumpBuffer. # This function never returns to the caller. -# Instead is resumes execution based on the state of JumpBuffer. +# Instead it resumes execution based on the state of JumpBuffer. # # @param JumpBuffer A pointer to CPU context buffer. # @param Value The value to return when the SetJump() context is restored. diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm index 20dd0f1b850f..8922128e8c62 100644 --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm @@ -32,7 +32,6 @@ ; value to be returned by SetJump(). ; ; If JumpBuffer is NULL, then ASSERT(). -; For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, then ASSERT(). ; ; @param JumpBuffer A pointer to CPU context buffer. ; @@ -60,7 +59,7 @@ SetJump ; ; Restores the CPU context from the buffer specified by JumpBuffer. ; This function never returns to the caller. -; Instead is resumes execution based on the state of JumpBuffer. +; Instead it resumes execution based on the state of JumpBuffer. ; ; @param JumpBuffer A pointer to CPU context buffer. ; @param Value The value to return when the SetJump() context is restored. diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S index 82d94faf61e9..e4c1946a28ff 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S @@ -19,7 +19,6 @@ GCC_ASM_EXPORT(InternalLongJump) # value to be returned by SetJump(). # # If JumpBuffer is NULL, then ASSERT(). -# For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, then ASSERT(). # # @param JumpBuffer A pointer to CPU context buffer. # @@ -42,7 +41,7 @@ ASM_PFX(SetJump): # # Restores the CPU context from the buffer specified by JumpBuffer. # This function never returns to the caller. -# Instead is resumes execution based on the state of JumpBuffer. +# Instead it resumes execution based on the state of JumpBuffer. # # @param JumpBuffer A pointer to CPU context buffer. # @param Value The value to return when the SetJump() context is restored. diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm index 936f722be60f..e1eff758f7ab 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm @@ -19,7 +19,6 @@ ; value to be returned by SetJump(). ; ; If JumpBuffer is NULL, then ASSERT(). -; For IPF CPUs, if JumpBuffer is not aligned on a 16-byte boundary, then ASSERT(). ; ; @param JumpBuffer A pointer to CPU context buffer. ; @@ -42,7 +41,7 @@ SetJump ; ; Restores the CPU context from the buffer specified by JumpBuffer. ; This function never returns to the caller. -; Instead is resumes execution based on the state of JumpBuffer. +; Instead it resumes execution based on the state of JumpBuffer. ; ; @param JumpBuffer A pointer to CPU context buffer. ; @param Value The value to return when the SetJump() context is restored. -- 2.20.1