From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web12.1030.1601577443184171754 for ; Thu, 01 Oct 2020 11:37:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=KqhGFumm; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id s13so3923897wmh.4 for ; Thu, 01 Oct 2020 11:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nMjWPbTQ2pg7CoCZoWqZe+nZ+MQOEcAaYS56yLbakmQ=; b=KqhGFummYYhC5ltxSrstL0rZM7JtL//6wBWxEi2eKTx8bBV307DAuWbUdyEmkTGoHS xfnN2Zp4hEbm601KlsSjfdshbnsKGqK+1M57eu/cUmoIhE570rYgIKLZNG3veZ8hT9Oc 1f9lJpKcIFrMq3Znp0KSzGoTqyGrcE670hemRl28vYZqeK++/NPo0Zphg5GJiICYOk45 7qEh7RVko04gZgBOYIjwztPVcTwaSL0FDezq4f0H5UFFO6iyB70UuWEd8VUSW7LzPlsk ShexgvB/m6pFhdDYihUP4Gn/aDeMO7wWKKKUjZm6kigXlKTbGWX4/z/t26KLSMiM6K58 1fdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nMjWPbTQ2pg7CoCZoWqZe+nZ+MQOEcAaYS56yLbakmQ=; b=JySKdYJCNZyww/JxjlQE4mlplikVYTbqsZtpUKll0f9dbKt7uGtmiKQaoKtzs9LL/6 ihwS4ps85sxPcK6GXO3wi4MUyZffGAx/HAbD24xiV9lHSUNNVw3qErOmntHs2skwTUK5 g1nZhGCKuYdwy7vmb7gi0nnloo+Y5ovH7D/6Up6iYTFXWdaHboBBZ+cBak9ud68DkUpF 3unUzeurCXi8ZBG9M7vZhroQsJ0Ybc3VHbZZep3picbiKwXTRj27ODqBy/vNPyVGaNVz DU2jUQUFJ5ZKiKwHEt//HH6Dy86xdUADi3DxCVMWxafzsLMeYx6I9NSslmmW52MOiEN0 rEyA== X-Gm-Message-State: AOAM531uURotAJsm5PCC1zO/IwKj/LY8YjfBgD+sPnBwOPSwDqZVHF3o pDdSJIr2IBC/W2dxZQCSm0PPIp33hYGkicXhF8iNsf/DQ9eyvtIgIp3hwlstTKr1xO5bKxDBG5y PWRIfEHY14wp7uIJPfim4+Um1t6uCySOJ11Axm4gIgXRFi1r50Brai5fvpxVcxWODrbuO X-Google-Smtp-Source: ABdhPJxzL62SMvP9j/umB3efaGhpmMPEwN7NYqQ3bnkCZhhOEmW0mDBzpuukqpm20uJUrNeCnHn9jA== X-Received: by 2002:a7b:c111:: with SMTP id w17mr1296903wmi.109.1601577441420; Thu, 01 Oct 2020 11:37:21 -0700 (PDT) Return-Path: Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id a3sm964671wmb.46.2020.10.01.11.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 11:37:21 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations Date: Thu, 1 Oct 2020 19:37:10 +0100 Message-Id: <20201001183712.1738-4-leif@nuviainc.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201001183712.1738-1-leif@nuviainc.com> References: <20201001183712.1738-1-leif@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readable mov r0, #0 instead. Signed-off-by: Leif Lindholm --- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S | 2 +- MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S index 54b11ad2197c..407df5f41ac5 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.S @@ -36,7 +36,7 @@ ASM_PFX(SetJump): pop {r0, lr} mov r3, r13 stmia r0, {r3-r12,r14} - eor r0, r0, r0 + mov r0, #0 bx lr #/** diff --git a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm index 6d47033975f2..3a45f045460a 100644 --- a/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm +++ b/MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm @@ -36,7 +36,7 @@ SetJump POP {R0, LR} MOV R3, R13 STM R0, {R3-R12,R14} - EOR R0, R0 + MOV RO, #0 BX LR ;/** -- 2.20.1