From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ard.biesheuvel@arm.com>,
<leif@nuviainc.com>, <thomas.abraham@arm.com>,
<Matteo.Carlini@arm.com>, <Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg
Date: Fri, 2 Oct 2020 00:15:28 +0100 [thread overview]
Message-ID: <20201001231528.100364-1-sami.mujawar@arm.com> (raw)
The commit at "b5701a4c7a0f CryptoPkg: OpensslLib: Use RngLib to
generate entropy in rand_pool" updated CryptoPkg\OpenSSL to no
longer depend on TimerLib and instead use RngLib. This is done so
that platforms can choose the desired entropy source. However, this
change breaks the builds for platforms under Platform/ARM.
To fix this, update ArmVExpress.dsc.inc to use a TimerLib based
implementation of RngLib.
Note: The TimerLib based implementation of RngLib replicates past
behavior when used with OpenSSL. However, this should not be used
in production as a real source of entropy.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1441_fix_platform_arm_build_break_v1
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index bde3437b56d71be9259b18bc0501976695639c62..6f4621393a9713705e360a1c9ad019a6ad93a0a4 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -1,5 +1,5 @@
#
-# Copyright (c) 2011-2019, ARM Limited. All rights reserved.
+# Copyright (c) 2011-2020, Arm Limited. All rights reserved.
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -138,6 +138,7 @@ [LibraryClasses.common]
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+ RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next reply other threads:[~2020-10-01 23:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 23:15 Sami Mujawar [this message]
2020-10-02 8:19 ` [PATCH edk2-platforms v1 1/1] Platform/ARM: TimerLib based RngLib for CryptoPkg Ard Biesheuvel
2020-10-02 14:12 ` [edk2-devel] " Thomas Abraham
2020-10-04 16:44 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001231528.100364-1-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox