* [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib
@ 2020-10-05 11:26 Andrew Goodbody
2020-10-05 14:31 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Goodbody @ 2020-10-05 11:26 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki,
Tanmay Jagdale, Andrew Goodbody
Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
entropy in rand_pool") introduced RngLib dependency for OpensslLib
and caused QEMU platforms build to break for lack of an RngLib instance.
Add the reference to RngLib to the SbsaQemu.dsc file
Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index d42b9cd4de..0e6d738bee 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -141,6 +141,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
#
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+ RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
#
--
2.18.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib
2020-10-05 11:26 [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib Andrew Goodbody
@ 2020-10-05 14:31 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-10-05 14:31 UTC (permalink / raw)
To: Andrew Goodbody, devel
Cc: Leif Lindholm, Graeme Gregory, Radoslaw Biernacki, Tanmay Jagdale
On 10/5/20 1:26 PM, Andrew Goodbody wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused QEMU platforms build to break for lack of an RngLib instance.
>
> Add the reference to RngLib to the SbsaQemu.dsc file
>
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as 8ef23e848b76..1288ede92a1c
Thanks,
>
> ---
> Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index d42b9cd4de..0e6d738bee 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -141,6 +141,7 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> #
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
>
> #
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-05 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-05 11:26 [PATCH] Platform/Qemu/Sbsa: Fix build break due to need for RngLib Andrew Goodbody
2020-10-05 14:31 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox