From: "cbduggap" <chinni.b.duggapu@intel.com>
To: devel@edk2.groups.io
Cc: cbduggap <chinni.b.duggapu@intel.com>,
Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Subject: [Patch V5 1/1] Tools\FitGen: Add extra parameter to input the Top Flash Address
Date: Mon, 5 Oct 2020 19:43:09 +0530 [thread overview]
Message-ID: <20201005141309.12427-3-chinni.b.duggapu@intel.com> (raw)
In-Reply-To: <20201005141309.12427-1-chinni.b.duggapu@intel.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981
Add extra parameter to the Fit Gen Tool to input the Top Flash Address.
Default Address should be 4GB and if some one inputs new address,
tool must consume that address instead of Default address (4GB).
Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
---
Silicon/Intel/Tools/FitGen/FitGen.c | 23 +++++++++++++++++++++--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c
index c4006e69c8..cb60a3c324 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -209,10 +209,12 @@ typedef struct {
#define DEFAULT_FIT_TABLE_POINTER_OFFSET 0x40
#define DEFAULT_FIT_ENTRY_VERSION 0x0100
+#define TOP_FLASH_ADDRESS (gFitTableContext.TopFlashAddressRemapValue)
+
#define MEMORY_TO_FLASH(FileBuffer, FvBuffer, FvSize) \
- (UINTN)(0x100000000 - ((UINTN)(FvBuffer) + (UINTN)(FvSize) - (UINTN)(FileBuffer)))
+ (UINTN)(TOP_FLASH_ADDRESS - ((UINTN)(FvBuffer) + (UINTN)(FvSize) - (UINTN)(FileBuffer)))
#define FLASH_TO_MEMORY(Address, FvBuffer, FvSize) \
- (VOID *)(UINTN)((UINTN)(FvBuffer) + (UINTN)(FvSize) - (0x100000000 - (UINTN)(Address)))
+ (VOID *)(UINTN)((UINTN)(FvBuffer) + (UINTN)(FvSize) - (TOP_FLASH_ADDRESS - (UINTN)(Address)))
#define FIT_TABLE_TYPE_HEADER 0
#define FIT_TABLE_TYPE_MICROCODE 1
@@ -268,6 +270,7 @@ typedef struct {
UINT32 MicrocodeVersion;
FIT_TABLE_CONTEXT_ENTRY OptionalModule[MAX_OPTIONAL_ENTRY];
FIT_TABLE_CONTEXT_ENTRY PortModule[MAX_PORT_ENTRY];
+ UINT64 TopFlashAddressRemapValue;
} FIT_TABLE_CONTEXT;
FIT_TABLE_CONTEXT gFitTableContext = {0};
@@ -330,6 +333,7 @@ Returns:
"\t[-F <FitTablePointerOffset>] [-F <FitTablePointerOffset>] [-V <FitHeaderVersion>]\n"
"\t[-NA]\n"
"\t[-A <MicrocodeAlignment>]\n"
+ "\t[-REMAP <TopFlashAddress>\n"
"\t[-CLEAR]\n"
"\t[-L <MicrocodeSlotSize> <MicrocodeFfsGuid>]\n"
"\t[-I <BiosInfoGuid>]\n"
@@ -986,6 +990,21 @@ Returns:
Index += 2;
}
+ if ((Index >= argc) ||
+ ((strcmp (argv[Index], "-REMAP") == 0) ||
+ (strcmp (argv[Index], "-remap") == 0)) ) {
+ //
+ // by pass
+ //
+ gFitTableContext.TopFlashAddressRemapValue = xtoi (argv[Index + 1]);
+ Index += 2;
+ } else {
+ //
+ // no remapping
+ //
+ gFitTableContext.TopFlashAddressRemapValue = 0x100000000;
+ }
+ printf ("Top Flash Address Value : 0x%llx\n", gFitTableContext.TopFlashAddressRemapValue);
//
// 0.4 Clear FIT table related memory
//
--
2.26.2.windows.1
next prev parent reply other threads:[~2020-10-05 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 14:13 [Patch V1 1/1] \Silicon\Intel\Tools\FitGen: Add extra parameter to the Fit Gen Tool to input the Higher Flash Address cbduggap
2020-10-05 14:13 ` [Patch V4 1/1] Tools\FitGen: Add extra parameter " cbduggap
2020-10-05 14:13 ` cbduggap [this message]
2020-10-09 10:02 ` 回复: [Patch V5 1/1] Tools\FitGen: Add extra parameter to input the Top " gaoliming
[not found] ` <163C4ABEA87228CD.15658@groups.io>
2020-10-10 0:48 ` 回复: [edk2-devel] " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005141309.12427-3-chinni.b.duggapu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox