From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.15786.1601995028475931854 for ; Tue, 06 Oct 2020 07:37:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=D3kNs6VD; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id h7so10128271wre.4 for ; Tue, 06 Oct 2020 07:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BIyLr9E6d3cO4f1EiCfKbqN0HiyIBZNQFDUUs+JpJt4=; b=D3kNs6VDkEpjRdA392JT1Dyenn1YBzdaQVrV/COP2B3nWRNMXhTrPBszo6yZUTmgcA Jh/ihMfNG/fDh25ArIZGQxuGzPkVYu5oWrFOGRFjBO5F25QI96klE0a7pETnNOn17e+j rpE4SAtD2oODj9w7RAsnAoyP1D9P9I2VuSkfWfNPD3CGkBXGvwg6cvdLji5TC+A/Wrjx cyWOT3yV1s5md7Re+UJgALkA2+ZFI6hB39lzq5c8kfnPojzNMCfxtXYEiKweZ5VVNwaQ cnQSQNEwEqLT8eu310EkwyCmXo0drhuQtkUa4P7G+PEKahHoAR1A3r6eun6sGKV5qyis m/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BIyLr9E6d3cO4f1EiCfKbqN0HiyIBZNQFDUUs+JpJt4=; b=qrE70/zxQ/BRW55cnhgBKZpkf32rrYDPPP4SWh733SjUCSd4m5Eno4CiAGNICwOazV v0G/Z2wezW5LAqJ+snP0sygTnxSmiPfy+Ywyfno9e4NS2+Nq16cRUydwy5mTkLSjsmga ILoHr4QIp+8QGCQJWhPG0pmJPO07TQ56hmIT87USHNzOmnOu41z+/eONc6zZt/trd74c ohea3unw9Y+Gkp9FKKbqw3aI5dCPrnW+i+QvY545JjaEmViluQNgTV+F6435PNpSF0uk gSYp19535yxtWBV62LwGFUSJ51WC5gGRfIFfMrcaOdG9Drw9YlbzJ1Wznb5TNS2hrajG JtbQ== X-Gm-Message-State: AOAM531ULH7MfwDwlbTKIbG6BFiuIA4QICvH4ZA7/pHkn62FHwsxucKB 5K9Z/h0VIaOkxUshql3TlNAO6A== X-Google-Smtp-Source: ABdhPJy6NK0kIrFTJPHTK6dqZf8f69JCSahKYbCl6C5+1LBWVno/7Xjd4Hfdz98hLQw3sJeLjdmkCg== X-Received: by 2002:a05:6000:124d:: with SMTP id j13mr5673983wrx.182.1601995026926; Tue, 06 Oct 2020 07:37:06 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id q6sm4369226wma.0.2020.10.06.07.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 07:37:06 -0700 (PDT) Date: Tue, 6 Oct 2020 15:36:59 +0100 From: "Leif Lindholm" To: Abner Chang Cc: devel@edk2.groups.io, Nickle Wang , Andrew Fish , Laszlo Ersek , Michael D Kinney Subject: Re: [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg. Message-ID: <20201006143659.GP5623@vanye> References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-2-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <20201006104804.14724-2-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline One comment: On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote: > Initial version of RedfishPkg. > > Signed-off-by: Wu Jiaxin > Signed-off-by: Fu Siyuan > Signed-off-by: Wang Fan > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Acked-by: Laszlo Ersek > --- > RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++ > RedfishPkg/RedfishPkg.dec | 18 ++++++++++ > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++ > 3 files changed, 125 insertions(+) > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml > create mode 100644 RedfishPkg/RedfishPkg.dec > create mode 100644 RedfishPkg/RedfishPkg.dsc > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > new file mode 100644 > index 0000000000..e95ec5fe10 > --- /dev/null > +++ b/RedfishPkg/RedfishPkg.dec > @@ -0,0 +1,18 @@ > +## @file > +# Redfish Package > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x0001001b > + PACKAGE_NAME = RedfishPkg > + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008 > + PACKAGE_VERSION = 1.0 > + > +[Guids] > + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }} > + > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc > new file mode 100644 > index 0000000000..d5c65f68c3 > --- /dev/null > +++ b/RedfishPkg/RedfishPkg.dsc > @@ -0,0 +1,40 @@ > +## @file > +# Redfish Package > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + PLATFORM_NAME = RedfishPkg > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008 > + PLATFORM_VERSION = 1.0 > + DSC_SPECIFICATION = 0x0001001c > + OUTPUT_DIRECTORY = Build/RedfishPkg > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64 > + BUILD_TARGETS = DEBUG|RELEASE v3 included NOOPT here. That was the version Laszlo gave his R-b for. v4 cover letter does mention NOOPT being removed, but I can see no conversation in which this is discussed. What have I missed? / Leif > + SKUID_IDENTIFIER = DEFAULT > + > +[LibraryClasses] > + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf > + UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf > + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf > + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > + MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > + SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf > + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > + PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > + PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > + DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf > -- > 2.17.1 >