* [PATCH v1 0/1] TCBZ2381
@ 2020-10-07 18:16 Matthew Carlson
2020-10-07 18:16 ` [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib Matthew Carlson
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Carlson @ 2020-10-07 18:16 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel
From: Matthew Carlson <matthewfcarlson@gmail.com>
This rolls the GUID for PrePiHobLib as it has the same GUID as PrePiLib.
This is considered invalid and this seeks to address that.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Matthew Carlson (1):
[EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib
EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.28.0.vfs.0.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib
2020-10-07 18:16 [PATCH v1 0/1] TCBZ2381 Matthew Carlson
@ 2020-10-07 18:16 ` Matthew Carlson
2020-10-07 18:45 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Carlson @ 2020-10-07 18:16 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel, Matthew Carlson
From: Matthew Carlson <matthewfcarlson@gmail.com>
PrePiHobLib has the same GUID as PrePiLib
This is considered invalid and this seeks to address that.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>
---
EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
index b2c4c04bfd76..55de4511fc98 100644
--- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
+++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
@@ -12,7 +12,7 @@
[Defines]
INF_VERSION = 0x00010005
BASE_NAME = PrePiHobLib
- FILE_GUID = 1F3A3278-82EB-4C0D-86F1-5BCDA5846CB2
+ FILE_GUID = AEF7D85A-6A91-4ACD-9A28-193DEFB325FB
MODULE_TYPE = BASE
VERSION_STRING = 1.0
LIBRARY_CLASS = HobLib
--
2.28.0.vfs.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib
2020-10-07 18:16 ` [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib Matthew Carlson
@ 2020-10-07 18:45 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-10-07 18:45 UTC (permalink / raw)
To: matthewfcarlson, devel; +Cc: Leif Lindholm
On 10/7/20 8:16 PM, matthewfcarlson@gmail.com wrote:
> From: Matthew Carlson <matthewfcarlson@gmail.com>
>
> PrePiHobLib has the same GUID as PrePiLib
> This is considered invalid and this seeks to address that.
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>
Same comment as before re use of [] in the subject line.
Also, what is TCBZ2381? Is that a bugzilla entry? Please use a Link: tag
in the commit log instead.
> ---
> EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> index b2c4c04bfd76..55de4511fc98 100644
> --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> @@ -12,7 +12,7 @@
> [Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = PrePiHobLib
> - FILE_GUID = 1F3A3278-82EB-4C0D-86F1-5BCDA5846CB2
> + FILE_GUID = AEF7D85A-6A91-4ACD-9A28-193DEFB325FB
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> LIBRARY_CLASS = HobLib
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-07 18:16 [PATCH v1 0/1] TCBZ2381 Matthew Carlson
2020-10-07 18:16 ` [PATCH v1 1/1] [EmbeddedPkg] TCBZ2381 - roll guid for PrePiHobLib Matthew Carlson
2020-10-07 18:45 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox