From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.9613.1602155599662141629 for ; Thu, 08 Oct 2020 04:13:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=VOBOOSKC; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id e2so6107741wme.1 for ; Thu, 08 Oct 2020 04:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=03didkMPzjyKc8sB+N1Zn8E5KC0zuLlSWPG2EKyoFdk=; b=VOBOOSKCRWptMkDJtTqIq/nAVwQtqWM0bckqyK7t+1SSkw3Dyrl8T0kuoo/ViygA2u CBaHUkVlj3CzFJAC2Y5R/dDZ3pR9SmAiHY01aQPv7bCfl5jjfPzBKsfjC0KPwlB/SRXH QEBLsYh8wopBRtDTnF3FFgivfNvW6+pmwaWMzTZ0htbVsUomC8nTabaaitzhKpFmpe10 j22B85vcGBEFkN0hrr5ncwisrzms6tzp2UiCCcMzNm6qLDQOg1yGMkm0QEAa0j8Xu4x0 9jBCUyAiTDSvjYqCW3TCrF3Ye6/juDCGSlB83lN8nMCdCtGHwCSHqXTNHxK3t9VW8LMY 6Mrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=03didkMPzjyKc8sB+N1Zn8E5KC0zuLlSWPG2EKyoFdk=; b=HnTa4lZ9wfUl4QGVa/2fA90JyTs1dLKb+ubxafgTRv/WoQpivAnqtJ3/jA092izR+3 sl75S5G9Lchf+APj7Th1imF55d2P2Kyi3WtE77BdqnOQDKzCjTKHYA24q9G/z3SEHFZ1 v59h/3JZWWMuR/ayTH8997C8bDRChtHNDrWUtSCDddsM605GDYHvHkk79LbPgOWzBdqC PVutlf80tRfMrn/CZf8ZqvpmW2C/KOHqSD9Nw9UbgRkGz2aN8JtcX2sigZlWnqYbmLg3 QUAWGHd9SSJFwxpJRYe8Us6t1ovqRZpAisb3yCRAQr7WRhrEDMVEnS6EdAq4sHJO7czi gd2A== X-Gm-Message-State: AOAM532PIyxz44N8wW/oHmuz139aSx/CEso2CVMSwfV+Zv11QLpzkvUd 1f5BUnqiBR/a+1XyuisTZcRjkg== X-Google-Smtp-Source: ABdhPJydMk9PkZooDAFAhrnwvKqPZcZb/4GeNprRHvRePwjKG4v4T/P/zIYJXYmb1NK50VZineG+AQ== X-Received: by 2002:a1c:e154:: with SMTP id y81mr8488138wmg.111.1602155598000; Thu, 08 Oct 2020 04:13:18 -0700 (PDT) Return-Path: Received: from vanye (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id i1sm6620248wrx.44.2020.10.08.04.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 04:13:17 -0700 (PDT) Date: Thu, 8 Oct 2020 12:13:10 +0100 From: "Leif Lindholm" To: matthewfcarlson@gmail.com Cc: devel@edk2.groups.io, Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Ard Biesheuvel Subject: Re: [PATCH v1 1/1] [CryptoPkg] Add CC flags for MSVC ARM on IntrinsicLib Message-ID: <20201008111310.GU5623@vanye> References: <20201007184145.5232-1-matthewfcarlson@gmail.com> <20201007184145.5232-2-matthewfcarlson@gmail.com> MIME-Version: 1.0 In-Reply-To: <20201007184145.5232-2-matthewfcarlson@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I have some minor technical comments on this patch, and then I'll follow up with a separate reply on the topic of how we appear to have duplicated (at least) intrinsics libraries with overlapping functionality in the tree... On Wed, Oct 07, 2020 at 11:41:45 -0700, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > This adds compiler flags for AARCH64 and ARM for the Visual Studio > compilers to the IntrinsicLib inf. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Matthew Carlson > --- > CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > index fcbb93316cf7..ad05b3a000c4 100644 > --- a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > +++ b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > @@ -64,4 +64,6 @@ > MSFT:RELEASE_*_IA32_CC_FLAGS == /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /FIAutoGen.h /EHs-c- /GR- /GF > MSFT:DEBUG_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm > MSFT:RELEASE_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF > - INTEL:*_*_*_CC_FLAGS = /Oi- This whitespace-only change is unrelated to the patch context. Please submit it separately, or drop altogether. (On a separate note, that line is the only correctly indented - 2 spaces - line in the whole block; if anything should change it should be all the others. So if resubmitting, please use 2 spaces for added lines.) > + MSFT:DEBUG_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm > + MSFT:RELEASE_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF More a comment than a request: CryptoPkg.dsc itself supports the NOOPT build target, and the majority of the platforms in edk2-platforms do as well - if adding these, could we have a line for the NOOPT target as well? Best Regards, Leif > + INTEL:*_*_*_CC_FLAGS = /Oi- > -- > 2.28.0.vfs.0.0 >