From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web10.10843.1602159621926642790 for ; Thu, 08 Oct 2020 05:20:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=g8Yp7j7Y; spf=pass (domain: nuviainc.com, ip: 209.85.221.46, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f46.google.com with SMTP id i1so240665wro.1 for ; Thu, 08 Oct 2020 05:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NoZLIo1C2sQKnQZzkoUQ4sryEP2OHHhUtbH9Dol91Sw=; b=g8Yp7j7YQl2tOUHXN8+huNsqaUrn6EPu1aWqY/Tqd9jBBZQuJgE45LAuT+F7LgHjRX rvrqbji/1VQ+W0aY6R1RAGQm+FsxKVI5nb9gJ3c2aN1qHZC/Odv+ypAvPN2iHRsnEkz6 0fN7Qc/arPatMwn0RttymSzgyBy5x976DWSudwDivNW3YZb0w+F1v7zHTLCLTddKCIZW tp2NdeXvOL8SjYb2KmyuqgDyHIe74+zaEB3aExdM9UoKsLfRj6/GrlL9YUJgOiP49k1s UYfDDA9Hysg/IISfhvSCmx8H96LknQlsJDwIKlsVrZpdvY9GOgsZqdwkJzlZnXvUIA33 2z9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NoZLIo1C2sQKnQZzkoUQ4sryEP2OHHhUtbH9Dol91Sw=; b=Y+1lcGGWSsf718lr11C6VmB5SkYwxWLsouoPXzLJXiex5vcbH4jTzIdd5/mjvcdIRq LnVgm14MUCzabj8ZG2mhZQOgyvrmdhQkGKfw0u/ujaRUZOF8/VtVHJcZVzvUq5ise7yz E59iVkVjv74KEsqnh84ptqaApvXb8cTpUe1PJyGb7jDj8yX57iSE0rVaPB2YBj6dvy07 XLqd6P11EUqS3Qzkb9o/lCnTHmOJsfNwFu7YIlqVRE2CItjlnHRLe/PggeMO5Gj5IN0J AS6p7xKn2c4N8W3OhsRzljaJcWd6wV3KXXWy6aYNWSHNRU6mvUazAAPX0BLzoY8gXl7x 75nQ== X-Gm-Message-State: AOAM532MQwfTSnDpRcaPnoveKYi/BsESWaTBsZ2fQBQ4ZI3Ua009nI8u lpXiC/po7Cw11ipCBjIuS8FHCA== X-Google-Smtp-Source: ABdhPJz3DubSkq8LpQsQKmwedVHbotp2qyd0z6Gw0qXtvc8LqkLDIEG+n07J1OJKA6FWN7MY6b7Jgg== X-Received: by 2002:adf:e907:: with SMTP id f7mr8896113wrm.169.1602159620277; Thu, 08 Oct 2020 05:20:20 -0700 (PDT) Return-Path: Received: from vanye (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id a81sm7604327wmf.32.2020.10.08.05.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 05:20:19 -0700 (PDT) Date: Thu, 8 Oct 2020 13:20:13 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@arm.com, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com Subject: Re: [edk2-platforms v2 0/6] Enable USB support on LS1046aFrwy board Message-ID: <20201008122013.GB5623@vanye> References: <1600187343-18732-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> <1602087041-8009-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <1602087041-8009-1-git-send-email-meenakshi.aggarwal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Meenakshi, Can you please resubmit patches 4-5/6 only, addressing the feedback. This will then be ready to merge. / Leif On Wed, Oct 07, 2020 at 21:40:35 +0530, Meenakshi Aggarwal wrote: > This patch set adds GPIO Library. > Gpio Library is required to set muxing to enable USB controller. > > > Changes in v2: > - Modified GpioLib as per review comments > - Prepared separate patch for SCFG enablement > - Prepared sepaarte patch for USB errata implementation > > > Meenakshi Aggarwal (6): > Silicon/NXP: Add GPIO Library support. > Platform/NXP/LS1046aFrwyPkg: MUX changes for USB > Silicon/NXP: Add SCFG support for Chassis2 > Silicon/NXP: Implement USB Errata Workarounds > Silicon/NXP/LS1046A: Apply USB errata workarounds > LS1046aFrwy: Enable USB support for LS1046AFRWY board. > > Silicon/NXP/NxpQoriqLs.dec | 9 + > Silicon/NXP/LS1046A/LS1046A.dsc.inc | 9 + > Silicon/NXP/NxpQoriqLs.dsc.inc | 2 + > Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc | 2 + > Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf | 13 ++ > .../Library/ArmPlatformLib/ArmPlatformLib.inf | 1 + > .../NXP/Chassis2/Library/ChassisLib/ChassisLib.inf | 2 + > Silicon/NXP/LS1046A/Library/SocLib/SocLib.inf | 2 + > Silicon/NXP/Library/GpioLib/GpioLib.inf | 39 ++++ > Silicon/NXP/Chassis2/Include/Chassis.h | 112 +++++++++++ > Silicon/NXP/Chassis2/Library/ChassisLib/Erratum.h | 23 +++ > Silicon/NXP/Include/Library/ChassisLib.h | 62 ++++++ > Silicon/NXP/Include/Library/GpioLib.h | 110 +++++++++++ > Silicon/NXP/LS1046A/Include/Soc.h | 2 + > .../Library/ArmPlatformLib/ArmPlatformLib.c | 21 ++ > .../NXP/Chassis2/Library/ChassisLib/ChassisLib.c | 63 ++++++ > Silicon/NXP/Chassis2/Library/ChassisLib/Erratum.c | 165 ++++++++++++++++ > Silicon/NXP/LS1046A/Library/SocLib/SocLib.c | 66 +++++++ > Silicon/NXP/Library/GpioLib/GpioLib.c | 219 +++++++++++++++++++++ > 19 files changed, 922 insertions(+) > mode change 100644 => 100755 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc > mode change 100644 => 100755 Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.fdf > create mode 100644 Silicon/NXP/Library/GpioLib/GpioLib.inf > create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/Erratum.h > create mode 100644 Silicon/NXP/Include/Library/GpioLib.h > create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/Erratum.c > create mode 100644 Silicon/NXP/Library/GpioLib/GpioLib.c > > -- > 1.9.1 >