From: "Leif Lindholm" <leif@nuviainc.com>
To: Shashi Mallela <shashi.mallela@linaro.org>
Cc: ard.biesheuvel@arm.com, ray.ni@intel.com, devel@edk2.groups.io
Subject: Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT
Date: Fri, 9 Oct 2020 18:17:18 +0100 [thread overview]
Message-ID: <20201009171718.GG5623@vanye> (raw)
In-Reply-To: <20201008205741.96034-2-shashi.mallela@linaro.org>
Hi Shashi,
I am a little bit confused here.
edk2$ git grep EFI_ACPI_6_._GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE
MdePkg/Include/IndustryStandard/Acpi60.h:#define EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T')
MdePkg/Include/IndustryStandard/Acpi61.h:#define EFI_ACPI_6_1_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T')
MdePkg/Include/IndustryStandard/Acpi62.h:#define EFI_ACPI_6_2_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T')
MdePkg/Include/IndustryStandard/Acpi63.h:#define EFI_ACPI_6_3_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T')
What is the benefit of changing the name of the macro used?
Best Regards,
Leif
On Thu, Oct 08, 2020 at 16:57:41 -0400, Shashi Mallela wrote:
> Updated the GTDT signature to ACPIv6.3
>
> Signed-off-by: Shashi Mallela <shashi.mallela@linaro.org>
> ---
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> index d2f26ff89f12..3f9173523493 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c
> @@ -52,7 +52,7 @@ ACPI_TABLE_PARSER ParserList[] = {
> ParseAcpiDsdt},
> {EFI_ACPI_6_3_FIRMWARE_ACPI_CONTROL_STRUCTURE_SIGNATURE, ParseAcpiFacs},
> {EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiFadt},
> - {EFI_ACPI_6_2_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiGtdt},
> + {EFI_ACPI_6_3_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiGtdt},
> {EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE, ParseAcpiIort},
> {EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiMadt},
> {EFI_ACPI_6_2_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE,
> --
> 2.18.4
>
next prev parent reply other threads:[~2020-10-09 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 20:57 [PATCH v1 0/1] ACPI version update for GTDT Shashi Mallela
2020-10-08 20:57 ` [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi " Shashi Mallela
2020-10-09 17:17 ` Leif Lindholm [this message]
2020-10-09 17:27 ` [edk2-devel] " shashi.mallela
2020-10-09 18:27 ` shashi.mallela
2020-10-13 10:32 ` Leif Lindholm
2020-10-23 6:18 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009171718.GG5623@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox