From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.1137.1602263847018331498 for ; Fri, 09 Oct 2020 10:17:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=hiR8zv31; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id q5so10564337wmq.0 for ; Fri, 09 Oct 2020 10:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YMU7mu2MN17I9Po3ZEtqM/rBykYEPvu7nXfct5Voaz8=; b=hiR8zv31zaJR53t+o0Jo9xgZ7lT3v746dECCbf3LvxsxuT0rpVGOsrc2kn3cOlbtWR toabZHx0oCb8Mg4L+tEKxgdh2WUfoOSCnxwkWcSHhIkY4VQwaiVPa8H8cFRK6h1d4dGm Dm2XJ2612YB60oatpniCrL4LoF+BikuT189995CLPruE5D6MRT7vxCZ65Z574PJ/pyq3 eLErsqB7YwPyiuCQkYelm06m8QII9aL2uJQfdDseW46E5AyBH6kXCTBC7voDKSnk9/Mj 1OsGZLC7Ukag1DUGxp6HDWu/mObql3+Fp3ia+pL64rDIwUb+OVzjXQTuC2HOUGtuRV+H a0/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YMU7mu2MN17I9Po3ZEtqM/rBykYEPvu7nXfct5Voaz8=; b=b9berTUReo2Vi5y/kkOanXPqhD5CjZIySYgaQcB3M4O3JWh5zmt1REdXy+HmGBH58I jEX9zLUorFQfqgXwqoKN8daid8F+OGqGqil3+PM22cC1m6CKSgRfJRAZysFkCVKeju69 9ide31Le8SrsaCUWOCiXNA19z/6ZJyHAoPgMu6p4myI4eTjHB7nD3Rnf6kNJVsbaZoAf pw2prR+9UoXM076gqVy7nStvIM6oEAtrTb5AAvbjT9ycRRmK0rBTXtuZYHphfjpMaqYS RBbpRWIpJ3ur9B9eZarNrVO+v8p3xHidoiW5gsF2gY8weI7yiuuSLhUhioyYBqD/GD+n dbFQ== X-Gm-Message-State: AOAM5330BuKaul8DE4hs+Ca+1r+d5dD5xiMktdkOIBO8SixQZllBWD9n /8zVu2MjDK0gjk5Vyc8lpluYYA== X-Google-Smtp-Source: ABdhPJzBXMH+CKFiuqgE4O5WTlHu5grR2JakxxHhC4RvuvElfr1xsV9J/KWHx192TNsQSEZfG5Qidg== X-Received: by 2002:a7b:c0d8:: with SMTP id s24mr14923187wmh.156.1602263845427; Fri, 09 Oct 2020 10:17:25 -0700 (PDT) Return-Path: Received: from vanye (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id b63sm13632485wme.9.2020.10.09.10.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 10:17:25 -0700 (PDT) Date: Fri, 9 Oct 2020 18:17:18 +0100 From: "Leif Lindholm" To: Shashi Mallela Cc: ard.biesheuvel@arm.com, ray.ni@intel.com, devel@edk2.groups.io Subject: Re: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT Message-ID: <20201009171718.GG5623@vanye> References: <20201008205741.96034-1-shashi.mallela@linaro.org> <20201008205741.96034-2-shashi.mallela@linaro.org> MIME-Version: 1.0 In-Reply-To: <20201008205741.96034-2-shashi.mallela@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Shashi, I am a little bit confused here. edk2$ git grep EFI_ACPI_6_._GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE MdePkg/Include/IndustryStandard/Acpi60.h:#define EFI_ACPI_6_0_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T') MdePkg/Include/IndustryStandard/Acpi61.h:#define EFI_ACPI_6_1_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T') MdePkg/Include/IndustryStandard/Acpi62.h:#define EFI_ACPI_6_2_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T') MdePkg/Include/IndustryStandard/Acpi63.h:#define EFI_ACPI_6_3_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE SIGNATURE_32('G', 'T', 'D', 'T') What is the benefit of changing the name of the macro used? Best Regards, Leif On Thu, Oct 08, 2020 at 16:57:41 -0400, Shashi Mallela wrote: > Updated the GTDT signature to ACPIv6.3 > > Signed-off-by: Shashi Mallela > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > index d2f26ff89f12..3f9173523493 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c > @@ -52,7 +52,7 @@ ACPI_TABLE_PARSER ParserList[] = { > ParseAcpiDsdt}, > {EFI_ACPI_6_3_FIRMWARE_ACPI_CONTROL_STRUCTURE_SIGNATURE, ParseAcpiFacs}, > {EFI_ACPI_6_2_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiFadt}, > - {EFI_ACPI_6_2_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiGtdt}, > + {EFI_ACPI_6_3_GENERIC_TIMER_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiGtdt}, > {EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE, ParseAcpiIort}, > {EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE_SIGNATURE, ParseAcpiMadt}, > {EFI_ACPI_6_2_PCI_EXPRESS_MEMORY_MAPPED_CONFIGURATION_SPACE_BASE_ADDRESS_DESCRIPTION_TABLE_SIGNATURE, > -- > 2.18.4 >