From: "Leif Lindholm" <leif@nuviainc.com>
To: shashi.mallela@linaro.org
Cc: devel@edk2.groups.io, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT
Date: Tue, 13 Oct 2020 11:32:46 +0100 [thread overview]
Message-ID: <20201013103246.GI5623@vanye> (raw)
In-Reply-To: <6304.1602268065672852204@groups.io>
On Fri, Oct 09, 2020 at 11:27:45 -0700, shashi.mallela@linaro.org wrote:
> Hi Lief,
>
> The macro has only been updated to reflect the latest ACPI version
> 6.3 and stay in sync with the edk2-platform gtdt updates made for
> sbsa platform
>
> based on the same ACPI version 6.3.
Which is based on 6.2, which is based on 6.1, which is based on 6.0 as
per my previous email. There is no benefit to changing to a different
macro that expands to exactly the same value.
Yes, it is a bit confusing that we apparently keep adding aliases for
such basic things as signatures of standard tabled for each new
release of ACPI, but it doesn't mean we have to add to the churn by
changing unaffected code simply to "keep up".
This patch has no functional changes, and does not improve the code,
so I would recommend the ShellPkg maintainers ignore it.
/
Leif
next prev parent reply other threads:[~2020-10-13 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 20:57 [PATCH v1 0/1] ACPI version update for GTDT Shashi Mallela
2020-10-08 20:57 ` [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi " Shashi Mallela
2020-10-09 17:17 ` Leif Lindholm
2020-10-09 17:27 ` [edk2-devel] " shashi.mallela
2020-10-09 18:27 ` shashi.mallela
2020-10-13 10:32 ` Leif Lindholm [this message]
2020-10-23 6:18 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013103246.GI5623@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox