From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.8901.1602585175304483101 for ; Tue, 13 Oct 2020 03:32:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=QatWIX0W; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id n18so23390128wrs.5 for ; Tue, 13 Oct 2020 03:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O5njlku4nBmiKhVHZ7weN+dZzrOSGVrQXCM1EY/0P58=; b=QatWIX0Wxt2tTAA2SqF2fjJ7TOSnjpUDolDfp6fqteYQJ9LDNPJhSgFbdIBSHz/Ty5 VfhMBIXka6sIqV3VlApsSND13VHzQWIYRLL4VNLK9oGRIIRETCWUo8Hu8eGxIO4TGk8z G/Oncd9Muqk32J93KUt0FSAqaV2Tr9b6+lTN/j/P6W4cADgdyZUjh7qmJvMEubHVZurd oDc3WdTCU/kXb5RPAgh9jEDUeo+Ryk6Z/0KpUOubZQbeiTHg3kDnI5t3L9qRZwcq/2BJ /09IbOFKmwOVZRp/jpE7/wBnnarnMeY+lj7WvPFtid6lrMrW52N/Fmt9+eyHl0VZP1QY 92kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O5njlku4nBmiKhVHZ7weN+dZzrOSGVrQXCM1EY/0P58=; b=YzzV9ABpCQbgO7Vl6BO64ls3pY7gQJJbH6xkJnH597OqhrNEzwUnU1i/fnw2mJXFmd +A5/jgCxyqlWVTwbFxp+wgiLFEgT7FQkCIYNHWAm+cqYACPNUFHrafoWqLLdK2rRTn7O 19l7kXHGqY085GGUorzgghsJTFTqSgN7C1uXQS7OduzDimXWybYwIYcr5Di78fq8N7xG tk7QDWHTBW7J+/FtVLlhd0nTu97RHZl/1DwrbB1HpWzsyoa2YHwgqsipeUrAX4fKqa3F PnZBVX6a7+bE0EGG3Zp4I2hBTfoS6+q0a6htZCjUxF10QwdLQrwWDVh9U0oCbosXn8p8 qr1g== X-Gm-Message-State: AOAM533OEYm4gjsc/Z6I8vVrmyzTxoTSTYsMyvioeFOtPmTSBsE1MOkP CE5SNCHFhxkd8fj/Lc/D5eHxXQ== X-Google-Smtp-Source: ABdhPJydqAme9Rr3q9UK4v4mSclRjQOfis7nZdY8r5YgKPeFf98AOd+E6xqmwkgbx6MvR09xR+ahTg== X-Received: by 2002:a5d:4ed2:: with SMTP id s18mr26335639wrv.36.1602585173901; Tue, 13 Oct 2020 03:32:53 -0700 (PDT) Return-Path: Received: from vanye (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id d30sm30374596wrc.19.2020.10.13.03.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 03:32:53 -0700 (PDT) Date: Tue, 13 Oct 2020 11:32:46 +0100 From: "Leif Lindholm" To: shashi.mallela@linaro.org Cc: devel@edk2.groups.io, Ray Ni , Zhichao Gao Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: acpi version update for GTDT Message-ID: <20201013103246.GI5623@vanye> References: <20201009171718.GG5623@vanye> <6304.1602268065672852204@groups.io> MIME-Version: 1.0 In-Reply-To: <6304.1602268065672852204@groups.io> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 09, 2020 at 11:27:45 -0700, shashi.mallela@linaro.org wrote: > Hi Lief, > > The macro has only been updated to reflect the latest ACPI version > 6.3 and stay in sync with the edk2-platform gtdt updates made for > sbsa platform > > based on the same ACPI version 6.3. Which is based on 6.2, which is based on 6.1, which is based on 6.0 as per my previous email. There is no benefit to changing to a different macro that expands to exactly the same value. Yes, it is a bit confusing that we apparently keep adding aliases for such basic things as signatures of standard tabled for each new release of ACPI, but it doesn't mean we have to add to the churn by changing unaffected code simply to "keep up". This patch has no functional changes, and does not improve the code, so I would recommend the ShellPkg maintainers ignore it. / Leif