public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Mark Wilson <Mark.Wilson@amd.com>
To: devel@edk2.groups.io
Cc: Mark Wilson <Mark.Wilson@amd.com>
Subject: [PATCH v1 0/1] Clean up save state boundary checks and comments in functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister
Date: Thu, 15 Oct 2020 11:32:42 -0500	[thread overview]
Message-ID: <20201015163243.364-1-Mark.Wilson@amd.com> (raw)

The update does the following:
* For functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister, the boundary check for register copy incorrectly includes if the width is DWORD to determine if to write upper 32-bits. This is clean up as in this case number of bytes to copy is 0.
* Correct comments for above functions.
* Correct coding style spacing for CopyMem and ASSERT in above functions.

Mark Wilson (1):
  UefiCpuPkg: Clean up save state boundary checks and comments.

 UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)

-- 
2.27.0.windows.1


             reply	other threads:[~2020-10-15 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 16:32 Mark Wilson [this message]
2020-10-15 16:32 ` [PATCH v1 1/1] UefiCpuPkg: Clean up save state boundary checks and comments Mark Wilson
2020-10-19 18:03   ` [edk2-devel] " Laszlo Ersek
2020-10-19 18:06     ` Laszlo Ersek
2020-11-11 16:20       ` Mark Wilson
2020-11-11 22:37         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015163243.364-1-Mark.Wilson@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox