Re: [PATCH edk2-platforms v1 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver

[ilias.apalodimas@linaro.org]

Hi Sughosh 

On Wed, Oct 21, 2020 at 05:05:33PM +0530, Sughosh Ganu wrote:
> +
[...]
> +#ifndef __OPTEE_RPMB_FV_
> +#define __OPTEE_RPMB_FV_
> +
> +/* SVC Args */
> +#define SP_SVC_RPMB_READ                0xC4000066
> +#define SP_SVC_RPMB_WRITE               0xC4000067
> +#define SP_SVC_GET_UART                 0xC4000068
> +
> +#define FILENAME "EFI_VARS"
> +
> +#define NBLOCKS                    (3 * 16) // EFI Vars, FTW working, FTW spare
> +#define BLOCK_SIZE                 SIZE_4KB
> +#define FLASH_SIGNATURE            SIGNATURE_32('r', 'p', 'm', 'b')
> +#define INSTANCE_FROM_FVB_THIS(a)  CR(a, MEM_INSTANCE, FvbProtocol, \
> +                                      FLASH_SIGNATURE)
> +enum _RPMB_FILE_MAP {
> +  EFI_VARS,
> +  FTW_WORK,
> +  FTW_SPARE,
> +};
> +
> +typedef enum _RPMB_FILE_MAP RPMB_FILE_MAP;
> +
> +struct _MAP_VAL_TO_FILE {
> +  CHAR8         *Filename;
> +  RPMB_FILE_MAP Map;
> +};
> +
> +typedef struct _MAP_VAL_TO_FILE MAP_VAL_TO_FILE;

_RPMB_FILE_MAP and friends was a left over from the first version of the driver,
and somehow slipped in. 
They don't affect the code at all, but we should remove them on v2. 

 
[...]

Regards
/Ilias