From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by mx.groups.io with SMTP id smtpd.web11.13631.1603294212481967012 for ; Wed, 21 Oct 2020 08:30:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=FkE5DxxC; spf=pass (domain: linaro.org, ip: 209.85.218.68, mailfrom: ilias.apalodimas@linaro.org) Received: by mail-ej1-f68.google.com with SMTP id qp15so3862779ejb.3 for ; Wed, 21 Oct 2020 08:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fw7YjijtQiREhaTKOwhwpZtXkkc85AW5mmJ5sXCeuEY=; b=FkE5DxxC63EsvUBW8Oi4ZR7QCgnJinQGU9K48n5QjckXV4apnIryDuLPJMNILsyvOA Js+oE8Kp/UB8m3stqjR2E85HYhhq8fqEL+8QXv7CFpVfzNl8s2t0nlfhV4KwdbgBNZyd kK0zwUnd6oiXnaNujTTX3AOSKO9fglT/9T6igI2/+xPszMzIAlRO9Wn9uBXamEvKgfQ4 WPmlf0Ffcq/WU8KOKiPm366EmfBOcGwek0THNMD53JbvAiODhLnWMmmweM7g0WMBrFzu jrpdsiX/CHy0471w+MV306c1uSqvvZx/OisWAwcTvlLEj1e/r4mjeRbQUqjNfUnOiIQU pW0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fw7YjijtQiREhaTKOwhwpZtXkkc85AW5mmJ5sXCeuEY=; b=Fl+wlfMFk6vv3i+cjsOoAVxmat8AgkpN4awLK/1hJrj85yLYD0DF8YthUjDSSor2Yb jPdqF69Tp/Il+bnk9OmRK6ijl2qZCxTla9R02cSLl9Z4EXHqwv36lEQjnOBZPFhOAqqF cXukw3JbWHhGs1nDcNw9qnnLRINX1t0Z2Yn2sr93HX9Uhyt9LZfHqSyjTcTNqDr1f7oT GY8Ed6Y8uLMifV17TLS+pTSSloKM6ZG2eJZSnirC+wGFkGjWQKZ6TpQsVB39EvUigrd/ NXu75VFSMZnK0Daei8gyuunkRYPyTyHZkl8JfT8wBOC5LuOjkUA/pEs9vseIHI3J8JYd Q2Fw== X-Gm-Message-State: AOAM533n+zJijVWLSFMuo3yiNuwQeDQvsvep6RLy72jGYVCMoaddBEtV caHlRHwbVmBD0HGNy38mhxOBLQ== X-Google-Smtp-Source: ABdhPJyr+VkWHjnnxd2m/P806zGFLOf2JRnsWtIqrMJDjwnCfK3wil/j/7GTH3ZB/WOa76J9MTeghw== X-Received: by 2002:a17:906:d89:: with SMTP id m9mr4274783eji.18.1603294210980; Wed, 21 Oct 2020 08:30:10 -0700 (PDT) Return-Path: Received: from apalos.home (athedsl-246545.home.otenet.gr. [85.73.10.175]) by smtp.gmail.com with ESMTPSA id b1sm2251586edr.51.2020.10.21.08.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 08:30:10 -0700 (PDT) Date: Wed, 21 Oct 2020 18:30:07 +0300 From: ilias.apalodimas@linaro.org To: Sughosh Ganu Cc: devel@edk2.groups.io, Ard Biesheuvel , Leif Lindholm Subject: Re: [PATCH edk2-platforms v1 1/2] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver Message-ID: <20201021153007.GA1921694@apalos.home> References: <20201021113534.25671-1-sughosh.ganu@linaro.org> <20201021113534.25671-2-sughosh.ganu@linaro.org> MIME-Version: 1.0 In-Reply-To: <20201021113534.25671-2-sughosh.ganu@linaro.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sughosh On Wed, Oct 21, 2020 at 05:05:33PM +0530, Sughosh Ganu wrote: > + [...] > +#ifndef __OPTEE_RPMB_FV_ > +#define __OPTEE_RPMB_FV_ > + > +/* SVC Args */ > +#define SP_SVC_RPMB_READ 0xC4000066 > +#define SP_SVC_RPMB_WRITE 0xC4000067 > +#define SP_SVC_GET_UART 0xC4000068 > + > +#define FILENAME "EFI_VARS" > + > +#define NBLOCKS (3 * 16) // EFI Vars, FTW working, FTW spare > +#define BLOCK_SIZE SIZE_4KB > +#define FLASH_SIGNATURE SIGNATURE_32('r', 'p', 'm', 'b') > +#define INSTANCE_FROM_FVB_THIS(a) CR(a, MEM_INSTANCE, FvbProtocol, \ > + FLASH_SIGNATURE) > +enum _RPMB_FILE_MAP { > + EFI_VARS, > + FTW_WORK, > + FTW_SPARE, > +}; > + > +typedef enum _RPMB_FILE_MAP RPMB_FILE_MAP; > + > +struct _MAP_VAL_TO_FILE { > + CHAR8 *Filename; > + RPMB_FILE_MAP Map; > +}; > + > +typedef struct _MAP_VAL_TO_FILE MAP_VAL_TO_FILE; _RPMB_FILE_MAP and friends was a left over from the first version of the driver, and somehow slipped in. They don't affect the code at all, but we should remove them on v2. [...] Regards /Ilias