From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.groups.io with SMTP id smtpd.web10.990.1603734483730770730 for ; Mon, 26 Oct 2020 10:48:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=E3CQ4v5N; spf=pass (domain: nuviainc.com, ip: 209.85.128.52, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f52.google.com with SMTP id e2so13400888wme.1 for ; Mon, 26 Oct 2020 10:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=A95KMLfkhJZuYwCh0SZJEda5HrFpHG9o/3FlYYZfN/c=; b=E3CQ4v5Nu2ejCB9AJGxJP32pZKDAyQ6KPoK7660YmO9xMDT1VAu4ZByDBFDrOCHI2X tMlahQkkvTBzamWOqkpJR2SYm4snBB/+8Cv/3T/+kMhZi2arzOuigm72go8/KAqiW1AF jPJGCxnd7IOekygRTI1+StlC3URUBjxuvsIZshRrRAJEyP7F5/az7vG8TkTjyyJt459P DUYNTFNC+WFsoRTd3wppHsGanTZwWWcLQ4GSnXatCVIiA+GgiWOJ+G9GCfTmLN+mBINX 2WCtL9GNfOLkx4juljXgeW2PSC490GiW9iB4w2+xipF8wGqYgw7UqJSuRemBKciYvZZb S2qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=A95KMLfkhJZuYwCh0SZJEda5HrFpHG9o/3FlYYZfN/c=; b=Tq0NpU169nL2OoXHkqlhSDIpyTJPvL0tx062TAOGemDW0cCpCSOqR304dGNk8MlBQn N59deKXlGS3z+am5d40nb7iWbKL0I2libYKdbRj7kujjDs6kyn3V+QBO1vFzdGCaBUj3 GTETcSZaOBg/ajpYODVoobNwMVeaXdEjj+wSSj8+BLrNOstMjEqND/VrjFgB9mvo7hfK B0ZGkwS0lyPO7NE96vhObYWgUpF2421QuCdQl7H4jU0jyL5JjUdAiLj9qRGzBlR+EsYs 0couxhMN0sqqjjpyygD/zm2XDZJs+a6KP1YIngwYqsZR8BMpwNXfWzqhxZdTopEwbOM2 plRg== X-Gm-Message-State: AOAM5327Htnwi5iEHcbCQ1y82gxIFCbjNB8nngT8AMruupEFEolmdPqi RVjlJGNR0RB7S5Gt79cigPEEb5qLo4bTjMEvAg3kzINqFEL1r30Ih2pXmMnuc05/hLZlhw7a4xi v+DKfLdjE3cOZEvMlN8n17KV4prD/1aZA/ArL7Rz7YjVmmtGDTVyCJTV8lhV0HjrKLA== X-Google-Smtp-Source: ABdhPJxOoGAN0GPzNJSup7K2fLLFpGCbDeJ7MpZPqV9W4qOP/A2ayJVNzGq/ET8089z7LUlqT34gXw== X-Received: by 2002:a7b:cf04:: with SMTP id l4mr17429900wmg.33.1603734478503; Mon, 26 Oct 2020 10:47:58 -0700 (PDT) Return-Path: Received: from vanye (cpc92880-cmbg19-2-0-cust79.5-4.cable.virginm.net. [82.27.104.80]) by smtp.gmail.com with ESMTPSA id t199sm22463887wmt.46.2020.10.26.10.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 10:47:57 -0700 (PDT) Date: Mon, 26 Oct 2020 17:47:55 +0000 From: "Leif Lindholm" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: rebecca@nuviainc.com, 'Michael D Kinney' , 'Zhiguang Liu' , 'Ray Ni' , 'Zhichao Gao' Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIDAvNl0gc21iaW9zdmlldyBhbmQgU21CaW9zLmggZml4ZXMsIGFkZCBTTUJJT1MgMy40LjAgQVJNNjQgU29DIElEIGRlZmluaXRpb24=?= Message-ID: <20201026174755.GG1664@vanye> References: <20201021184115.25712-1-rebecca@nuviainc.com> <009101d6a815$38ee28c0$aaca7a40$@byosoft.com.cn> <40e19891-570b-ecc2-1cee-6203b9cec06e@nuviainc.com> <003301d6ab36$bb724460$3256cd20$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <003301d6ab36$bb724460$3256cd20$@byosoft.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Liming, I agree 4/6 is invasive, but I also think industry standard headers should match the specifications they implement. If 5-6/6 do not depend on 4/6, then I agree the others can be merged first. Depending on perceived impact, perhaps 4/6 could be held back until just after next stable tag? Best Regards, Leif On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: > Rebecca: > Patch 4/6 may be safe. But, we may need more time to collect the feedback. > > > Other patches are clear. I suggest to merge them first. > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+66523+4905953+8761045@groups.io > > 代表 Rebecca Cran > > 发送时间: 2020年10月22日 10:21 > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > > 抄送: 'Michael D Kinney' ; 'Zhiguang Liu' > > ; 'Ray Ni' ; 'Zhichao Gao' > > > > 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > On 10/21/20 7:46 PM, gaoliming wrote: > > > They are the good change. But for patch 4/6, it changes the structure > > > field name. It may bring the impact to the platform code. I don't > suggest to > > > do the renaming field only for typo purpose. Other changes are good to > me. > > > > From looking at the code in edk2-platforms, it seems the common pattern > > is to use positional arguments instead of designated initializers. Of > > course there could be platforms outside of TianoCore which use the field > > names, but it looks like a relatively safe change. > > > > > > -- > > Rebecca Cran > > > > > > > > > > > > > > > > > >