From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.8362.1603766593536324021 for ; Mon, 26 Oct 2020 19:43:14 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) IronPort-SDR: D3JDPHXskjpSJg4b1gLJIoIwGpgN4sxTrgIPJGcdHHGtJjSctsobDsAypUMHGikdCTv9K7ng78 haizNUvIwBIA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="168117892" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="168117892" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 19:43:12 -0700 IronPort-SDR: 2EuUok5wiu71ciFhOzCh21cl6YpWmGIts66GRhzuvbmg8PlCAGVxuDSXihz+klniiBG0bYIINb Q1aS73+NH5Pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="350351855" Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 19:43:07 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Roger Feng , Zhiguang Liu Subject: [PATCH V2 0/7] Disable the deprecated MD5 and SHA1 support Date: Tue, 27 Oct 2020 10:42:53 +0800 Message-Id: <20201027024300.21100-1-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027 MD5 is deprecated, make it disable as default for security. It required to set MD5 enable explicitly if the module is still using MD5. List the modules that are still using it: iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config). This patch set would affact the platforms that are using iSCSI function. V2: Remove MD5 and SHA1 support of Hash2DxeCrypto. Remove the MD5 GUID defination in MdePkg.dec. SHA1 related GUIDs are still using in TPM2, so keep them. No requirement to add MD5 enable MACRO in SecurityPkg. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Roger Feng Cc: Zhiguang Liu Signed-off-by: Zhichao Gao Zhichao Gao (7): NetworkPkg/Defines: Make iSCSI disable as default NetworkPkg: Enable MD5 while enable iSCSI SecurityPkg/Hash2DxeCrypto: Remove MD5 support MdePkg/dec: Remove the MD5 GUID SecurityPkg/Hash2DxeCrypto: Remove SHA1 support CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 CryptoPkg: Make the MD5 disable as default for security CryptoPkg/CryptoPkg.dsc | 3 +++ CryptoPkg/Driver/Crypto.c | 4 ++-- CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c | 2 +- CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +- MdePkg/Include/Protocol/Hash.h | 8 +------- MdePkg/MdePkg.dec | 3 --- NetworkPkg/Network.dsc.inc | 5 +++++ NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 -- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +--- 11 files changed, 17 insertions(+), 22 deletions(-) -- 2.21.0.windows.1