public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH V2 0/7] Disable the deprecated MD5 and SHA1 support
@ 2020-10-27  2:42 Gao, Zhichao
  2020-10-27  2:42 ` [PATCH V2 1/7] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
                   ` (6 more replies)
  0 siblings, 7 replies; 16+ messages in thread
From: Gao, Zhichao @ 2020-10-27  2:42 UTC (permalink / raw)
  To: devel
  Cc: Jordan Justen, Laszlo Ersek, Ard Biesheuvel, Sami Mujawar,
	Leif Lindholm, Jiewen Yao, Jian J Wang, Xiaoyu Lu, Guomin Jiang,
	Michael D Kinney, Kelly Steele, Zailiang Sun, Yi Qian, Liming Gao,
	Maciej Rabeda, Jiaxin Wu, Siyuan Fu, Roger Feng, Zhiguang Liu

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027

MD5 is deprecated, make it disable as default for security.
It required to set MD5 enable explicitly if the module is still using 
MD5. List the modules that are still using it:
iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config).

This patch set would affact the platforms that are using iSCSI 
function.

V2:
Remove MD5 and SHA1 support of Hash2DxeCrypto.
Remove the MD5 GUID defination in MdePkg.dec. SHA1 related GUIDs
are still using in TPM2, so keep them.
No requirement to add MD5 enable MACRO in SecurityPkg.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Roger Feng <roger.feng@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>

Zhichao Gao (7):
  NetworkPkg/Defines: Make iSCSI disable as default
  NetworkPkg: Enable MD5 while enable iSCSI
  SecurityPkg/Hash2DxeCrypto: Remove MD5 support
  MdePkg/dec: Remove the MD5 GUID
  SecurityPkg/Hash2DxeCrypto: Remove SHA1 support
  CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5
  CryptoPkg: Make the MD5 disable as default for security

 CryptoPkg/CryptoPkg.dsc                                | 3 +++
 CryptoPkg/Driver/Crypto.c                              | 4 ++--
 CryptoPkg/Include/Library/BaseCryptLib.h               | 2 +-
 CryptoPkg/Library/BaseCryptLib/Hash/CryptMd5.c         | 2 +-
 CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +-
 MdePkg/Include/Protocol/Hash.h                         | 8 +-------
 MdePkg/MdePkg.dec                                      | 3 ---
 NetworkPkg/Network.dsc.inc                             | 5 +++++
 NetworkPkg/NetworkDefines.dsc.inc                      | 4 ++--
 SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c            | 2 --
 SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf          | 4 +---
 11 files changed, 17 insertions(+), 22 deletions(-)

-- 
2.21.0.windows.1


^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-11-02 15:14 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-27  2:42 [PATCH V2 0/7] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-10-27  2:42 ` [PATCH V2 1/7] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-10-27 10:47   ` Laszlo Ersek
2020-10-29  2:34     ` Gao, Zhichao
2020-11-02 15:14       ` Laszlo Ersek
2020-10-27  2:42 ` [PATCH V2 2/7] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-10-27  2:42 ` [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-10-27  2:53   ` Yao, Jiewen
2020-10-27  2:42 ` [PATCH V2 4/7] MdePkg/dec: Remove the MD5 GUID Gao, Zhichao
2020-10-30  1:20   ` 回复: [edk2-devel] " gaoliming
2020-10-27  2:42 ` [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-10-27  2:53   ` Yao, Jiewen
2020-10-27  2:42 ` [PATCH V2 6/7] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-10-27  2:53   ` Yao, Jiewen
2020-10-27  2:43 ` [PATCH V2 7/7] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao
2020-10-27  2:53   ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox