Re: [edk2-platform][PATCH 0/3] Silicon/Qemu: Use PCDs in AcpiTables.inf

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, Oct 22, 2020 at 16:50:13 +0100, Tomas Pilar wrote:
> The AcpiTable.inf library provides basic ACPI tables for the SbsaQemu
> platform. This platform aims to be the standard SBSA compliant
> platform.
> 
> This patchset generalises the AcpiTables library using the information
> provided by PCDs rather than hardcoded values. This extends the use of
> the library to other platforms that can redefine the PCDs without having
> to fork the library and change the hardcoded values.
> 
> Additional PCDs describing the upper limits of various memory map windows
> are defined as the limits are required by the ACPI tables and ASL
> syntax precludes doing the arithmetic at the compile time.
> 
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> Signed-off-by: Tomas Pilar <tomas@nuviateam.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 4472034ad3ee..968ea290aebb.

Thanks!

> --
> Tomas Pilar (3):
>   Silicon/Qemu: Renumber Dynamic PCDs to leave a gap
>   Platform,Silicon/Qemu: Define PcdPcie*Limit variables
>   Silicon/Qemu: Use PCDs to AcpiTables lib
> 
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |  6 ++
>  .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf   | 29 ++++++++++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc    |  6 +-
>  Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl     | 58 ++++++++++---------
>  Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc    |  6 +-
>  Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc    |  2 +-
>  .../Include/IndustryStandard/SbsaQemuAcpi.h   |  6 --
>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec            | 15 ++++-
>  8 files changed, 87 insertions(+), 41 deletions(-)
> 
> -- 
> 2.25.1
>