From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web08.13240.1603803151602196981 for ; Tue, 27 Oct 2020 05:52:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=DXocf4J2; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id v5so1275510wmh.1 for ; Tue, 27 Oct 2020 05:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2TYBV6kIe9FXNCHtSFD70dMEcmz8IgWDKw0seLEn1sU=; b=DXocf4J2KDwfyDKup7K4kmCBaF9F+5qFOmTlFSnsLlZ3zsvp1nreF9GaLmMeAbODcY wgU7mV8mGqFIBkrhAEav6CGHNFQ3GWgitVRu4r2gbUZzOYHmVdHcZ9N3DP1IP8u6DEz/ EZVlmzDUThNe/bV9XUOFvxVjoRmfWubk0ZcjbH21mdf/4kq51bQoDtMu6YV9WZ2Nar1N DNO9YtRi4xXn8ADZN5PUBLj9uCIePUWWOjvmuHA0Ic/swbC34FGEC/FfKwYZmrOBYu75 zWqZriWdYPOErw/GFQ5b5Zxt2IpxJV/3r4nAVaZw4YblKGq+D+x3giUwMku+Yq6GRBz7 NWBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2TYBV6kIe9FXNCHtSFD70dMEcmz8IgWDKw0seLEn1sU=; b=Td3NiU6O5cr787eYT9josYnLomfcaZ5Xk6dJtWl3harqa25wpkQB1oezvxcNS0J8X9 QOnf9TAiOuBGNKerYgHzOmY9bUFwVRtl/NVBjhdPMFuCgrknV55XvPVL38COk3rD3tU+ c7BPDw34Uv3whb1PWmvnvrnhYMGzyoMYVNAmi1k72WAxGmj3i9W/t6wqgLocQ4pXH46F blv5THd4pjshdY5+7dpftypJr2oF9WfBBFj8xDnNPY6wk9HFA3SuagYqBtKVRaXfhtrG fNA3FWtkHPYLKhVQZ+QVgXbJf//FhgsFyHEUBCrATS+vFBQuY3fRh+BeZNofcoVsqSCN K5Eg== X-Gm-Message-State: AOAM5308+INNv+Gk2muTBFCgJqTTtj2Ol01Jb4ZZbYA1FBfXGK9CBkRe 2HPxNAgB7gItkeN8ffqNB5/u7g== X-Google-Smtp-Source: ABdhPJxerbr8XXdybXE254toj+ul5ahPzXsVRCducTeI6xbpPMfNv9KWdvJ0S1e+6EK28d6dNKL7YA== X-Received: by 2002:a1c:c906:: with SMTP id f6mr2716767wmb.9.1603803150113; Tue, 27 Oct 2020 05:52:30 -0700 (PDT) Return-Path: Received: from vanye (cpc92880-cmbg19-2-0-cust79.5-4.cable.virginm.net. [82.27.104.80]) by smtp.gmail.com with ESMTPSA id g83sm1786107wmf.15.2020.10.27.05.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 05:52:29 -0700 (PDT) Date: Tue, 27 Oct 2020 12:52:27 +0000 From: "Leif Lindholm" To: Tomas Pilar Cc: devel@edk2.groups.io, Ard Biesheuvel , Tanmay Jagdale Subject: Re: [edk2-platform][PATCH 0/3] Silicon/Qemu: Use PCDs in AcpiTables.inf Message-ID: <20201027125227.GH1664@vanye> References: <20201022155016.228362-1-tomas@nuviateam.com> MIME-Version: 1.0 In-Reply-To: <20201022155016.228362-1-tomas@nuviateam.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 22, 2020 at 16:50:13 +0100, Tomas Pilar wrote: > The AcpiTable.inf library provides basic ACPI tables for the SbsaQemu > platform. This platform aims to be the standard SBSA compliant > platform. > > This patchset generalises the AcpiTables library using the information > provided by PCDs rather than hardcoded values. This extends the use of > the library to other platforms that can redefine the PCDs without having > to fork the library and change the hardcoded values. > > Additional PCDs describing the upper limits of various memory map windows > are defined as the limits are required by the ACPI tables and ASL > syntax precludes doing the arithmetic at the compile time. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Tanmay Jagdale > Signed-off-by: Tomas Pilar For the series: Reviewed-by: Leif Lindholm Pushed as 4472034ad3ee..968ea290aebb. Thanks! > -- > Tomas Pilar (3): > Silicon/Qemu: Renumber Dynamic PCDs to leave a gap > Platform,Silicon/Qemu: Define PcdPcie*Limit variables > Silicon/Qemu: Use PCDs to AcpiTables lib > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 ++ > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 29 ++++++++++ > Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc | 6 +- > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 58 ++++++++++--------- > Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 6 +- > Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc | 2 +- > .../Include/IndustryStandard/SbsaQemuAcpi.h | 6 -- > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 15 ++++- > 8 files changed, 87 insertions(+), 41 deletions(-) > > -- > 2.25.1 >