[PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[Rebecca Cran]

Fix some typos in smbiosview.

Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
and smbiosview.

Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.

Pull request: https://github.com/tianocore/edk2/pull/1052

Rebecca Cran (5):
  ShellPkg: Fix a couple of typos in smbiosview
  ShellPkg: Fix smbiosview string definition name for "boot from CD"
  ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
  MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
  MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16

 MdePkg/Include/IndustryStandard/SmBios.h      | 21 ++++++++++---------
 .../SmbiosView/PrintInfo.c                    |  2 +-
 .../SmbiosView/QueryTable.c                   |  4 ++++
 .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
 4 files changed, 18 insertions(+), 13 deletions(-)

-- 
2.26.2

[PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview

[Rebecca Cran]

Fix a couple of typos in SmbiosViewStrings.uni:
"Boot form CD" should be "Boot from CD", and "plugged from the wall"
should be "plugged into the wall".

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 .../SmbiosView/SmbiosViewStrings.uni                          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 7fbcc9a31afb..4160ca40a988 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -128,7 +128,7 @@
 #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING                 #language en-US "BIOS shadowing is allowed\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED                 #language en-US "VL-VESA is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT                   #language en-US "ESCD support is available\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED         #language en-US "Boot form CD is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED         #language en-US "Boot from CD is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED        #language en-US "Selectable Boot is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED              #language en-US "BIOS ROM is socketed\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD              #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
@@ -373,7 +373,7 @@
 #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE                 #language en-US " Not applicable\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3                     #language en-US " Reserved  \r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED         #language en-US "Power supply is unplugged from the wall\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED           #language en-US "Power supply is plugged from the wall\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED           #language en-US "Power supply is plugged into the wall\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT           #language en-US "Power supply is present\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT       #language en-US "Power supply is not present\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE           #language en-US "Power supply is hot replaceable\r\n"
-- 
2.26.2

[PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD"

[Rebecca Cran]

The "boot from CD supported" string definition name should contain the
word "from" instead of "form".

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c   | 2 +-
 .../UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 7517465ddd49..478811f0fd40 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -1284,7 +1284,7 @@ DisplayBiosCharacteristics (
   }
 
   if (BIT (Chara, 15) != 0) {
-    ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED), gShellDebug1HiiHandle);
+    ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_CD_SUPPORTED), gShellDebug1HiiHandle);
   }
 
   if (BIT (Chara, 16) != 0) {
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 4160ca40a988..b14d1cb6dac8 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -128,7 +128,7 @@
 #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING                 #language en-US "BIOS shadowing is allowed\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED                 #language en-US "VL-VESA is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT                   #language en-US "ESCD support is available\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED         #language en-US "Boot from CD is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_CD_SUPPORTED         #language en-US "Boot from CD is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED        #language en-US "Selectable Boot is supported\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED              #language en-US "BIOS ROM is socketed\r\n"
 #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD              #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
-- 
2.26.2

[PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview

[Rebecca Cran]

SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
field to be the ARM64 SoC ID support. Add support for it to the
smbiosview command.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c        | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 17a2a89d512e..d0796a0e5141 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -624,6 +624,10 @@ TABLE_ITEM  ProcessorCharacteristicsTable[] = {
   {
     8,
     L" 128-bit Capable"
+  },
+  {
+    9,
+    L" ARM64 SoC ID"
   }
 };
 
-- 
2.26.2

[PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field

[Rebecca Cran]

SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
field to be the ARM64 SoC ID support. Add it to the
PROCESSOR_CHARACTERISTIC_FLAGS struct bitfield.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index f2db11f947d1..c495c48f3b47 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -871,7 +871,8 @@ typedef struct {
   UINT32  ProcessorEnhancedVirtulization :1;
   UINT32  ProcessorPowerPerformanceCtrl  :1;
   UINT32  Processor128bitCapble          :1;
-  UINT32  ProcessorReserved2             :7;
+  UINT32  ProcessorArm64SocId            :1;
+  UINT32  ProcessorReserved2             :6;
 } PROCESSOR_CHARACTERISTIC_FLAGS;
 
 typedef struct {
-- 
2.26.2

[PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16

[Rebecca Cran]

The ProcessorCharacteristics is a UINT16 field, so the
PROCESSOR_CHARACTERISTIC_FLAGS bitfield should be UINT16 too.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index c495c48f3b47..1ee01645679a 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -862,17 +862,17 @@ typedef struct {
 } PROCESSOR_FEATURE_FLAGS;
 
 typedef struct {
-  UINT32  ProcessorReserved1             :1;
-  UINT32  ProcessorUnknown               :1;
-  UINT32  Processor64BitCapble           :1;
-  UINT32  ProcessorMultiCore             :1;
-  UINT32  ProcessorHardwareThread        :1;
-  UINT32  ProcessorExecuteProtection     :1;
-  UINT32  ProcessorEnhancedVirtulization :1;
-  UINT32  ProcessorPowerPerformanceCtrl  :1;
-  UINT32  Processor128bitCapble          :1;
-  UINT32  ProcessorArm64SocId            :1;
-  UINT32  ProcessorReserved2             :6;
+  UINT16  ProcessorReserved1             :1;
+  UINT16  ProcessorUnknown               :1;
+  UINT16  Processor64BitCapble           :1;
+  UINT16  ProcessorMultiCore             :1;
+  UINT16  ProcessorHardwareThread        :1;
+  UINT16  ProcessorExecuteProtection     :1;
+  UINT16  ProcessorEnhancedVirtulization :1;
+  UINT16  ProcessorPowerPerformanceCtrl  :1;
+  UINT16  Processor128bitCapble          :1;
+  UINT16  ProcessorArm64SocId            :1;
+  UINT16  ProcessorReserved2             :6;
 } PROCESSOR_CHARACTERISTIC_FLAGS;
 
 typedef struct {
-- 
2.26.2

回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[gaoliming]

Rebecca:
  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年10月28日 1:29
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao
> Gao <zhichao.gao@intel.com>
> 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
> 
> Fix some typos in smbiosview.
> 
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and smbiosview.
> 
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
> 
> Pull request: https://github.com/tianocore/edk2/pull/1052
> 
> Rebecca Cran (5):
>   ShellPkg: Fix a couple of typos in smbiosview
>   ShellPkg: Fix smbiosview string definition name for "boot from CD"
>   ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>   MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>   MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 21
> ++++++++++---------
>  .../SmbiosView/PrintInfo.c                    |  2 +-
>  .../SmbiosView/QueryTable.c                   |  4 ++++
>  .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>  4 files changed, 18 insertions(+), 13 deletions(-)
> 
> --
> 2.26.2

Re: [edk2-devel] 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[Rebecca Cran]

Thanks!

On 10/27/20 6:56 PM, gaoliming wrote:
> Rebecca:
>    Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: Rebecca Cran <rebecca@nuviainc.com>
>> 发送时间: 2020年10月28日 1:29
>> 收件人: devel@edk2.groups.io
>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao
>> Gao <zhichao.gao@intel.com>
>> 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
>> ARM64 SoC ID definition
>>
>> Fix some typos in smbiosview.
>>
>> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
>> and smbiosview.
>>
>> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>>
>> Pull request: https://github.com/tianocore/edk2/pull/1052
>>
>> Rebecca Cran (5):
>>    ShellPkg: Fix a couple of typos in smbiosview
>>    ShellPkg: Fix smbiosview string definition name for "boot from CD"
>>    ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>>    MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>>    MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>>
>>   MdePkg/Include/IndustryStandard/SmBios.h      | 21
>> ++++++++++---------
>>   .../SmbiosView/PrintInfo.c                    |  2 +-
>>   .../SmbiosView/QueryTable.c                   |  4 ++++
>>   .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>>   4 files changed, 18 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
>
>
>
>
> 
>
>

Re: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0
> ARM64 SoC ID field
> 
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics field
> to be the ARM64 SoC ID support. Add it to the
> PROCESSOR_CHARACTERISTIC_FLAGS struct bitfield.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index f2db11f947d1..c495c48f3b47 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -871,7 +871,8 @@ typedef struct {
>    UINT32  ProcessorEnhancedVirtulization :1;
>    UINT32  ProcessorPowerPerformanceCtrl  :1;
>    UINT32  Processor128bitCapble          :1;
> -  UINT32  ProcessorReserved2             :7;
> +  UINT32  ProcessorArm64SocId            :1;
> +  UINT32  ProcessorReserved2             :6;
>  } PROCESSOR_CHARACTERISTIC_FLAGS;
> 
>  typedef struct {
> --
> 2.26.2

Re: [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16

[Zhiguang Liu]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 5/5] MdePkg: Fix SmBios.h
> PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
> 
> The ProcessorCharacteristics is a UINT16 field, so the
> PROCESSOR_CHARACTERISTIC_FLAGS bitfield should be UINT16 too.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c495c48f3b47..1ee01645679a 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -862,17 +862,17 @@ typedef struct {
>  } PROCESSOR_FEATURE_FLAGS;
> 
>  typedef struct {
> -  UINT32  ProcessorReserved1             :1;
> -  UINT32  ProcessorUnknown               :1;
> -  UINT32  Processor64BitCapble           :1;
> -  UINT32  ProcessorMultiCore             :1;
> -  UINT32  ProcessorHardwareThread        :1;
> -  UINT32  ProcessorExecuteProtection     :1;
> -  UINT32  ProcessorEnhancedVirtulization :1;
> -  UINT32  ProcessorPowerPerformanceCtrl  :1;
> -  UINT32  Processor128bitCapble          :1;
> -  UINT32  ProcessorArm64SocId            :1;
> -  UINT32  ProcessorReserved2             :6;
> +  UINT16  ProcessorReserved1             :1;
> +  UINT16  ProcessorUnknown               :1;
> +  UINT16  Processor64BitCapble           :1;
> +  UINT16  ProcessorMultiCore             :1;
> +  UINT16  ProcessorHardwareThread        :1;
> +  UINT16  ProcessorExecuteProtection     :1;
> +  UINT16  ProcessorEnhancedVirtulization :1;
> +  UINT16  ProcessorPowerPerformanceCtrl  :1;
> +  UINT16  Processor128bitCapble          :1;
> +  UINT16  ProcessorArm64SocId            :1;
> +  UINT16  ProcessorReserved2             :6;
>  } PROCESSOR_CHARACTERISTIC_FLAGS;
> 
>  typedef struct {
> --
> 2.26.2

Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[Gao, Zhichao]

The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:29 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
> 
> Fix some typos in smbiosview.
> 
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
> smbiosview.
> 
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
> 
> Pull request: https://github.com/tianocore/edk2/pull/1052
> 
> Rebecca Cran (5):
>   ShellPkg: Fix a couple of typos in smbiosview
>   ShellPkg: Fix smbiosview string definition name for "boot from CD"
>   ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>   MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>   MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
> 
>  MdePkg/Include/IndustryStandard/SmBios.h      | 21 ++++++++++---------
>  .../SmbiosView/PrintInfo.c                    |  2 +-
>  .../SmbiosView/QueryTable.c                   |  4 ++++
>  .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>  4 files changed, 18 insertions(+), 13 deletions(-)
> 
> --
> 2.26.2

回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[gaoliming]

PR https://github.com/tianocore/edk2/pull/1058 is created. 

> -----邮件原件-----
> 发件人: Gao, Zhichao <zhichao.gao@intel.com>
> 发送时间: 2020年10月30日 9:08
> 收件人: Rebecca Cran <rebecca@nuviainc.com>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> 主题: RE: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
> 
> The patch 1-4 are same with V1. If there is no change with previous
patches
> and the patches are already reviewed. You should add the Reviewed-by for
> the reviewed patches. That would avoid Maintainers/Reviewers to review the
> patches again. And it is suggested to add the change info in the
cover-letter.
> Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao
> <zhichao.gao@intel.com>
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: Rebecca Cran <rebecca@nuviainc.com>
> > Sent: Wednesday, October 28, 2020 1:29 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu,
> > Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao
> > <zhichao.gao@intel.com>
> > Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> > ARM64 SoC ID definition
> >
> > Fix some typos in smbiosview.
> >
> > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and
> > smbiosview.
> >
> > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
> >
> > Pull request: https://github.com/tianocore/edk2/pull/1052
> >
> > Rebecca Cran (5):
> >   ShellPkg: Fix a couple of typos in smbiosview
> >   ShellPkg: Fix smbiosview string definition name for "boot from CD"
> >   ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> >   MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> >   MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be
> UINT16
> >
> >  MdePkg/Include/IndustryStandard/SmBios.h      | 21
> ++++++++++---------
> >  .../SmbiosView/PrintInfo.c                    |  2 +-
> >  .../SmbiosView/QueryTable.c                   |  4 ++++
> >  .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
> >  4 files changed, 18 insertions(+), 13 deletions(-)
> >
> > --
> > 2.26.2

Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition

[Rebecca Cran]

Thanks - I'll try and remember to do that in future.


-- 
Rebecca Cran


On 10/29/20 7:08 PM, Gao, Zhichao wrote:
> The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
> Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@nuviainc.com>
>> Sent: Wednesday, October 28, 2020 1:29 AM
>> To: devel@edk2.groups.io
>> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
>> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
>> <zhichao.gao@intel.com>
>> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
>> ARM64 SoC ID definition
>>
>> Fix some typos in smbiosview.
>>
>> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
>> smbiosview.
>>
>> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>>
>> Pull request: https://github.com/tianocore/edk2/pull/1052
>>
>> Rebecca Cran (5):
>>    ShellPkg: Fix a couple of typos in smbiosview
>>    ShellPkg: Fix smbiosview string definition name for "boot from CD"
>>    ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>>    MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>>    MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>>
>>   MdePkg/Include/IndustryStandard/SmBios.h      | 21 ++++++++++---------
>>   .../SmbiosView/PrintInfo.c                    |  2 +-
>>   .../SmbiosView/QueryTable.c                   |  4 ++++
>>   .../SmbiosView/SmbiosViewStrings.uni          |  4 ++--
>>   4 files changed, 18 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2