* [PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
@ 2020-10-27 17:29 ` Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
` (5 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Rebecca Cran @ 2020-10-27 17:29 UTC (permalink / raw)
To: devel
Cc: Rebecca Cran, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni,
Zhichao Gao
Fix a couple of typos in SmbiosViewStrings.uni:
"Boot form CD" should be "Boot from CD", and "plugged from the wall"
should be "plugged into the wall".
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
.../SmbiosView/SmbiosViewStrings.uni | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 7fbcc9a31afb..4160ca40a988 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -128,7 +128,7 @@
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING #language en-US "BIOS shadowing is allowed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED #language en-US "VL-VESA is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #language en-US "ESCD support is available\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED #language en-US "Boot form CD is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED #language en-US "Boot from CD is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED #language en-US "Selectable Boot is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED #language en-US "BIOS ROM is socketed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
@@ -373,7 +373,7 @@
#string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE #language en-US " Not applicable\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3 #language en-US " Reserved \r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED #language en-US "Power supply is unplugged from the wall\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED #language en-US "Power supply is plugged from the wall\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED #language en-US "Power supply is plugged into the wall\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT #language en-US "Power supply is present\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT #language en-US "Power supply is not present\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE #language en-US "Power supply is hot replaceable\r\n"
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD"
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
@ 2020-10-27 17:29 ` Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Rebecca Cran @ 2020-10-27 17:29 UTC (permalink / raw)
To: devel
Cc: Rebecca Cran, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni,
Zhichao Gao
The "boot from CD supported" string definition name should contain the
word "from" instead of "form".
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
.../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +-
.../UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 7517465ddd49..478811f0fd40 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -1284,7 +1284,7 @@ DisplayBiosCharacteristics (
}
if (BIT (Chara, 15) != 0) {
- ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED), gShellDebug1HiiHandle);
+ ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_CD_SUPPORTED), gShellDebug1HiiHandle);
}
if (BIT (Chara, 16) != 0) {
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 4160ca40a988..b14d1cb6dac8 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -128,7 +128,7 @@
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING #language en-US "BIOS shadowing is allowed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED #language en-US "VL-VESA is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT #language en-US "ESCD support is available\r\n"
-#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED #language en-US "Boot from CD is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_CD_SUPPORTED #language en-US "Boot from CD is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED #language en-US "Selectable Boot is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED #language en-US "BIOS ROM is socketed\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
@ 2020-10-27 17:29 ` Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Rebecca Cran @ 2020-10-27 17:29 UTC (permalink / raw)
To: devel
Cc: Rebecca Cran, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni,
Zhichao Gao
SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
field to be the ARM64 SoC ID support. Add support for it to the
smbiosview command.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
.../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 17a2a89d512e..d0796a0e5141 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -624,6 +624,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = {
{
8,
L" 128-bit Capable"
+ },
+ {
+ 9,
+ L" ARM64 SoC ID"
}
};
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
` (2 preceding siblings ...)
2020-10-27 17:29 ` [PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
@ 2020-10-27 17:29 ` Rebecca Cran
2020-10-28 5:05 ` Zhiguang Liu
2020-10-27 17:29 ` [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 Rebecca Cran
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Rebecca Cran @ 2020-10-27 17:29 UTC (permalink / raw)
To: devel
Cc: Rebecca Cran, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni,
Zhichao Gao
SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics
field to be the ARM64 SoC ID support. Add it to the
PROCESSOR_CHARACTERISTIC_FLAGS struct bitfield.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index f2db11f947d1..c495c48f3b47 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -871,7 +871,8 @@ typedef struct {
UINT32 ProcessorEnhancedVirtulization :1;
UINT32 ProcessorPowerPerformanceCtrl :1;
UINT32 Processor128bitCapble :1;
- UINT32 ProcessorReserved2 :7;
+ UINT32 ProcessorArm64SocId :1;
+ UINT32 ProcessorReserved2 :6;
} PROCESSOR_CHARACTERISTIC_FLAGS;
typedef struct {
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
2020-10-27 17:29 ` [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
@ 2020-10-28 5:05 ` Zhiguang Liu
0 siblings, 0 replies; 13+ messages in thread
From: Zhiguang Liu @ 2020-10-28 5:05 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io
Cc: Kinney, Michael D, Liming Gao, Ni, Ray, Gao, Zhichao
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0
> ARM64 SoC ID field
>
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics field
> to be the ARM64 SoC ID support. Add it to the
> PROCESSOR_CHARACTERISTIC_FLAGS struct bitfield.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index f2db11f947d1..c495c48f3b47 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -871,7 +871,8 @@ typedef struct {
> UINT32 ProcessorEnhancedVirtulization :1;
> UINT32 ProcessorPowerPerformanceCtrl :1;
> UINT32 Processor128bitCapble :1;
> - UINT32 ProcessorReserved2 :7;
> + UINT32 ProcessorArm64SocId :1;
> + UINT32 ProcessorReserved2 :6;
> } PROCESSOR_CHARACTERISTIC_FLAGS;
>
> typedef struct {
> --
> 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
` (3 preceding siblings ...)
2020-10-27 17:29 ` [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
@ 2020-10-27 17:29 ` Rebecca Cran
2020-10-28 5:05 ` Zhiguang Liu
2020-10-28 0:56 ` 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
2020-10-30 1:08 ` Gao, Zhichao
6 siblings, 1 reply; 13+ messages in thread
From: Rebecca Cran @ 2020-10-27 17:29 UTC (permalink / raw)
To: devel
Cc: Rebecca Cran, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni,
Zhichao Gao
The ProcessorCharacteristics is a UINT16 field, so the
PROCESSOR_CHARACTERISTIC_FLAGS bitfield should be UINT16 too.
Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
MdePkg/Include/IndustryStandard/SmBios.h | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index c495c48f3b47..1ee01645679a 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -862,17 +862,17 @@ typedef struct {
} PROCESSOR_FEATURE_FLAGS;
typedef struct {
- UINT32 ProcessorReserved1 :1;
- UINT32 ProcessorUnknown :1;
- UINT32 Processor64BitCapble :1;
- UINT32 ProcessorMultiCore :1;
- UINT32 ProcessorHardwareThread :1;
- UINT32 ProcessorExecuteProtection :1;
- UINT32 ProcessorEnhancedVirtulization :1;
- UINT32 ProcessorPowerPerformanceCtrl :1;
- UINT32 Processor128bitCapble :1;
- UINT32 ProcessorArm64SocId :1;
- UINT32 ProcessorReserved2 :6;
+ UINT16 ProcessorReserved1 :1;
+ UINT16 ProcessorUnknown :1;
+ UINT16 Processor64BitCapble :1;
+ UINT16 ProcessorMultiCore :1;
+ UINT16 ProcessorHardwareThread :1;
+ UINT16 ProcessorExecuteProtection :1;
+ UINT16 ProcessorEnhancedVirtulization :1;
+ UINT16 ProcessorPowerPerformanceCtrl :1;
+ UINT16 Processor128bitCapble :1;
+ UINT16 ProcessorArm64SocId :1;
+ UINT16 ProcessorReserved2 :6;
} PROCESSOR_CHARACTERISTIC_FLAGS;
typedef struct {
--
2.26.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
2020-10-27 17:29 ` [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 Rebecca Cran
@ 2020-10-28 5:05 ` Zhiguang Liu
0 siblings, 0 replies; 13+ messages in thread
From: Zhiguang Liu @ 2020-10-28 5:05 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io
Cc: Kinney, Michael D, Liming Gao, Ni, Ray, Gao, Zhichao
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 5/5] MdePkg: Fix SmBios.h
> PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>
> The ProcessorCharacteristics is a UINT16 field, so the
> PROCESSOR_CHARACTERISTIC_FLAGS bitfield should be UINT16 too.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c495c48f3b47..1ee01645679a 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -862,17 +862,17 @@ typedef struct {
> } PROCESSOR_FEATURE_FLAGS;
>
> typedef struct {
> - UINT32 ProcessorReserved1 :1;
> - UINT32 ProcessorUnknown :1;
> - UINT32 Processor64BitCapble :1;
> - UINT32 ProcessorMultiCore :1;
> - UINT32 ProcessorHardwareThread :1;
> - UINT32 ProcessorExecuteProtection :1;
> - UINT32 ProcessorEnhancedVirtulization :1;
> - UINT32 ProcessorPowerPerformanceCtrl :1;
> - UINT32 Processor128bitCapble :1;
> - UINT32 ProcessorArm64SocId :1;
> - UINT32 ProcessorReserved2 :6;
> + UINT16 ProcessorReserved1 :1;
> + UINT16 ProcessorUnknown :1;
> + UINT16 Processor64BitCapble :1;
> + UINT16 ProcessorMultiCore :1;
> + UINT16 ProcessorHardwareThread :1;
> + UINT16 ProcessorExecuteProtection :1;
> + UINT16 ProcessorEnhancedVirtulization :1;
> + UINT16 ProcessorPowerPerformanceCtrl :1;
> + UINT16 Processor128bitCapble :1;
> + UINT16 ProcessorArm64SocId :1;
> + UINT16 ProcessorReserved2 :6;
> } PROCESSOR_CHARACTERISTIC_FLAGS;
>
> typedef struct {
> --
> 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread
* 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
` (4 preceding siblings ...)
2020-10-27 17:29 ` [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 Rebecca Cran
@ 2020-10-28 0:56 ` gaoliming
2020-10-28 1:27 ` [edk2-devel] " Rebecca Cran
2020-10-30 1:08 ` Gao, Zhichao
6 siblings, 1 reply; 13+ messages in thread
From: gaoliming @ 2020-10-28 0:56 UTC (permalink / raw)
To: 'Rebecca Cran', devel
Cc: 'Michael D Kinney', 'Zhiguang Liu',
'Ray Ni', 'Zhichao Gao'
Rebecca:
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set.
Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年10月28日 1:29
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao
> Gao <zhichao.gao@intel.com>
> 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
>
> Fix some typos in smbiosview.
>
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and smbiosview.
>
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>
> Pull request: https://github.com/tianocore/edk2/pull/1052
>
> Rebecca Cran (5):
> ShellPkg: Fix a couple of typos in smbiosview
> ShellPkg: Fix smbiosview string definition name for "boot from CD"
> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>
> MdePkg/Include/IndustryStandard/SmBios.h | 21
> ++++++++++---------
> .../SmbiosView/PrintInfo.c | 2 +-
> .../SmbiosView/QueryTable.c | 4 ++++
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 4 files changed, 18 insertions(+), 13 deletions(-)
>
> --
> 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [edk2-devel] 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
2020-10-28 0:56 ` 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
@ 2020-10-28 1:27 ` Rebecca Cran
0 siblings, 0 replies; 13+ messages in thread
From: Rebecca Cran @ 2020-10-28 1:27 UTC (permalink / raw)
To: devel, gaoliming
Cc: 'Michael D Kinney', 'Zhiguang Liu',
'Ray Ni', 'Zhichao Gao'
Thanks!
On 10/27/20 6:56 PM, gaoliming wrote:
> Rebecca:
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set.
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: Rebecca Cran <rebecca@nuviainc.com>
>> 发送时间: 2020年10月28日 1:29
>> 收件人: devel@edk2.groups.io
>> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao
>> Gao <zhichao.gao@intel.com>
>> 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
>> ARM64 SoC ID definition
>>
>> Fix some typos in smbiosview.
>>
>> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
>> and smbiosview.
>>
>> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>>
>> Pull request: https://github.com/tianocore/edk2/pull/1052
>>
>> Rebecca Cran (5):
>> ShellPkg: Fix a couple of typos in smbiosview
>> ShellPkg: Fix smbiosview string definition name for "boot from CD"
>> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>>
>> MdePkg/Include/IndustryStandard/SmBios.h | 21
>> ++++++++++---------
>> .../SmbiosView/PrintInfo.c | 2 +-
>> .../SmbiosView/QueryTable.c | 4 ++++
>> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
>> 4 files changed, 18 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
` (5 preceding siblings ...)
2020-10-28 0:56 ` 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
@ 2020-10-30 1:08 ` Gao, Zhichao
2020-10-30 1:14 ` 回复: " gaoliming
2020-10-30 13:28 ` Rebecca Cran
6 siblings, 2 replies; 13+ messages in thread
From: Gao, Zhichao @ 2020-10-30 1:08 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io
Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Ni, Ray
The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:29 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
>
> Fix some typos in smbiosview.
>
> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
> smbiosview.
>
> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>
> Pull request: https://github.com/tianocore/edk2/pull/1052
>
> Rebecca Cran (5):
> ShellPkg: Fix a couple of typos in smbiosview
> ShellPkg: Fix smbiosview string definition name for "boot from CD"
> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>
> MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++---------
> .../SmbiosView/PrintInfo.c | 2 +-
> .../SmbiosView/QueryTable.c | 4 ++++
> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> 4 files changed, 18 insertions(+), 13 deletions(-)
>
> --
> 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread* 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
2020-10-30 1:08 ` Gao, Zhichao
@ 2020-10-30 1:14 ` gaoliming
2020-10-30 13:28 ` Rebecca Cran
1 sibling, 0 replies; 13+ messages in thread
From: gaoliming @ 2020-10-30 1:14 UTC (permalink / raw)
To: 'Gao, Zhichao', 'Rebecca Cran', devel
Cc: 'Kinney, Michael D', 'Liu, Zhiguang',
'Ni, Ray'
PR https://github.com/tianocore/edk2/pull/1058 is created.
> -----邮件原件-----
> 发件人: Gao, Zhichao <zhichao.gao@intel.com>
> 发送时间: 2020年10月30日 9:08
> 收件人: Rebecca Cran <rebecca@nuviainc.com>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> 主题: RE: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> ARM64 SoC ID definition
>
> The patch 1-4 are same with V1. If there is no change with previous
patches
> and the patches are already reviewed. You should add the Reviewed-by for
> the reviewed patches. That would avoid Maintainers/Reviewers to review the
> patches again. And it is suggested to add the change info in the
cover-letter.
> Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao
> <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
> > -----Original Message-----
> > From: Rebecca Cran <rebecca@nuviainc.com>
> > Sent: Wednesday, October 28, 2020 1:29 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu,
> > Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao
> > <zhichao.gao@intel.com>
> > Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
> > ARM64 SoC ID definition
> >
> > Fix some typos in smbiosview.
> >
> > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h
> and
> > smbiosview.
> >
> > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
> >
> > Pull request: https://github.com/tianocore/edk2/pull/1052
> >
> > Rebecca Cran (5):
> > ShellPkg: Fix a couple of typos in smbiosview
> > ShellPkg: Fix smbiosview string definition name for "boot from CD"
> > ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
> > MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
> > MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be
> UINT16
> >
> > MdePkg/Include/IndustryStandard/SmBios.h | 21
> ++++++++++---------
> > .../SmbiosView/PrintInfo.c | 2 +-
> > .../SmbiosView/QueryTable.c | 4 ++++
> > .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
> > 4 files changed, 18 insertions(+), 13 deletions(-)
> >
> > --
> > 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition
2020-10-30 1:08 ` Gao, Zhichao
2020-10-30 1:14 ` 回复: " gaoliming
@ 2020-10-30 13:28 ` Rebecca Cran
1 sibling, 0 replies; 13+ messages in thread
From: Rebecca Cran @ 2020-10-30 13:28 UTC (permalink / raw)
To: Gao, Zhichao, devel@edk2.groups.io
Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Ni, Ray
Thanks - I'll try and remember to do that in future.
--
Rebecca Cran
On 10/29/20 7:08 PM, Gao, Zhichao wrote:
> The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter.
> Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Thanks,
> Zhichao
>
>> -----Original Message-----
>> From: Rebecca Cran <rebecca@nuviainc.com>
>> Sent: Wednesday, October 28, 2020 1:29 AM
>> To: devel@edk2.groups.io
>> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
>> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
>> <zhichao.gao@intel.com>
>> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0
>> ARM64 SoC ID definition
>>
>> Fix some typos in smbiosview.
>>
>> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and
>> smbiosview.
>>
>> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield.
>>
>> Pull request: https://github.com/tianocore/edk2/pull/1052
>>
>> Rebecca Cran (5):
>> ShellPkg: Fix a couple of typos in smbiosview
>> ShellPkg: Fix smbiosview string definition name for "boot from CD"
>> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview
>> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
>> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
>>
>> MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++---------
>> .../SmbiosView/PrintInfo.c | 2 +-
>> .../SmbiosView/QueryTable.c | 4 ++++
>> .../SmbiosView/SmbiosViewStrings.uni | 4 ++--
>> 4 files changed, 18 insertions(+), 13 deletions(-)
>>
>> --
>> 2.26.2
^ permalink raw reply [flat|nested] 13+ messages in thread