public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zurcher, Christopher J" <christopher.j.zurcher@intel.com>
To: devel@edk2.groups.io
Cc: Jiewen Yao <jiewen.yao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Xiaoyu Lu <xiaoyux.lu@intel.com>,
	Guomin Jiang <guomin.jiang@intel.com>,
	Sung-Uk Bin <sunguk-bin@hp.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH 0/1] CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c
Date: Wed, 28 Oct 2020 11:42:53 -0700	[thread overview]
Message-ID: <20201028184254.6923-1-christopher.j.zurcher@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507

This patch provides a drop-in replacement for CryptAes.c which utilizes
the EVP interface to OpenSSL. This enables access to the assembly-optimized
algorithms.

This patch has been unit-tested in both VS and CLANG build environments
using both an X64 assembly-optimized implementation of OpensslLib and the
standard implementation.

Usage of this file does not require an assembly-optimized implementation of
OpensslLib to function; it does however require one to provide a speed
improvement.

The C-only AES implementation included by CryptAes.c is extremely small,
and since this file includes the EVP interface, it will significantly
increase the size of any module that includes it. As a result, I have not
replaced the original CryptAes.c as a default in any of the CryptLib
implementations.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Sung-Uk Bin <sunguk-bin@hp.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>

Christopher J Zurcher (1):
  CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c

 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c | 262 ++++++++++++++++++++
 1 file changed, 262 insertions(+)
 create mode 100644 CryptoPkg/Library/BaseCryptLib/Cipher/CryptAesEvp.c

-- 
2.28.0.windows.1


             reply	other threads:[~2020-10-28 18:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 18:42 Zurcher, Christopher J [this message]
2020-10-28 18:42 ` [PATCH 1/1] CryptoPkg/BaseCryptLib: Add EVP implementation for CryptAes.c Zurcher, Christopher J
2020-10-31  1:10 ` [PATCH 0/1] " Yao, Jiewen
2020-11-02 22:36   ` Zurcher, Christopher J
2020-11-03  1:13     ` Yao, Jiewen
2020-11-03  1:22       ` Bret Barkelew
2020-11-03 21:54         ` Zurcher, Christopher J
2020-11-03 23:03           ` Yao, Jiewen
2020-11-03  7:51     ` Ard Biesheuvel
2020-11-03 19:15       ` Zurcher, Christopher J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201028184254.6923-1-christopher.j.zurcher@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox