* [PATCH v2 0/2] Add image type into generate map file
@ 2020-10-30 3:39 fengyunhua
2020-10-30 3:39 ` [PATCH v2 1/2] BaseTools: " fengyunhua
2020-10-30 3:39 ` [PATCH v2 2/2] BaseTools: update report map file format fengyunhua
0 siblings, 2 replies; 9+ messages in thread
From: fengyunhua @ 2020-10-30 3:39 UTC (permalink / raw)
To: devel
v2:
Correct re compile pattern string
v1:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2977
For a source-level BIOS debugger the .map files are quite useful with one
major shortcoming: the debugger cannot know, solely from the .map file,
the format (PE/COFF vs. TE) of the image included in the final BIOS ROM
Yunhua Feng (2):
BaseTools: Add image type into generate map file
BaseTools: update report map file format
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 7 ++++++-
BaseTools/Source/Python/build/BuildReport.py | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] BaseTools: Add image type into generate map file
2020-10-30 3:39 [PATCH v2 0/2] Add image type into generate map file fengyunhua
@ 2020-10-30 3:39 ` fengyunhua
2020-11-09 6:16 ` Bob Feng
2020-10-30 3:39 ` [PATCH v2 2/2] BaseTools: update report map file format fengyunhua
1 sibling, 1 reply; 9+ messages in thread
From: fengyunhua @ 2020-10-30 3:39 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2977
For a source-level BIOS debugger the .map files are quite useful with one
major shortcoming: the debugger cannot know, solely from the .map file,
the format (PE/COFF vs. TE) of the image included in the final BIOS ROM
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
index b5ffed93a9..6e296b8ad6 100644
--- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
+++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
@@ -903,7 +903,12 @@ Returns:
fprintf (FvMapFile, "BaseAddress=0x%010llx, ", (unsigned long long) (ImageBaseAddress + Offset));
}
- fprintf (FvMapFile, "EntryPoint=0x%010llx", (unsigned long long) (ImageBaseAddress + AddressOfEntryPoint));
+ fprintf (FvMapFile, "EntryPoint=0x%010llx, ", (unsigned long long) (ImageBaseAddress + AddressOfEntryPoint));
+ if (!pImageContext->IsTeImage) {
+ fprintf (FvMapFile, "Type=PE");
+ } else {
+ fprintf (FvMapFile, "Type=TE");
+ }
fprintf (FvMapFile, ")\n");
fprintf (FvMapFile, "(GUID=%s", FileGuidName);
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] BaseTools: update report map file format
2020-10-30 3:39 [PATCH v2 0/2] Add image type into generate map file fengyunhua
2020-10-30 3:39 ` [PATCH v2 1/2] BaseTools: " fengyunhua
@ 2020-10-30 3:39 ` fengyunhua
2020-11-09 6:14 ` Bob Feng
1 sibling, 1 reply; 9+ messages in thread
From: fengyunhua @ 2020-10-30 3:39 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Liming Gao, Yuwei Chen
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file
-gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] BaseTools: update report map file format
2020-10-30 3:39 ` [PATCH v2 2/2] BaseTools: update report map file format fengyunhua
@ 2020-11-09 6:14 ` Bob Feng
2020-11-09 6:38 ` 回复: [edk2-devel] " fengyunhua
0 siblings, 1 reply; 9+ messages in thread
From: Bob Feng @ 2020-11-09 6:14 UTC (permalink / raw)
To: Yunhua Feng, devel@edk2.groups.io; +Cc: Liming Gao, Chen, Christine
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" : "(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] BaseTools: Add image type into generate map file
2020-10-30 3:39 ` [PATCH v2 1/2] BaseTools: " fengyunhua
@ 2020-11-09 6:16 ` Bob Feng
0 siblings, 0 replies; 9+ messages in thread
From: Bob Feng @ 2020-11-09 6:16 UTC (permalink / raw)
To: Yunhua Feng, devel@edk2.groups.io; +Cc: Liming Gao, Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 1/2] BaseTools: Add image type into generate map file
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2977
For a source-level BIOS debugger the .map files are quite useful with one major shortcoming: the debugger cannot know, solely from the .map file, the format (PE/COFF vs. TE) of the image included in the final BIOS ROM
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
index b5ffed93a9..6e296b8ad6 100644
--- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
+++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
@@ -903,7 +903,12 @@ Returns:
fprintf (FvMapFile, "BaseAddress=0x%010llx, ", (unsigned long long) (ImageBaseAddress + Offset));
}
- fprintf (FvMapFile, "EntryPoint=0x%010llx", (unsigned long long) (ImageBaseAddress + AddressOfEntryPoint));
+ fprintf (FvMapFile, "EntryPoint=0x%010llx, ", (unsigned long long)
+ (ImageBaseAddress + AddressOfEntryPoint)); if (!pImageContext->IsTeImage) {
+ fprintf (FvMapFile, "Type=PE");
+ } else {
+ fprintf (FvMapFile, "Type=TE");
+ }
fprintf (FvMapFile, ")\n");
fprintf (FvMapFile, "(GUID=%s", FileGuidName);
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
2020-11-09 6:14 ` Bob Feng
@ 2020-11-09 6:38 ` fengyunhua
2020-11-09 7:09 ` Bob Feng
0 siblings, 1 reply; 9+ messages in thread
From: fengyunhua @ 2020-11-09 6:38 UTC (permalink / raw)
To: devel, bob.c.feng; +Cc: 'Liming Gao', 'Chen, Christine'
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression
pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine
<yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file
format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map
file -gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
2020-11-09 6:38 ` 回复: [edk2-devel] " fengyunhua
@ 2020-11-09 7:09 ` Bob Feng
2020-11-09 8:11 ` 回复: " fengyunhua
0 siblings, 1 reply; 9+ messages in thread
From: Bob Feng @ 2020-11-09 7:09 UTC (permalink / raw)
To: devel@edk2.groups.io, fengyunhua@byosoft.com.cn
Cc: 'Liming Gao', Chen, Christine
Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history.
So I think each of the patches need to have a complete description. There should be some necessary context info about this patch.
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua
Sent: Monday, November 9, 2020 2:39 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
2020-11-09 7:09 ` Bob Feng
@ 2020-11-09 8:11 ` fengyunhua
2020-11-10 4:19 ` Bob Feng
0 siblings, 1 reply; 9+ messages in thread
From: fengyunhua @ 2020-11-09 8:11 UTC (permalink / raw)
To: devel, bob.c.feng; +Cc: 'Liming Gao', 'Chen, Christine'
Ok, I have updated commit message with v3
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67162+5049190+8953120@groups.io <bounce+27952+67162+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 15:09
收件人: devel@edk2.groups.io; fengyunhua@byosoft.com.cn
抄送: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history.
So I think each of the patches need to have a complete description. There should be some necessary context info about this patch.
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua
Sent: Monday, November 9, 2020 2:39 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
2020-11-09 8:11 ` 回复: " fengyunhua
@ 2020-11-10 4:19 ` Bob Feng
0 siblings, 0 replies; 9+ messages in thread
From: Bob Feng @ 2020-11-10 4:19 UTC (permalink / raw)
To: fengyunhua, devel@edk2.groups.io; +Cc: 'Liming Gao', Chen, Christine
Created a PR: https://github.com/tianocore/edk2/pull/1104
-----Original Message-----
From: fengyunhua <fengyunhua@byosoft.com.cn>
Sent: Monday, November 9, 2020 4:12 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Ok, I have updated commit message with v3
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67162+5049190+8953120@groups.io <bounce+27952+67162+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 15:09
收件人: devel@edk2.groups.io; fengyunhua@byosoft.com.cn
抄送: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yes. I know this from the code review mail. But only the patch subject and message body will be recorded in commit log. People can not tell what the relationship between your patch 1/2 and patch 2/2 based on the commit history.
So I think each of the patches need to have a complete description. There should be some necessary context info about this patch.
Thanks,
Bob
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of fengyunhua
Sent: Monday, November 9, 2020 2:39 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Cc: 'Liming Gao' <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Hi Bob,
This series patch for BZ:
https://bugzilla.tianocore.org/show_bug.cgi?id=2977
Because of .map file changed, so we should change the regular expression pattern for the match
Thanks,
Yunhua
-----邮件原件-----
发件人: bounce+27952+67141+5049190+8953120@groups.io
<bounce+27952+67141+5049190+8953120@groups.io> 代表 Bob Feng
发送时间: 2020年11月9日 14:15
收件人: Yunhua Feng <fengyunhua@byosoft.com.cn>; devel@edk2.groups.io
抄送: Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
主题: Re: [edk2-devel] [PATCH v2 2/2] BaseTools: update report map file format
Yuhuan,
Would you please provide a complete commit message to this patch?
Thanks,
Bob
-----Original Message-----
From: Yunhua Feng <fengyunhua@byosoft.com.cn>
Sent: Friday, October 30, 2020 11:40 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: [PATCH v2 2/2] BaseTools: update report map file format
update report map file format
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
---
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/build/BuildReport.py
b/BaseTools/Source/Python/build/BuildReport.py
index 8efa869162..330234e5af 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -60,7 +60,7 @@ gPcdGuidPattern = re.compile(r"PCD\((\w+)[.](\w+)\)")
gOffsetGuidPattern = re.compile(r"(0x[0-9A-Fa-f]+) ([-A-Fa-f0-9]+)")
## Pattern to find module base address and entry point in fixed flash map file -gModulePattern = r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s\
)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
+gModulePattern =
r"\n[-\w]+\s*\(([^,]+),\s*BaseAddress=%(Address)s,\s*EntryPoint=%(Address)s,
\s*Type=\w+\)\s*\(GUID=([-0-9A-Fa-f]+)[^)]*\)"
gMapFileItemPattern = re.compile(gModulePattern % {"Address" :
"(-?0[xX][0-9A-Fa-f]+)"})
## Pattern to find all module referenced header files in source files
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-11-10 4:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 3:39 [PATCH v2 0/2] Add image type into generate map file fengyunhua
2020-10-30 3:39 ` [PATCH v2 1/2] BaseTools: " fengyunhua
2020-11-09 6:16 ` Bob Feng
2020-10-30 3:39 ` [PATCH v2 2/2] BaseTools: update report map file format fengyunhua
2020-11-09 6:14 ` Bob Feng
2020-11-09 6:38 ` 回复: [edk2-devel] " fengyunhua
2020-11-09 7:09 ` Bob Feng
2020-11-09 8:11 ` 回复: " fengyunhua
2020-11-10 4:19 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox