From: "Omkar Anand Kulkarni" <omkar.kulkarni@arm.com>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Jiewen Yao <jiewen.yao@intel.com>
Subject: [edk2-platforms][PATCH 5/6] Platform/Arm/Sgi: dmc-620 firmware-first error handling
Date: Fri, 30 Oct 2020 14:11:55 +0530 [thread overview]
Message-ID: <20201030084156.8291-6-omkar.kulkarni@arm.com> (raw)
In-Reply-To: <20201030084156.8291-1-omkar.kulkarni@arm.com>
Enable the use of HEST table generation protocol, GHES error source
descriptor protocol and DMC-620 MM driver on SGI/RD platforms. This
allows firmware-first error handling and reporting of DMC-620 memory
controller's 1-bit DRAM ECC errors.
Co-authored-by: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 34 ++++++++++++++++++++
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 25 ++++++++++++++
Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf | 6 ++++
Platform/ARM/SgiPkg/SgiPlatform.fdf | 12 +++++++
4 files changed, 77 insertions(+)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index f5f9f144eee9..1861beef57ef 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -84,6 +84,19 @@
gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported|TRUE
gArmSgiTokenSpaceGuid.PcdVirtioNetSupported|TRUE
+!ifdef EDK2_ENABLE_HEST
+ gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
+ gArmSgiTokenSpaceGuid.PcdHestSupported|TRUE
+!endif
+
+!ifdef EDK2_ENABLE_SDEI
+ gArmSgiTokenSpaceGuid.PcdSdeiSupported|TRUE
+!endif
+
+!ifdef EDK2_ENABLE_GHES_MM
+ gArmSgiTokenSpaceGuid.PcdGhesMmSupported|TRUE
+!endif
+
[PcdsFixedAtBuild.common]
gArmTokenSpaceGuid.PcdVFPEnabled|1
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
@@ -181,6 +194,12 @@
gArmTokenSpaceGuid.PcdMmBufferBase|0xFF600000
gArmTokenSpaceGuid.PcdMmBufferSize|0x10000
+!ifdef EDK2_ENABLE_GHES_MM
+ ## GHESv2 Generic Error memory space
+ gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferBase|0xFF610000
+ gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferSize|0x20000
+!endif
+
################################################################################
#
# Components Section - list of all EDK II Modules needed by this Platform
@@ -257,7 +276,11 @@
#
# platform driver
#
+!ifdef EDK2_ENABLE_GHES_MM
+ Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxeMm.inf
+!else
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
+!endif
#
# FAT filesystem + GPT/MBR partitioning
@@ -314,3 +337,14 @@
MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
+
+
+ #
+ # GHESv2 HEST error sources support
+ #
+!ifdef EDK2_ENABLE_HEST
+ ArmPlatformPkg/Drivers/Apei/HestDxe/HestDxe.inf
+!endif
+!ifdef EDK2_ENABLE_GHES_MM
+ ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf
+!endif
diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
index 38bf6020ba4c..b9c8c386be12 100644
--- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
+++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
@@ -94,6 +94,25 @@
gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x2
+!ifdef EDK2_ENABLE_GHES_MM
+ ## GHESv2 Generic Error Memory Space
+ gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferBase|0xFF610000
+ gArmPlatformTokenSpaceGuid.PcdGhesGenericErrorDataMmBufferSize|0x20000
+!endif
+
+!ifdef EDK2_ENABLE_DMC620_MM
+ ## DMC620
+ gDmc620MmTokenSpaceGuid.PcdDmc620NumCtrl|2
+ gDmc620MmTokenSpaceGuid.PcdDmc620RegisterBase|0x4E000000
+ gDmc620MmTokenSpaceGuid.PcdDmc620CtrlSize|0x100000
+ gDmc620MmTokenSpaceGuid.PcdDmc620CorrectableErrorThreshold|10
+ gDmc620MmTokenSpaceGuid.PcdDmc620ErrSourceCount|1
+ gDmc620MmTokenSpaceGuid.PcdDmc620DramErrorSdeiEventBase|804
+ gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorDataBase|0xFF610000
+ gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorDataSize|0x100
+ gDmc620MmTokenSpaceGuid.PcdDmc620DramOneBitErrorSourceId|0
+!endif
+
###################################################################################################
#
# Components Section - list of the modules and components that will be processed by compilation
@@ -119,6 +138,12 @@
StandaloneMmPkg/Core/StandaloneMmCore.inf
[Components.AARCH64]
+!ifdef EDK2_ENABLE_GHES_MM
+ ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf
+!endif
+!ifdef EDK2_ENABLE_DMC620_MM
+ Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf
+!endif
StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
###################################################################################################
diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
index 5a0772cd8522..8eab45e35a8a 100644
--- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
+++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf
@@ -48,6 +48,12 @@ READ_STATUS = TRUE
READ_LOCK_CAP = TRUE
READ_LOCK_STATUS = TRUE
+!ifdef EDK2_ENABLE_GHES_MM
+ INF ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandaloneMm.inf
+!endif
+!ifdef EDK2_ENABLE_DMC620_MM
+ INF Platform/ARM/Drivers/Dmc620Mm/Dmc620Mm.inf
+!endif
INF StandaloneMmPkg/Core/StandaloneMmCore.inf
INF StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
index 546021a8bf33..42dfdd06b003 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
+++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
@@ -164,10 +164,22 @@ READ_LOCK_STATUS = TRUE
# MM Communicate
INF ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
+ # Hest Error Source Support
+!ifdef EDK2_ENABLE_HEST
+ INF ArmPlatformPkg/Drivers/Apei/HestDxe/HestDxe.inf
+!endif
+!ifdef EDK2_ENABLE_GHES_MM
+ INF ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf
+!endif
+
#
# Platform driver
#
+!ifdef EDK2_ENABLE_GHES_MM
+ INF Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxeMm.inf
+!else
INF Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
+!endif
#
# Bds
--
2.17.1
next prev parent reply other threads:[~2020-10-30 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:41 [edk2-platforms][PATCH 0/6] Platform/ARM/Sgi: Add DMC620 1-bit ECC error handling Omkar Anand Kulkarni
2020-10-30 8:41 ` [edk2-platforms][PATCH 1/6] Platform/ARM: Add DMC-620 RAS error handling driver Omkar Anand Kulkarni
2020-10-30 8:41 ` [edk2-platforms][PATCH 2/6] Platform/ARM/Sgi: Install SDEI ACPI table Omkar Anand Kulkarni
2020-10-30 8:41 ` [edk2-platforms][PATCH 3/6] Platform/Arm/Sgi: Install HEST " Omkar Anand Kulkarni
2020-10-30 8:41 ` [edk2-platforms][PATCH 4/6] Platform/Arm/Sgi: define memory region for GHES error status block Omkar Anand Kulkarni
2020-10-30 8:41 ` Omkar Anand Kulkarni [this message]
2020-10-30 8:41 ` [edk2-platforms][PATCH 6/6] Platform/Arm/Sgi575: Define values for ACPI table header Omkar Anand Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030084156.8291-6-omkar.kulkarni@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox