From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.3861.1604409836011329601 for ; Tue, 03 Nov 2020 05:23:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: mateusz.albecki@intel.com) IronPort-SDR: 2IbUG7PQ0hVUwsC94jpKvxzcDg2Ltna4L0YaY8Umw46S1+IZOaD2AXDOee8PynRs6OQaA7EXAT QGjmxKhwep2A== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156038680" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="156038680" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 05:23:53 -0800 IronPort-SDR: J4cb6ZoUZSWZ5jbGdubs3yrMFh+FbjKquyPUYJTFIyVrGcPtNuoYV+b2/zklcwes5OQ3dw/K6T g10/AeQg8Wig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="363023475" Received: from gklab-27-32.ger.corp.intel.com ([10.102.28.45]) by FMSMGA003.fm.intel.com with ESMTP; 03 Nov 2020 05:23:52 -0800 From: "Albecki, Mateusz" To: devel@edk2.groups.io Cc: Mateusz Albecki , Ray Ni , Hao A Wu Subject: [PATCH 0/4] MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery Date: Tue, 3 Nov 2020 14:23:44 +0100 Message-Id: <20201103132348.2916-1-mateusz.albecki@intel.com> X-Mailer: git-send-email 2.14.1.windows.1 To increase boot stability when booting from SATA drives SATA driver should implement the AHCI spec defined port error recovery. This will allow the driver to handle random fails on SATA link. Performed tests on 2 setups. One with AHCI controller booting OS successfully without error recovery(control setup) and other which fails 1 in 5 times(fail setup). Tests performed: 1. Booted control setup to OS successfully. 2. Checked if during normal boot none of the packets is repeated(this came up after previous code version had a bug which repeated each DMA packet 5 times). 3. Booted control setup to OS with simulated errors appearing on first packet of every DMA transaction. 4. Performed extensive tests on fail setup. Fail rate decreased from 20% failure to ~1% failure. 1% failure is observed during OS execution, not BIOS so in a way boot is 100% stable). Change pushed to github: This series: https://github.com/malbecki/edk2/commits/sata_recovery2 Simulated errors: https://github.com/malbecki/edk2/commits/sata_recovery_simulated_error Signed-off-by: Mateusz Albecki Cc: Ray Ni Cc: Hao A Wu Albecki (4): MdeModulePkg/AtaAtapiPassThru: Check IS to check for command completion MdeModulePkg/AtaAtapiPassThru: Add SATA error recovery flow MdeModulePkg/AtaAtapiPassThru: Restart failed packets MdeModulePkg/AtaAtapiPassThru: Trace ATA packets .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 801 +++++++++++------- .../Bus/Ata/AtaAtapiPassThru/AhciMode.h | 16 +- 2 files changed, 532 insertions(+), 285 deletions(-) -- 2.28.0.windows.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN. Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.