From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.60]) by mx.groups.io with SMTP id smtpd.web09.12286.1604493285216646844 for ; Wed, 04 Nov 2020 04:34:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=gjZThE+q; spf=pass (domain: arm.com, ip: 40.107.22.60, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C03xTJJQPqHyCHyya2NgnmzGIZgpI5dvNsqAXC82kkg=; b=gjZThE+qwCt+3SR1TP/zJtkE2+H8ihycqtzRvBcjLbHl26hFacHzJcGDhG141hs8G4QcUjK8DZukhFTmJ7UnyCqFrIJXpta25ZcFs524nJN/TJigmnp5XdK4y++pr+iB60npmjavxYtha9ddE0+ECDtYezVpFbSjcDVW1nGxWmU= Received: from MR2P264CA0012.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::24) by AM6PR08MB4568.eurprd08.prod.outlook.com (2603:10a6:20b:ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 4 Nov 2020 12:34:41 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:1:cafe::a7) by MR2P264CA0012.outlook.office365.com (2603:10a6:500:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Wed, 4 Nov 2020 12:34:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Wed, 4 Nov 2020 12:34:39 +0000 Received: ("Tessian outbound c579d876a324:v64"); Wed, 04 Nov 2020 12:34:37 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 02c87c6934b707a2 X-CR-MTA-TID: 64aa7808 Received: from 78e8713e8dcc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5BEEE1A-B4E0-4F94-9870-CFC734CAC910.1; Wed, 04 Nov 2020 12:33:59 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 78e8713e8dcc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 Nov 2020 12:33:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZhGWhNRIwrGar1R3IwlnEJzE5Fct/qpo7X5Q959YZc20JtgT5jPU4WhumdX6wkRRG6QlzoNz2LDjSHzchQeFjeabZGws3vgWd0+E5NMBs/A0xX1Gb/qurwn2V+8fv7leqyVg7mEfj5ww17noIDDUBJ83wQaAapsfG00LQD/vBQL7KLWVSUDuCkHTXB42+r9cN2o4kbzOXhNdoVyCHBQzE8FL4PV93Hquw+eCMMk5WB+8k9And3nsJvsyr07ynSXZc8102HR26qTf95ucUPOnUVC555AhoDoyXW1afYmPJVXAmJGrcl5U7ZCj2MvWMAJVfy7UHPD+jFWQ1WvJLGMdZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C03xTJJQPqHyCHyya2NgnmzGIZgpI5dvNsqAXC82kkg=; b=AQeEw1qX6ThfM8m6mHasoXyaQKxCLcNU/J2roYPwIPD19GZa7Grn7c9O5tlRoWuhqmPYvSsvEoReDS3zYB2xr/qNwVyn61HEp1Lp+HkU9uXqHoShsrqHTDIzrA2gyjMMmzY74wt0J+ABt447CD3z5d46ZjYo55qpIhO+jIOufTyqlgyX5uZH7Lcvh/qrJ/yLHcan1D9LuxGUjmxQhgdD3QnjeRhXBhnyjV8EsEX7dJpjGz4JW2PZzN3Rii1uRSL4yTeeIkC04D6HkkvtA0b7jguxlKOOVNTactFQIieDyFyM1rOcgU5TPHzuAl0P8zo0+RRz62Ns2rMjVOaLRLLXeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C03xTJJQPqHyCHyya2NgnmzGIZgpI5dvNsqAXC82kkg=; b=gjZThE+qwCt+3SR1TP/zJtkE2+H8ihycqtzRvBcjLbHl26hFacHzJcGDhG141hs8G4QcUjK8DZukhFTmJ7UnyCqFrIJXpta25ZcFs524nJN/TJigmnp5XdK4y++pr+iB60npmjavxYtha9ddE0+ECDtYezVpFbSjcDVW1nGxWmU= Received: from DB6PR0501CA0018.eurprd05.prod.outlook.com (2603:10a6:4:8f::28) by AM5PR0801MB1876.eurprd08.prod.outlook.com (2603:10a6:203:42::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 4 Nov 2020 12:33:58 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::ff) by DB6PR0501CA0018.outlook.office365.com (2603:10a6:4:8f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Wed, 4 Nov 2020 12:33:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3520.15 via Frontend Transport; Wed, 4 Nov 2020 12:33:58 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Wed, 4 Nov 2020 12:33:14 +0000 Received: from E107187.Arm.com (10.57.51.198) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Wed, 4 Nov 2020 12:33:14 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [PATCH v2-resend 1/2] ShellPkg/AcpiView: Fix field validator invocation Date: Wed, 4 Nov 2020 12:33:12 +0000 Message-ID: <20201104123313.32524-2-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20201104123313.32524-1-sami.mujawar@arm.com> References: <20201104123313.32524-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 741bf3a9-bc21-4617-37aa-08d880be007a X-MS-TrafficTypeDiagnostic: AM5PR0801MB1876:|AM6PR08MB4568: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eIlnne0DoW2DLrm24n6z8Cz0KQPa+U87spXa1AWVoEGa0aNtYUkQiRvnzhUVg9AX5hOCObRNtm9ZQ7uOz9n3jo9LG8o1l1ElRmwrIyO6Nx3atXcc77aCBs9ERsrgt4+JYpkKPAgPz1HA2FtmWlg/HSWDZhhqB01z2ZC4G46iProObZem5apT225/E7PPL5ZT1YhUD7FQit6ZprHmRcZnLL4giyQCwALq9Y7EEeci7nnDSN58FIuxTbE4LYO2cmM2M3JX4Lv8ZMmDRgU6OWHWtDqX5CzFNLXhzCRAq3Z9X3Il3wNwvTV+iR+d0HKGPJ6R3F6egkFUwLnJCJa5amIpU4fTmLFjGuAES64YYIoKEUPSc+OMZMaw/8HFN7vWoD7lA/5ctPfi/Gp2z5JcZDCKGAhcTnB79LR84O2pm4QT6escf6Z5WwguPWIe61ltfkOBO06ipwltydMLK3hTK8JeJHFYCNLNbDLD2MZBv8IXP+4= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(46966005)(54906003)(2616005)(426003)(26005)(44832011)(7696005)(316002)(4326008)(6916009)(336012)(478600001)(186003)(47076004)(81166007)(5660300002)(82310400003)(8936002)(2906002)(86362001)(70206006)(356005)(70586007)(83380400001)(36756003)(8676002)(82740400003)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1876 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 61ac98c5-7634-462a-95c2-08d880bde6d3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2OQFEL91+GcNHkR17efE5b0srsjMZqv4cQkaBe5h1cN2nnJkAlw4I9X5ehAOmwbLHfLJD6bCTt6jMkaijOMatlpZMhOzP4uO+RqYecDl8D5eTm2r3XjuZi2fW1AgvGr3U7+06yoGBv3hhjc125uEDmFbjcR1CF81M04v6XBUEhi+fkkeIhXXK5bYleRNMKz/AsI64uejcuh5ga+si4qNlpEP2Euyhpb0kTNEvoBEgexBsqukBpNE5rh/NgREJaUhUd2lOU3ik6S8wdgyBwfYhay9612rSR7PQXxpITtuNS8lYKNwG/1v06k6XO2wfxNrgs25MckTyP/Kfe8jaFXXlWvEQDhVMrC/EVIwRsVFsTm7ptO4rrtRcdND7EAiBFCr/3aRZ7PRp208JBq8TggU4Qdeo0OiXfo80B23smv7klOx23YDcJlPfOVh55YbrSs6JSX5hxsb5d385YKOw0CX4MBGySqrw3dNonLMElaYb1M= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(46966005)(83380400001)(81166007)(44832011)(36906005)(316002)(26005)(186003)(8936002)(54906003)(336012)(82310400003)(47076004)(82740400003)(70206006)(86362001)(5660300002)(1076003)(7696005)(478600001)(4326008)(2906002)(70586007)(6916009)(426003)(8676002)(2616005)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2020 12:34:39.9582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 741bf3a9-bc21-4617-37aa-08d880be007a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4568 Content-Type: text/plain Bugzilla: 3046 (https://bugzilla.tianocore.org/show_bug.cgi?id=3046) The field validator function provides means to validate fields in the ACPI table structures. To print complex field types a print formatter function is provided. The field validator was being invoked for simple data fields for which the default print format is used. However, the field validator function was not invoked if a print formatter function was provided. This problem is noticed when a Generic Address Structure (GAS) is printed using DumpGas() and a field validator is present to validate the GAS structure. To fix this move the invocation of the field validator after the field is printed such that the validation function is called even when a print formatter function is present. Signed-off-by: Sami Mujawar --- Notes: v2: - This is a new patch introduced in v2 series. [SAMI] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index 02f6d771c7e1a9b8faa577b38e51c9de350d24fd..01ac9a9bafeb2ca12c1ba19f406d626b108f5fe2 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -596,13 +596,12 @@ ParseAcpi ( Parser[Index].Length ); } // switch - - // Validating only makes sense if we are tracing - // the parsed table entries, to report by table name. - if (GetConsistencyChecking () && - (Parser[Index].FieldValidator != NULL)) { - Parser[Index].FieldValidator (Ptr, Parser[Index].Context); - } + } + // Validating only makes sense if we are tracing + // the parsed table entries, to report by table name. + if (GetConsistencyChecking () && + (Parser[Index].FieldValidator != NULL)) { + Parser[Index].FieldValidator (Ptr, Parser[Index].Context); } Print (L"\n"); } // if (Trace) -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'