* [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
@ 2020-11-04 19:03 Pete Batard
2020-11-11 17:05 ` [edk2-devel] " Andrei Warkentin
2020-11-11 17:37 ` Samer El-Haj-Mahmoud
0 siblings, 2 replies; 7+ messages in thread
From: Pete Batard @ 2020-11-04 19:03 UTC (permalink / raw)
To: devel; +Cc: michael.d.kinney, gaoliming, zhiguang.liu, samer.el-haj-mahmoud
The Raspberry Pi platform with Secure Boot enabled currently fails to build
with error:
Module type [DXE_RUNTIME_DRIVER] is not supported by library instance
[/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf]
Add the missing class to fix this issue.
Signed-off-by: Pete Batard <pete@akeo.ie>
---
MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
index 68554ad21146..9c11959f8aeb 100644
--- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
+++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
@@ -14,7 +14,7 @@ [Defines]
FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
MODULE_TYPE = DXE_DRIVER
VERSION_STRING = 1.0
- LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION UEFI_DRIVER
+ LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION UEFI_DRIVER
[Packages]
MdePkg/MdePkg.dec
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
2020-11-04 19:03 [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib Pete Batard
@ 2020-11-11 17:05 ` Andrei Warkentin
2020-11-11 17:37 ` Samer El-Haj-Mahmoud
1 sibling, 0 replies; 7+ messages in thread
From: Andrei Warkentin @ 2020-11-11 17:05 UTC (permalink / raw)
To: devel@edk2.groups.io, pete@akeo.ie
Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
zhiguang.liu@intel.com, samer.el-haj-mahmoud@arm.com
[-- Attachment #1: Type: text/plain, Size: 1655 bytes --]
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Pete Batard via groups.io <pete=akeo.ie@groups.io>
Sent: Wednesday, November 4, 2020 1:03 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: michael.d.kinney@intel.com <michael.d.kinney@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; zhiguang.liu@intel.com <zhiguang.liu@intel.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>
Subject: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
The Raspberry Pi platform with Secure Boot enabled currently fails to build
with error:
Module type [DXE_RUNTIME_DRIVER] is not supported by library instance
[/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf]
Add the missing class to fix this issue.
Signed-off-by: Pete Batard <pete@akeo.ie>
---
MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
index 68554ad21146..9c11959f8aeb 100644
--- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
+++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
@@ -14,7 +14,7 @@ [Defines]
FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
MODULE_TYPE = DXE_DRIVER
VERSION_STRING = 1.0
- LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION UEFI_DRIVER
+ LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_APPLICATION UEFI_DRIVER
[Packages]
MdePkg/MdePkg.dec
--
2.21.0.windows.1
[-- Attachment #2: Type: text/html, Size: 2698 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
2020-11-04 19:03 [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib Pete Batard
2020-11-11 17:05 ` [edk2-devel] " Andrei Warkentin
@ 2020-11-11 17:37 ` Samer El-Haj-Mahmoud
2020-11-12 1:52 ` 回复: [edk2-devel] " gaoliming
1 sibling, 1 reply; 7+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-11-11 17:37 UTC (permalink / raw)
To: Pete Batard, devel@edk2.groups.io
Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
zhiguang.liu@intel.com
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Pete Batard <pete@akeo.ie>
> Sent: Wednesday, November 4, 2020 2:04 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER
> class to RngLib
>
> The Raspberry Pi platform with Secure Boot enabled currently fails to build
> with error:
>
> Module type [DXE_RUNTIME_DRIVER] is not supported by library instance
>
> [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
> b.inf]
>
> Add the missing class to fix this issue.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> index 68554ad21146..9c11959f8aeb 100644
> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> @@ -14,7 +14,7 @@ [Defines]
> FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
> MODULE_TYPE = DXE_DRIVER
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION UEFI_DRIVER
> + LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> UEFI_APPLICATION UEFI_DRIVER
>
> [Packages]
> MdePkg/MdePkg.dec
> --
> 2.21.0.windows.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
2020-11-11 17:37 ` Samer El-Haj-Mahmoud
@ 2020-11-12 1:52 ` gaoliming
2020-11-12 12:09 ` Pete Batard
0 siblings, 1 reply; 7+ messages in thread
From: gaoliming @ 2020-11-12 1:52 UTC (permalink / raw)
To: devel, samer.el-haj-mahmoud, 'Pete Batard'
Cc: michael.d.kinney, zhiguang.liu
I agree this library instance can be used for RUNTIME driver before boot to
OS.
Can you let me know which runtime driver consumes it? And, please make sure
the consumer code runs in boot phase only.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67295+4905953+8761045@groups.io
> <bounce+27952+67295+4905953+8761045@groups.io> 代表 Samer
> El-Haj-Mahmoud
> 发送时间: 2020年11月12日 1:38
> 收件人: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io
> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> DXE_RUNTIME_DRIVER class to RngLib
>
> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> > -----Original Message-----
> > From: Pete Batard <pete@akeo.ie>
> > Sent: Wednesday, November 4, 2020 2:04 PM
> > To: devel@edk2.groups.io
> > Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud@arm.com>
> > Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER
> > class to RngLib
> >
> > The Raspberry Pi platform with Secure Boot enabled currently fails to
build
> > with error:
> >
> > Module type [DXE_RUNTIME_DRIVER] is not supported by library
> instance
> >
> > [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
> > b.inf]
> >
> > Add the missing class to fix this issue.
> >
> > Signed-off-by: Pete Batard <pete@akeo.ie>
> > ---
> > MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > index 68554ad21146..9c11959f8aeb 100644
> > --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > @@ -14,7 +14,7 @@ [Defines]
> > FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
> > MODULE_TYPE = DXE_DRIVER
> > VERSION_STRING = 1.0
> > - LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION
> UEFI_DRIVER
> > + LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> > UEFI_APPLICATION UEFI_DRIVER
> >
> > [Packages]
> > MdePkg/MdePkg.dec
> > --
> > 2.21.0.windows.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
recipient,
> please notify the sender immediately and do not disclose the contents to
any
> other person, use it for any purpose, or store or copy the information in
any
> medium. Thank you.
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
2020-11-12 1:52 ` 回复: [edk2-devel] " gaoliming
@ 2020-11-12 12:09 ` Pete Batard
2020-11-12 13:41 ` 回复: " gaoliming
[not found] ` <1646C675163A08FD.26994@groups.io>
0 siblings, 2 replies; 7+ messages in thread
From: Pete Batard @ 2020-11-12 12:09 UTC (permalink / raw)
To: gaoliming, devel, samer.el-haj-mahmoud; +Cc: michael.d.kinney, zhiguang.liu
Hi Liming,
On 2020.11.12 01:52, gaoliming wrote:
> I agree this library instance can be used for RUNTIME driver before boot to
> OS.
>
> Can you let me know which runtime driver consumes it?
It's OpenSslLib.
As per
https://github.com/tianocore/edk2-platforms/commit/1e09147a01aeb45aa43e36923d96a1d6b0ec9106
we had to introduce a dependency to RngLib to keep OpenSslLib happy, and
the build breaks in VariableRuntimeDxe since it depends on OpenSslLib
which itself now depends on RngLib.
Here's the verbose build output that shows it:
Library instances of module
[/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf]
[AARCH64]:
MemoryAllocationLib :
/usr/src/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
BaseLib : /usr/src/edk2/MdePkg/Library/BaseLib/BaseLib.inf
SynchronizationLib :
/usr/src/edk2/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
UefiLib : /usr/src/edk2/MdePkg/Library/UefiLib/UefiLib.inf
UefiBootServicesTableLib :
/usr/src/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
BaseMemoryLib :
/usr/src/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
DebugLib :
/usr/src/edk2/MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
UefiRuntimeLib :
/usr/src/edk2/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
DxeServicesTableLib :
/usr/src/edk2/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiDriverEntryPoint :
/usr/src/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
PcdLib : /usr/src/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf
HobLib : /usr/src/edk2/MdePkg/Library/DxeHobLib/DxeHobLib.inf
TpmMeasurementLib :
/usr/src/edk2/SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
AuthVariableLib :
/usr/src/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
VarCheckLib :
/usr/src/edk2/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
NULL2 :
/usr/src/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
NULL1 :
/usr/src/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
NULL4 :
/usr/src/edk2/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
DevicePathLib :
/usr/src/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
PrintLib :
/usr/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf
BaseCryptLib :
/usr/src/edk2/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
PlatformSecureLib :
/usr/src/edk2/OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
UefiRuntimeServicesTableLib :
/usr/src/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
OpensslLib :
/usr/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf
IntrinsicLib :
/usr/src/edk2/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
build.py...
/usr/src/edk2-platforms/Platform/RaspberryPi/RPi4/RPi4.dsc(...): error
1001: Module type [DXE_RUNTIME_DRIVER] is not supported by library
instance [/usr/src/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf]
consumed by
[/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf]
> And, please make sure
> the consumer code runs in boot phase only.
That's for Secure Boot, so I think we should be okay.
Regards,
/Pete
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+67295+4905953+8761045@groups.io
>> <bounce+27952+67295+4905953+8761045@groups.io> 代表 Samer
>> El-Haj-Mahmoud
>> 发送时间: 2020年11月12日 1:38
>> 收件人: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io
>> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
>> zhiguang.liu@intel.com
>> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
>> DXE_RUNTIME_DRIVER class to RngLib
>>
>> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>>
>>> -----Original Message-----
>>> From: Pete Batard <pete@akeo.ie>
>>> Sent: Wednesday, November 4, 2020 2:04 PM
>>> To: devel@edk2.groups.io
>>> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
>>> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
>>> Mahmoud@arm.com>
>>> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER
>>> class to RngLib
>>>
>>> The Raspberry Pi platform with Secure Boot enabled currently fails to
> build
>>> with error:
>>>
>>> Module type [DXE_RUNTIME_DRIVER] is not supported by library
>> instance
>>>
>>> [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
>>> b.inf]
>>>
>>> Add the missing class to fix this issue.
>>>
>>> Signed-off-by: Pete Batard <pete@akeo.ie>
>>> ---
>>> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
>>> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
>>> index 68554ad21146..9c11959f8aeb 100644
>>> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
>>> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
>>> @@ -14,7 +14,7 @@ [Defines]
>>> FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
>>> MODULE_TYPE = DXE_DRIVER
>>> VERSION_STRING = 1.0
>>> - LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION
>> UEFI_DRIVER
>>> + LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
>>> UEFI_APPLICATION UEFI_DRIVER
>>>
>>> [Packages]
>>> MdePkg/MdePkg.dec
>>> --
>>> 2.21.0.windows.1
>>
>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended
> recipient,
>> please notify the sender immediately and do not disclose the contents to
> any
>> other person, use it for any purpose, or store or copy the information in
> any
>> medium. Thank you.
>>
>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* 回复: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
2020-11-12 12:09 ` Pete Batard
@ 2020-11-12 13:41 ` gaoliming
[not found] ` <1646C675163A08FD.26994@groups.io>
1 sibling, 0 replies; 7+ messages in thread
From: gaoliming @ 2020-11-12 13:41 UTC (permalink / raw)
To: devel, pete, samer.el-haj-mahmoud; +Cc: michael.d.kinney, zhiguang.liu
Pete:
This detail is enough. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67385+4905953+8761045@groups.io
> <bounce+27952+67385+4905953+8761045@groups.io> 代表 Pete Batard
> 发送时间: 2020年11月12日 20:10
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> samer.el-haj-mahmoud@arm.com
> 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com
> 主题: Re: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> DXE_RUNTIME_DRIVER class to RngLib
>
> Hi Liming,
>
> On 2020.11.12 01:52, gaoliming wrote:
> > I agree this library instance can be used for RUNTIME driver before boot
to
> > OS.
> >
> > Can you let me know which runtime driver consumes it?
>
> It's OpenSslLib.
>
> As per
> https://github.com/tianocore/edk2-platforms/commit/1e09147a01aeb45aa4
> 3e36923d96a1d6b0ec9106
> we had to introduce a dependency to RngLib to keep OpenSslLib happy, and
> the build breaks in VariableRuntimeDxe since it depends on OpenSslLib
> which itself now depends on RngLib.
>
> Here's the verbose build output that shows it:
>
> Library instances of module
> [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun
> timeDxe.inf]
> [AARCH64]:
> MemoryAllocationLib :
> /usr/src/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocati
> onLib.inf
> BaseLib : /usr/src/edk2/MdePkg/Library/BaseLib/BaseLib.inf
> SynchronizationLib :
> /usr/src/edk2/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationL
> ib.inf
> UefiLib : /usr/src/edk2/MdePkg/Library/UefiLib/UefiLib.inf
> UefiBootServicesTableLib :
> /usr/src/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTa
> bleLib.inf
> BaseMemoryLib :
> /usr/src/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOpt
> Dxe.inf
> DebugLib :
> /usr/src/edk2/MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> UefiRuntimeLib :
> /usr/src/edk2/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> DxeServicesTableLib :
> /usr/src/edk2/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> UefiDriverEntryPoint :
> /usr/src/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> PcdLib : /usr/src/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> HobLib : /usr/src/edk2/MdePkg/Library/DxeHobLib/DxeHobLib.inf
> TpmMeasurementLib :
> /usr/src/edk2/SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasur
> ementLib.inf
> AuthVariableLib :
> /usr/src/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> VarCheckLib :
> /usr/src/edk2/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> NULL2 :
> /usr/src/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> NULL1 :
>
/usr/src/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> NULL4 :
> /usr/src/edk2/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> DevicePathLib :
> /usr/src/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> PrintLib :
> /usr/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BaseCryptLib :
> /usr/src/edk2/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> PlatformSecureLib :
> /usr/src/edk2/OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> UefiRuntimeServicesTableLib :
> /usr/src/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeSer
> vicesTableLib.inf
> OpensslLib :
> /usr/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> IntrinsicLib :
> /usr/src/edk2/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
>
>
> build.py...
> /usr/src/edk2-platforms/Platform/RaspberryPi/RPi4/RPi4.dsc(...): error
> 1001: Module type [DXE_RUNTIME_DRIVER] is not supported by library
> instance [/usr/src/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf]
> consumed by
> [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun
> timeDxe.inf]
>
> > And, please make sure
> > the consumer code runs in boot phase only.
>
> That's for Secure Boot, so I think we should be okay.
>
> Regards,
>
> /Pete
>
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: bounce+27952+67295+4905953+8761045@groups.io
> >> <bounce+27952+67295+4905953+8761045@groups.io> 代表 Samer
> >> El-Haj-Mahmoud
> >> 发送时间: 2020年11月12日 1:38
> >> 收件人: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io
> >> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> >> zhiguang.liu@intel.com
> >> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> >> DXE_RUNTIME_DRIVER class to RngLib
> >>
> >> Reviewed-by: Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>
> >>
> >>> -----Original Message-----
> >>> From: Pete Batard <pete@akeo.ie>
> >>> Sent: Wednesday, November 4, 2020 2:04 PM
> >>> To: devel@edk2.groups.io
> >>> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> >>> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
> >>> Mahmoud@arm.com>
> >>> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> DXE_RUNTIME_DRIVER
> >>> class to RngLib
> >>>
> >>> The Raspberry Pi platform with Secure Boot enabled currently fails to
> > build
> >>> with error:
> >>>
> >>> Module type [DXE_RUNTIME_DRIVER] is not supported by library
> >> instance
> >>>
> >>>
> [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
> >>> b.inf]
> >>>
> >>> Add the missing class to fix this issue.
> >>>
> >>> Signed-off-by: Pete Batard <pete@akeo.ie>
> >>> ---
> >>> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >>> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >>> index 68554ad21146..9c11959f8aeb 100644
> >>> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >>> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> >>> @@ -14,7 +14,7 @@ [Defines]
> >>> FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
> >>> MODULE_TYPE = DXE_DRIVER
> >>> VERSION_STRING = 1.0
> >>> - LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION
> >> UEFI_DRIVER
> >>> + LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> >>> UEFI_APPLICATION UEFI_DRIVER
> >>>
> >>> [Packages]
> >>> MdePkg/MdePkg.dec
> >>> --
> >>> 2.21.0.windows.1
> >>
> >> IMPORTANT NOTICE: The contents of this email and any attachments are
> >> confidential and may also be privileged. If you are not the intended
> > recipient,
> >> please notify the sender immediately and do not disclose the contents
to
> > any
> >> other person, use it for any purpose, or store or copy the information
in
> > any
> >> medium. Thank you.
> >>
> >>
> >>
> >>
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread[parent not found: <1646C675163A08FD.26994@groups.io>]
* 回复: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
[not found] ` <1646C675163A08FD.26994@groups.io>
@ 2020-11-13 5:48 ` gaoliming
0 siblings, 0 replies; 7+ messages in thread
From: gaoliming @ 2020-11-13 5:48 UTC (permalink / raw)
To: devel, gaoliming, pete, samer.el-haj-mahmoud
Cc: michael.d.kinney, zhiguang.liu
Create PR https://github.com/tianocore/edk2/pull/1122
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67388+4905953+8761045@groups.io
> <bounce+27952+67388+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年11月12日 21:42
> 收件人: devel@edk2.groups.io; pete@akeo.ie;
> samer.el-haj-mahmoud@arm.com
> 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com
> 主题: 回复: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> DXE_RUNTIME_DRIVER class to RngLib
>
> Pete:
> This detail is enough. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+67385+4905953+8761045@groups.io
> > <bounce+27952+67385+4905953+8761045@groups.io> 代表 Pete Batard
> > 发送时间: 2020年11月12日 20:10
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io;
> > samer.el-haj-mahmoud@arm.com
> > 抄送: michael.d.kinney@intel.com; zhiguang.liu@intel.com
> > 主题: Re: 回复: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> > DXE_RUNTIME_DRIVER class to RngLib
> >
> > Hi Liming,
> >
> > On 2020.11.12 01:52, gaoliming wrote:
> > > I agree this library instance can be used for RUNTIME driver before
boot
> to
> > > OS.
> > >
> > > Can you let me know which runtime driver consumes it?
> >
> > It's OpenSslLib.
> >
> > As per
> >
> https://github.com/tianocore/edk2-platforms/commit/1e09147a01aeb45aa4
> > 3e36923d96a1d6b0ec9106
> > we had to introduce a dependency to RngLib to keep OpenSslLib happy, and
> > the build breaks in VariableRuntimeDxe since it depends on OpenSslLib
> > which itself now depends on RngLib.
> >
> > Here's the verbose build output that shows it:
> >
> > Library instances of module
> >
> [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun
> > timeDxe.inf]
> > [AARCH64]:
> > MemoryAllocationLib :
> >
> /usr/src/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocati
> > onLib.inf
> > BaseLib : /usr/src/edk2/MdePkg/Library/BaseLib/BaseLib.inf
> > SynchronizationLib :
> >
> /usr/src/edk2/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationL
> > ib.inf
> > UefiLib : /usr/src/edk2/MdePkg/Library/UefiLib/UefiLib.inf
> > UefiBootServicesTableLib :
> >
> /usr/src/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTa
> > bleLib.inf
> > BaseMemoryLib :
> >
> /usr/src/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOpt
> > Dxe.inf
> > DebugLib :
> > /usr/src/edk2/MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> > UefiRuntimeLib :
> > /usr/src/edk2/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > DxeServicesTableLib :
> >
> /usr/src/edk2/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> > UefiDriverEntryPoint :
> >
> /usr/src/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> > PcdLib :
> /usr/src/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > HobLib :
> /usr/src/edk2/MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > TpmMeasurementLib :
> >
> /usr/src/edk2/SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasur
> > ementLib.inf
> > AuthVariableLib :
> > /usr/src/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> > VarCheckLib :
> > /usr/src/edk2/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> > NULL2 :
> > /usr/src/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> > NULL1 :
> >
>
/usr/src/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> > NULL4 :
> >
> /usr/src/edk2/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> > DevicePathLib :
> > /usr/src/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > PrintLib :
> > /usr/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > BaseCryptLib :
> > /usr/src/edk2/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> > PlatformSecureLib :
> > /usr/src/edk2/OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
> > UefiRuntimeServicesTableLib :
> >
> /usr/src/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeSer
> > vicesTableLib.inf
> > OpensslLib :
> > /usr/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > IntrinsicLib :
> > /usr/src/edk2/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> >
> >
> > build.py...
> > /usr/src/edk2-platforms/Platform/RaspberryPi/RPi4/RPi4.dsc(...): error
> > 1001: Module type [DXE_RUNTIME_DRIVER] is not supported by library
> > instance [/usr/src/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf]
> > consumed by
> >
> [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun
> > timeDxe.inf]
> >
> > > And, please make sure
> > > the consumer code runs in boot phase only.
> >
> > That's for Secure Boot, so I think we should be okay.
> >
> > Regards,
> >
> > /Pete
> >
> > >
> > > Thanks
> > > Liming
> > >> -----邮件原件-----
> > >> 发件人: bounce+27952+67295+4905953+8761045@groups.io
> > >> <bounce+27952+67295+4905953+8761045@groups.io> 代表 Samer
> > >> El-Haj-Mahmoud
> > >> 发送时间: 2020年11月12日 1:38
> > >> 收件人: Pete Batard <pete@akeo.ie>; devel@edk2.groups.io
> > >> 抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > >> zhiguang.liu@intel.com
> > >> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> > >> DXE_RUNTIME_DRIVER class to RngLib
> > >>
> > >> Reviewed-by: Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com>
> > >>
> > >>> -----Original Message-----
> > >>> From: Pete Batard <pete@akeo.ie>
> > >>> Sent: Wednesday, November 4, 2020 2:04 PM
> > >>> To: devel@edk2.groups.io
> > >>> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > >>> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > >>> Mahmoud@arm.com>
> > >>> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add
> > DXE_RUNTIME_DRIVER
> > >>> class to RngLib
> > >>>
> > >>> The Raspberry Pi platform with Secure Boot enabled currently fails
to
> > > build
> > >>> with error:
> > >>>
> > >>> Module type [DXE_RUNTIME_DRIVER] is not supported by library
> > >> instance
> > >>>
> > >>>
> > [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
> > >>> b.inf]
> > >>>
> > >>> Add the missing class to fix this issue.
> > >>>
> > >>> Signed-off-by: Pete Batard <pete@akeo.ie>
> > >>> ---
> > >>> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
> > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > >>> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > >>> index 68554ad21146..9c11959f8aeb 100644
> > >>> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > >>> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> > >>> @@ -14,7 +14,7 @@ [Defines]
> > >>> FILE_GUID = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
> > >>> MODULE_TYPE = DXE_DRIVER
> > >>> VERSION_STRING = 1.0
> > >>> - LIBRARY_CLASS = RngLib|DXE_DRIVER UEFI_APPLICATION
> > >> UEFI_DRIVER
> > >>> + LIBRARY_CLASS = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> > >>> UEFI_APPLICATION UEFI_DRIVER
> > >>>
> > >>> [Packages]
> > >>> MdePkg/MdePkg.dec
> > >>> --
> > >>> 2.21.0.windows.1
> > >>
> > >> IMPORTANT NOTICE: The contents of this email and any attachments
> are
> > >> confidential and may also be privileged. If you are not the intended
> > > recipient,
> > >> please notify the sender immediately and do not disclose the contents
> to
> > > any
> > >> other person, use it for any purpose, or store or copy the
information
> in
> > > any
> > >> medium. Thank you.
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-13 5:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-04 19:03 [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib Pete Batard
2020-11-11 17:05 ` [edk2-devel] " Andrei Warkentin
2020-11-11 17:37 ` Samer El-Haj-Mahmoud
2020-11-12 1:52 ` 回复: [edk2-devel] " gaoliming
2020-11-12 12:09 ` Pete Batard
2020-11-12 13:41 ` 回复: " gaoliming
[not found] ` <1646C675163A08FD.26994@groups.io>
2020-11-13 5:48 ` gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox