From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web08.25516.1605002027550960024 for ; Tue, 10 Nov 2020 01:53:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=kqLDfs8Q; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id c17so11951290wrc.11 for ; Tue, 10 Nov 2020 01:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=T2q3YYW+9pxTmtbat73pEPF+GQqJcpZvP+5pd8MbwVA=; b=kqLDfs8Q1W2Rcgx9y+IAhOElNDKB3fs72gH5KRFVgjhfG+dghMJQaRvdW+VJUejwvd vwolQjGLsQzAXzJx4AiffGiPLNcl5vB9KhJRzwX8tbFnyTDqGMG9vDVqmoffeEY7bCgR OT9xAMHuGcg11gQ05WR1FhiT2qvCH5vw+EZ40AqUcbteRnC0hQ7gfUF+egUF5D8BqNVf eIvABTfR8Wq141SXE2rtNX5OV75fXO5MueEe9f3CJzzyotbjEDBCXkLJKnuYGITx2dMq mLrot5Jg+CzhwL8h0PBtWSL0sF3jukP8CI3p/8FLy+72a+5zyEcOz/cYnI3EhF9D1Wzf Z3bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=T2q3YYW+9pxTmtbat73pEPF+GQqJcpZvP+5pd8MbwVA=; b=PDFzsfNyuFq94l9Qr5OcVhYETuoaAxhL4y9FRrVvwOB6u3ld/N1LazL4eObcxo3xML pWmdmnh88tae5zDYMurWIo8dsPNYzAls++A0afcsUslIOlACqpp6SswReMiWw6gkufV/ TQTucWtLpiZNLIY6/Ygz8B5YLhQzGCgliucTzZ6ks4LJ7uCrlVzyIOAOXM04ORCgo2El V5ed9Fgi4KYERml7/WCQj0eNIl2xfe8WDXJQoOuvNE/oFRnvYZsnIX/iJzi3sRdga/qr SMuVba5zvOR0d5IMt9LAyj1V0pgKp2uYpoNdDJ6jAAiJnSn5vOxhxII0uaqNoIKqwv6K hg3g== X-Gm-Message-State: AOAM532Dy7lZR9mLLmWHOcYq5+uqxeqjFsSfyR0FJWAeYx6T0DtG3ZFk i5doU0Mi5CeXZhZ3ptuC2XVUxw== X-Google-Smtp-Source: ABdhPJztHOBCanXeaexGPd8ih3pTuld+CsJpnO0ipTaezz6UcJ+vyVEYlVvup4xLeMwgiUT0eY+yqg== X-Received: by 2002:a5d:6046:: with SMTP id j6mr23178076wrt.317.1605002026080; Tue, 10 Nov 2020 01:53:46 -0800 (PST) Return-Path: Received: from vanye (cpc92880-cmbg19-2-0-cust79.5-4.cable.virginm.net. [82.27.104.80]) by smtp.gmail.com with ESMTPSA id s133sm2420067wmf.30.2020.11.10.01.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 01:53:45 -0800 (PST) Date: Tue, 10 Nov 2020 09:53:43 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v2 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Message-ID: <20201110095343.GC1664@vanye> References: <20201104225055.18220-1-rebecca@nuviainc.com> <20201104225055.18220-2-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20201104225055.18220-2-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 04, 2020 at 15:50:53 -0700, Rebecca Cran wrote: > The ARM SMC Architecture functions were missing from ArmStdSmc.h. Add > them, and remove the version numbers for the SMCCC and PSCI, since > they're unused and look like they may have been for code that's no longer > present. Could you possibly split this out into two separate patches? One for deleting the unused macros, and one for adding the new ones? Since we're very close to going into feature freeze, I think we'll hold off merging this until after the stable tag. / Leif > Signed-off-by: Rebecca Cran > --- > ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 26 ++++++++++----------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > index 3509eb680f18..20642756bce8 100644 > --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h > @@ -1,5 +1,6 @@ > /** @file > * > +* Copyright (c) 2020, NUVIA Inc. All rights reserved. > * Copyright (c) 2012-2017, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -27,13 +28,6 @@ > #define ARM_SMC_STD_UUID2 0xfbc02dae > #define ARM_SMC_STD_UUID3 0xe2f64156 > > -/* > - * ARM Standard Service Calls revision numbers > - * The current revision is: 0.1 > - */ > -#define ARM_SMC_STD_REVISION_MAJOR 0x0 > -#define ARM_SMC_STD_REVISION_MINOR 0x1 > - > /* > * Management Mode (MM) calls cover a subset of the Standard Service Call range. > * The list below is not exhaustive. > @@ -52,6 +46,18 @@ > #define ARM_SMC_MM_RET_DENIED -3 > #define ARM_SMC_MM_RET_NO_MEMORY -4 > > +// ARM Architecture Calls > +#define ARM_SMC_ID_ARCH_VERSION 0x80000000 > +#define ARM_SMC_ID_ARCH_FEATURES 0x80000001 > +#define ARM_SMC_ID_ARCH_SOC_ID 0x80000002 > +#define ARM_SMC_ID_ARCH_WORKAROUND_1 0x80008000 > +#define ARM_SMC_ID_ARCH_WORKAROUND_2 0x80007FFF > + > +#define ARM_SMC_ARCH_RET_SUCCESS 0 > +#define ARM_SMC_ARCH_RET_NOT_SUPPORTED -1 > +#define ARM_SMC_ARCH_RET_NOT_REQUIRED -2 > +#define ARM_SMC_ARCH_RET_INVALID_PARAMETER -3 > + > /* > * Power State Coordination Interface (PSCI) calls cover a subset of the > * Standard Service Call range. > @@ -70,12 +76,6 @@ > #define ARM_SMC_ID_PSCI_SYSTEM_OFF 0x84000008 > #define ARM_SMC_ID_PSCI_SYSTEM_RESET 0x84000009 > > -/* The current PSCI version is: 0.2 */ > -#define ARM_SMC_PSCI_VERSION_MAJOR 0 > -#define ARM_SMC_PSCI_VERSION_MINOR 2 > -#define ARM_SMC_PSCI_VERSION \ > - ((ARM_SMC_PSCI_VERSION_MAJOR << 16) | ARM_SMC_PSCI_VERSION_MINOR) > - > /* PSCI return error codes */ > #define ARM_SMC_PSCI_RET_SUCCESS 0 > #define ARM_SMC_PSCI_RET_NOT_SUPPORTED -1 > -- > 2.26.2 >