From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.31129.1605029857666972063 for ; Tue, 10 Nov 2020 09:37:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: zhichao.gao@intel.com) IronPort-SDR: jdIRusfe9vm4DMznd8ZncBs1BuD3+j0/iFmMYQXm5yBeqFbIHP5Q4ZF2S+SiZTXw1cVcw0y4DD s9x71/3FHOtg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="169234329" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="169234329" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 09:37:18 -0800 IronPort-SDR: VT1/Bn3+5kErbMnJtTaPafH61YNHsSejDlVe3hvwMItbF9EEW7rW4P3pe1HYwQZUkqFzPAlWKj 2MwtW89Mt7+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="473509681" Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga004.jf.intel.com with ESMTP; 10 Nov 2020 09:37:14 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu Subject: [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default Date: Wed, 11 Nov 2020 01:36:50 +0800 Message-Id: <20201110173651.54036-12-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com> References: <20201110173651.54036-1-zhichao.gao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 iSCSI is using the undeprecated function MD5. It is better to make the default setting secure. If the platforms want to use the iSCSI, they should enable it in the platforms' dsc file and be aware they are using an unsafe function. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Zhichao Gao --- NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkDefines.dsc.inc b/NetworkPkg/NetworkDefines.dsc.inc index a442d1b157..18921d81f6 100644 --- a/NetworkPkg/NetworkDefines.dsc.inc +++ b/NetworkPkg/NetworkDefines.dsc.inc @@ -17,7 +17,7 @@ # DEFINE NETWORK_TLS_ENABLE = TRUE # DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE # DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE -# DEFINE NETWORK_ISCSI_ENABLE = TRUE +# DEFINE NETWORK_ISCSI_ENABLE = FALSE # DEFINE NETWORK_VLAN_ENABLE = TRUE # # Copyright (c) 2019, Intel Corporation. All rights reserved.
@@ -101,7 +101,7 @@ # Both OpensslLib.inf and OpensslLibCrypto.inf library instance can be used # since libssl is not required for iSCSI. # - DEFINE NETWORK_ISCSI_ENABLE = TRUE + DEFINE NETWORK_ISCSI_ENABLE = FALSE !endif !if $(NETWORK_ENABLE) == TRUE -- 2.21.0.windows.1