public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: devel@edk2.groups.io
Cc: Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Leif Lindholm <leif@nuviainc.com>
Subject: [PATCH V3 06/12] ArmVirtPkg/ArmVirtQemuKernel.dsc: Enable MD5 while enable iSCSI
Date: Wed, 11 Nov 2020 01:36:45 +0800	[thread overview]
Message-ID: <20201110173651.54036-7-zhichao.gao@intel.com> (raw)
In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003

There is a plan to make MD5 disable as default.
The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES
would be introduced to enable MD5. Make the
definition ahead of the change to avoid build
error after the MACRO changed.

Enalbe iSCSI.

Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
---
 ArmVirtPkg/ArmVirtQemuKernel.dsc | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index 9449a01d6e..714dc6cf89 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -1,7 +1,7 @@
 #
 #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
 #  Copyright (c) 2014, Linaro Limited. All rights reserved.
-#  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -38,6 +38,7 @@
   DEFINE NETWORK_SNP_ENABLE              = FALSE
   DEFINE NETWORK_TLS_ENABLE              = FALSE
   DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS  = TRUE
+  DEFINE NETWORK_ISCSI_ENABLE            = TRUE
 
 !if $(NETWORK_SNP_ENABLE) == TRUE
   !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
@@ -47,6 +48,11 @@
 
 !include ArmVirtPkg/ArmVirt.dsc.inc
 
+[BuildOptions]
+!if $(NETWORK_ISCSI_ENABLE) == TRUE
+  *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES
+!endif
+
 [LibraryClasses.common]
   ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
   ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
-- 
2.21.0.windows.1


  parent reply	other threads:[~2020-11-10 17:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 17:36 [PATCH V3 00/12] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 01/12] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 02/12] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 03/12] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-11-11 22:21   ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-11-11 22:18   ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: " Gao, Zhichao
2020-11-11 21:53   ` Laszlo Ersek
2020-11-10 17:36 ` Gao, Zhichao [this message]
2020-11-11 21:58   ` [PATCH V3 06/12] ArmVirtPkg/ArmVirtQemuKernel.dsc: " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 07/12] OvmfPkg/OvmfPkgIa32.dsc: " Gao, Zhichao
2020-11-11 22:05   ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 08/12] OvmfPkg/OvmfPkgIa32X64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 09/12] OvmfPkg/OvmfPkgX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 10/12] OvmfPkg/BhyveX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-11-11 22:11   ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 12/12] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110173651.54036-7-zhichao.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox