From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH V3 08/12] OvmfPkg/OvmfPkgIa32X64.dsc: Enable MD5 while enable iSCSI
Date: Wed, 11 Nov 2020 01:36:47 +0800 [thread overview]
Message-ID: <20201110173651.54036-9-zhichao.gao@intel.com> (raw)
In-Reply-To: <20201110173651.54036-1-zhichao.gao@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003
There is a plan to make MD5 disable as default.
The new MACRO ENABLE_MD5_DEPRECATED_INTERFACES
would be introduced to enable MD5. Make the
definition ahead of the change to avoid build
error after the MACRO changed.
Enalbe iSCSI.
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
OvmfPkg/OvmfPkgIa32X64.dsc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 3551f9710a..7ddb363d7d 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -41,6 +41,7 @@
DEFINE NETWORK_IP6_ENABLE = FALSE
DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
+ DEFINE NETWORK_ISCSI_ENABLE = TRUE
!include NetworkPkg/NetworkDefines.dsc.inc
@@ -90,6 +91,10 @@
INTEL:*_*_*_CC_FLAGS = /D DISABLE_NEW_DEPRECATED_INTERFACES
GCC:*_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
+!if $(NETWORK_ISCSI_ENABLE) == TRUE
+ *_*_*_CC_FLAGS = -D ENABLE_MD5_DEPRECATED_INTERFACES
+!endif
+
[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
XCODE:*_*_*_DLINK_FLAGS = -seg1addr 0x1000 -segalign 0x1000
--
2.21.0.windows.1
next prev parent reply other threads:[~2020-11-10 17:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 17:36 [PATCH V3 00/12] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 01/12] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 02/12] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 03/12] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-11-11 22:21 ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 04/12] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-11-11 22:18 ` [edk2-devel] " Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 05/12] ArmVirtPkg/ArmVirtQemu.dsc: " Gao, Zhichao
2020-11-11 21:53 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 06/12] ArmVirtPkg/ArmVirtQemuKernel.dsc: " Gao, Zhichao
2020-11-11 21:58 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 07/12] OvmfPkg/OvmfPkgIa32.dsc: " Gao, Zhichao
2020-11-11 22:05 ` Laszlo Ersek
2020-11-10 17:36 ` Gao, Zhichao [this message]
2020-11-10 17:36 ` [PATCH V3 09/12] OvmfPkg/OvmfPkgX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 10/12] OvmfPkg/BhyveX64.dsc: " Gao, Zhichao
2020-11-10 17:36 ` [PATCH V3 11/12] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-11-11 22:11 ` Laszlo Ersek
2020-11-10 17:36 ` [PATCH V3 12/12] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110173651.54036-9-zhichao.gao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox