From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.509.1605160578113396558 for ; Wed, 11 Nov 2020 21:56:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) IronPort-SDR: DQQfqu6ho2vfosj/S3IwkcgBxcGVZshrD+vz6W19lh2noXBKbs6cUbdzMpdPLM1Nw9m1Mi5ORI T75mixNceeAw== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="254971158" X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="254971158" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 21:56:16 -0800 IronPort-SDR: JTKZU8ITwlA0iS1xy2QiTyVeGK1tjxYWeNhkdy+65x94lXerjfkZbfgGqSAGscOnNvPMWDf+xU sDuo8VjDgiEw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,471,1596524400"; d="scan'208";a="366490762" Received: from fieedk001.ccr.corp.intel.com ([10.239.153.118]) by orsmga007.jf.intel.com with ESMTP; 11 Nov 2020 21:56:11 -0800 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar , Leif Lindholm , Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Michael D Kinney , Kelly Steele , Zailiang Sun , Yi Qian , Liming Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Roger Feng , Zhiguang Liu Subject: [PATCH V4 00/13] Disable the deprecated MD5 and SHA1 support Date: Thu, 12 Nov 2020 13:55:45 +0800 Message-Id: <20201112055558.2348-1-zhichao.gao@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3003 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3021 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027 MD5 is deprecated, make it disable as default for security. It required to set MD5 enable explicitly if the module is still using MD5. List the modules that are still using it: iSCSI, Hash2DxeCrypto, CryptoDxe(Pei, Smm) (with PACKAGE or ALL config). This patch set would affact the platforms that are using iSCSI function. V2: Remove MD5 and SHA1 support of Hash2DxeCrypto. Remove the MD5 GUID defination in MdePkg.dec. SHA1 related GUIDs are still using in TPM2, so keep them. No requirement to add MD5 enable MACRO in SecurityPkg. V3: Explicitly enable iSCSI for ArmVirtQemu, ArmVirtQemuKernel, OvmfPkgIa32, OvmfPkgIa32X64, OvmfPkgX64 and BhyveX64. And set the MD5 enable base on the new MD5 MACRO. Rejust the patch order. V14: Fix some typos. Change the commit message. Add NetworkBuildOptions.dsc.inc and add the MACRO for different toolchain. Using inc file in the related package dsc file: ArmVirtQemu, ArmVirtQemuKernel, OvmfPkgIa32, OvmfPkgIa32X64, OvmfPkgX64, OvmfXen and BhyveX64. Enable iSCSI in NetworkPkg.dsc for build test. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Leif Lindholm Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Michael D Kinney Cc: Kelly Steele Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Roger Feng Cc: Zhiguang Liu Signed-off-by: Zhichao Gao Zhichao Gao (13): SecurityPkg/Hash2DxeCrypto: Remove MD5 support SecurityPkg/Hash2DxeCrypto: Remove SHA1 support CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 NetworkPkg: Enable MD5 while enable iSCSI ArmVirtPkg/ArmVirtQemu.dsc: Enable MD5 while enable iSCSI ArmVirtPkg/ArmVirtQemuKernel.dsc: Enable MD5 while enable iSCSI OvmfPkg/OvmfPkgIa32.dsc: Enable MD5 while enable iSCSI OvmfPkg/OvmfPkgIa32X64.dsc: Enable MD5 while enable iSCSI OvmfPkg/OvmfPkgX64.dsc: Enable MD5 while enable iSCSI OvmfPkg/OvmfXen.dsc: Enable MD5 while enable iSCSI OvmfPkg/BhyveX64.dsc: Enable MD5 while enable iSCSI NetworkPkg/Defines: Make iSCSI disable as default CryptoPkg: Make the MD5 disable as default for security ArmVirtPkg/ArmVirtQemu.dsc | 6 ++++- ArmVirtPkg/ArmVirtQemuKernel.dsc | 5 ++++- CryptoPkg/CryptoPkg.dsc | 6 +++++ CryptoPkg/Driver/Crypto.c | 4 ++-- CryptoPkg/Include/Library/BaseCryptLib.h | 2 +- .../Library/BaseCryptLib/Hash/CryptMd5.c | 2 +- .../BaseCryptLibOnProtocolPpi/CryptLib.c | 2 +- NetworkPkg/Network.dsc.inc | 5 ++++- NetworkPkg/NetworkBuildOptions.dsc.inc | 22 +++++++++++++++++++ NetworkPkg/NetworkDefines.dsc.inc | 4 ++-- NetworkPkg/NetworkPkg.dsc | 4 +++- OvmfPkg/Bhyve/BhyveX64.dsc | 5 ++++- OvmfPkg/OvmfPkgIa32.dsc | 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/OvmfPkgX64.dsc | 3 +++ OvmfPkg/OvmfXen.dsc | 3 +++ SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 2 -- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 4 +--- 18 files changed, 68 insertions(+), 17 deletions(-) create mode 100644 NetworkPkg/NetworkBuildOptions.dsc.inc -- 2.21.0.windows.1